Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Issue 2844993002: [cleanup] Drop some dead code from Crankshaft. (Closed)

Created:
3 years, 8 months ago by Benedikt Meurer
Modified:
3 years, 8 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[cleanup] Drop some dead code from Crankshaft. This code was confusing, as it wasn't immediately obvious that this is dead and doesn't need to updated anymore. R=yangguo@chromium.org Review-Url: https://codereview.chromium.org/2844993002 Cr-Commit-Position: refs/heads/master@{#44911} Committed: https://chromium.googlesource.com/v8/v8/+/10980eb56e65b9c54f6a66e868dcd4ee50eed237

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -260 lines) Patch
M src/crankshaft/hydrogen.h View 4 chunks +0 lines, -20 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 3 chunks +0 lines, -240 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Benedikt Meurer
3 years, 8 months ago (2017-04-27 05:25:40 UTC) #1
Benedikt Meurer
Hey Yang, Here's a tiny bit of cleanup on Crankshaft. Please take a look. Thanks, ...
3 years, 8 months ago (2017-04-27 05:26:27 UTC) #5
Yang
On 2017/04/27 05:26:27, Benedikt Meurer wrote: > Hey Yang, > > Here's a tiny bit ...
3 years, 8 months ago (2017-04-27 05:27:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2844993002/1
3 years, 8 months ago (2017-04-27 05:29:25 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-27 06:15:33 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/10980eb56e65b9c54f6a66e868dcd4ee50e...

Powered by Google App Engine
This is Rietveld 408576698