Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1257)

Issue 2844983002: Prune ComputeVisibleSelectionInDOMTreeDeprecated from DOMSelection::deleteFromDocument (Closed)

Created:
3 years, 8 months ago by Xiaocheng
Modified:
3 years, 8 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Prune ComputeVisibleSelectionInDOMTreeDeprecated from DOMSelection::deleteFromDocument This patch prunes the deprecated function from DOMSelection::deleteFromDocument to improve code health. BUG=698633 TEST=n/a; no behaviorial change Review-Url: https://codereview.chromium.org/2844983002 Cr-Commit-Position: refs/heads/master@{#467612} Committed: https://chromium.googlesource.com/chromium/src/+/c083e9097f40b9618834c7f845e46fa1dd5d7ee0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M third_party/WebKit/Source/core/editing/DOMSelection.cpp View 2 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Xiaocheng
PTAL.
3 years, 8 months ago (2017-04-27 04:27:02 UTC) #4
yosin_UTC9
lgtm
3 years, 8 months ago (2017-04-27 04:33:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2844983002/1
3 years, 8 months ago (2017-04-27 04:33:53 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-27 07:00:05 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c083e9097f40b9618834c7f845e4...

Powered by Google App Engine
This is Rietveld 408576698