Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 2844963006: Remove WebMediaPlayerClient::RequestReload() (Closed)

Created:
3 years, 7 months ago by tguilbert
Modified:
3 years, 7 months ago
CC:
apacible+watch_chromium.org, blink-reviews, blink-reviews-api_chromium.org, blink-reviews-html_chromium.org, chfremer+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, eric.carlson_apple.com, erickung+watch_chromium.org, feature-media-reviews_chromium.org, fs, gasubic, jam, miu+watch_chromium.org, mlamouri+watch-content_chromium.org, mlamouri+watch-blink_chromium.org, posciak+watch_chromium.org, nessy, Srirama, xjz+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove WebMediaPlayerClient::RequestReload() The WMPC::RequestReload() interface was introduced as part of the fix for crbug.com/618109. The interface allows us to re-create an instance of WMPI, if the final redirected URL is an HLS url. The RendererFactorySelector allows us change Renderer types, after WMPI has been created. This removes the need for a RequestReload interface. BUG=715244 Review-Url: https://codereview.chromium.org/2844963006 Cr-Commit-Position: refs/heads/master@{#468758} Committed: https://chromium.googlesource.com/chromium/src/+/7473717100889a6245a01e3683215a64fe2aec1a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -19 lines) Patch
M content/renderer/media/webmediaplayer_ms_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M media/blink/webmediaplayer_impl_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLMediaElement.h View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLMediaElement.cpp View 3 chunks +2 lines, -12 lines 0 comments Download
M third_party/WebKit/public/platform/WebMediaPlayerClient.h View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
tguilbert
PTAL! Thanks Thomas
3 years, 7 months ago (2017-04-28 00:20:05 UTC) #2
DaleCurtis
lgtm
3 years, 7 months ago (2017-04-28 00:21:11 UTC) #3
tguilbert
jochen@, can you OWNERS review content/* and third_party/WebKit/*? Thank you!
3 years, 7 months ago (2017-04-28 00:28:46 UTC) #5
jochen (gone - plz use gerrit)
lgtm
3 years, 7 months ago (2017-05-02 09:18:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2844963006/1
3 years, 7 months ago (2017-05-02 18:44:52 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-02 20:18:55 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7473717100889a6245a01e368321...

Powered by Google App Engine
This is Rietveld 408576698