[Ash] Disallow calling HoverHighlightView::SetSubText() with an empty string

[Ash] Disallow calling HoverHighlightView::SetSubText() with an empty string

SetSubText() in HoverHighlight view should not be called
if the parameter string is empty, otherwise multi-line
rows in the system menu will have the incorrect layout
of their primary text.

BUG=715615
TEST=manual

Review-Url: https://codereview.chromium.org/2844933003
Cr-Commit-Position: refs/heads/master@{#467813}
Committed: https://chromium.googlesource.com/chromium/src/+/f8ef156d997fe415dfb94b4917a2a6ed648d626b

[tdanderson, 2017-04-27 18:53:55]

The CQ bit was checked by tdanderson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 18:54:19]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tdanderson, 2017-04-27 18:54:46]

tdanderson@chromium.org changed reviewers:
+ mohsen@chromium.org

[tdanderson, 2017-04-27 18:54:46]

mohsen@ can you please take a look?

[commit-bot: I haz the power, 2017-04-27 19:34:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 19:34:33]

Dry run: This issue passed the CQ dry run.

[mohsen, 2017-04-27 19:39:37]

https://codereview.chromium.org/2844933003/diff/1/ash/system/tray/hover_highl...
File ash/system/tray/hover_highlight_view.cc (right):

https://codereview.chromium.org/2844933003/diff/1/ash/system/tray/hover_highl...
ash/system/tray/hover_highlight_view.cc:59: if (sub_text.empty())
We should either disallow empty string altogether (by DCHECKing) or at least
clear the |sub_text_label_|'s text if it already exists (if we don't want to
remove the label entirely). WDYT?

[tdanderson, 2017-04-27 20:51:13]

The CQ bit was checked by tdanderson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 20:51:49]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tdanderson, 2017-04-27 20:52:06]

Description was changed from

==========
[Ash] Make HoverHighlightView::SetSubText() a no-op with empty string

SetSubText() in HoverHighlight view should be a no-op
if the parameter string is empty, otherwise multi-line
rows in the system menu will have the incorrect layout
of their primary text.

BUG=715615
TEST=manual
==========

to

==========
[Ash] Disallow calling HoverHighlightView::SetSubText() with an empty string

SetSubText() in HoverHighlight view should not be called
if the parameter string is empty, otherwise multi-line
rows in the system menu will have the incorrect layout
of their primary text.

BUG=715615
TEST=manual
==========

[tdanderson, 2017-04-27 20:52:16]

Mohsen, please take another look

https://codereview.chromium.org/2844933003/diff/1/ash/system/tray/hover_highl...
File ash/system/tray/hover_highlight_view.cc (right):

https://codereview.chromium.org/2844933003/diff/1/ash/system/tray/hover_highl...
ash/system/tray/hover_highlight_view.cc:59: if (sub_text.empty())
On 2017/04/27 19:39:37, mohsen wrote:
> We should either disallow empty string altogether (by DCHECKing) or at least
> clear the |sub_text_label_|'s text if it already exists (if we don't want to
> remove the label entirely). WDYT?

Done.

[mohsen, 2017-04-27 20:58:15]

lgtm

[tdanderson, 2017-04-27 20:58:55]

The CQ bit was unchecked by tdanderson@chromium.org

[tdanderson, 2017-04-27 21:01:09]

The CQ bit was checked by tdanderson@chromium.org

[commit-bot: I haz the power, 2017-04-27 21:02:14]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 01:47:51]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493326869710130,
"parent_rev": "0b6049cb383da885119055f499d26ff50d78a37c", "commit_rev":
"f8ef156d997fe415dfb94b4917a2a6ed648d626b"}

[commit-bot: I haz the power, 2017-04-28 01:47:57]

Description was changed from

==========
[Ash] Disallow calling HoverHighlightView::SetSubText() with an empty string

SetSubText() in HoverHighlight view should not be called
if the parameter string is empty, otherwise multi-line
rows in the system menu will have the incorrect layout
of their primary text.

BUG=715615
TEST=manual
==========

to

==========
[Ash] Disallow calling HoverHighlightView::SetSubText() with an empty string

SetSubText() in HoverHighlight view should not be called
if the parameter string is empty, otherwise multi-line
rows in the system menu will have the incorrect layout
of their primary text.

BUG=715615
TEST=manual

Review-Url: https://codereview.chromium.org/2844933003
Cr-Commit-Position: refs/heads/master@{#467813}
Committed:
https://chromium.googlesource.com/chromium/src/+/f8ef156d997fe415dfb94b4917a2...
==========

[commit-bot: I haz the power, 2017-04-28 01:48:02]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f8ef156d997fe415dfb94b4917a2...