Drop GetFrame()->GetDocument() usage in FrameFetchContext

Drop GetFrame()->GetDocument() usage in FrameFetchContext

It's a workaround for the fact that FrameFetchContext::GetDocument() will be
null before FrameFetchConext::document_loader_ commits, and in that case,
it's not right to go to GetFrame()->GetDocument(), which is an unrelated
Document. Either get to the relevant ExecutionContext, or use LocalFrame
directly where an ExecutionContext/SecurityContext isn't needed (e.g., for UseCounters).

BUG=

Review-Url: https://codereview.chromium.org/2844913002
Cr-Commit-Position: refs/heads/master@{#469127}
Committed: https://chromium.googlesource.com/chromium/src/+/20f06e18b747e0f99ed657ce461c4db97fb97f7c

[Nate Chapin, 2017-04-26 23:44:59]

The CQ bit was checked by japhet@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-26 23:45:49]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 01:13:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 01:13:53]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Nate Chapin, 2017-04-28 17:34:51]

The CQ bit was checked by japhet@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 17:35:32]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 18:42:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 18:42:35]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Nate Chapin, 2017-04-28 21:22:12]

The CQ bit was checked by japhet@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 21:22:41]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nate Chapin, 2017-04-28 21:33:02]

Description was changed from

==========
Drop GetFrame()->GetDocument() usage in FrameFetchContext

It's a workaround for the fact that FrameFetchContext::GetDocument() will be
null before FrameFetchConext::document_loader_ commits, and in that case,
it's not right to go to GetFrame()->GetDocument(), which is an unrelated
Document. Either get to to the appropriate ExecutionContext, or use LocalFrame
directly, as appropriate.

BUG=
==========

to

==========
Drop GetFrame()->GetDocument() usage in FrameFetchContext

It's a workaround for the fact that FrameFetchContext::GetDocument() will be
null before FrameFetchConext::document_loader_ commits, and in that case,
it's not right to go to GetFrame()->GetDocument(), which is an unrelated
Document. Either get to the relevant ExecutionContext, or use LocalFrame
directly where an ExecutionContext/SecurityContext isn't needed (e.g., for
UseCounters).

BUG=
==========

[Nate Chapin, 2017-04-28 21:33:31]

japhet@chromium.org changed reviewers:
+ kinuko@chromium.org, yoav@yoav.ws

[Nate Chapin, 2017-04-28 21:33:32]

kinuko: PTAL
yoav: Please sanity-check the LinkLoader changes :)

https://codereview.chromium.org/2844913002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/loader/BaseFetchContext.cpp (right):

https://codereview.chromium.org/2844913002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/BaseFetchContext.cpp:265: :
GetParentSecurityContext();
The only reason GetMainResourceSecurityContext() needed to reference
GetFrame()->GetDocument() was to handle the iframe load case. In that case,
there must be a parent with a valid SecurityContext (whether local or remote),
and technically the parent is what's embedding things we want to deprecate
anyway. Reference this frame's for subresources, and the parent's for iframe
main resources.

https://codereview.chromium.org/2844913002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/loader/LinkLoader.cpp (right):

https://codereview.chromium.org/2844913002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/LinkLoader.cpp:133: static void
SendMessageToConsoleForPossiblyNullDocument(
I hate this name, but I don't have a better idea. It's a similar problem to the
one in FrameFetchContext::AddConsoleMessage.

[commit-bot: I haz the power, 2017-04-28 23:45:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 23:45:36]

Dry run: This issue passed the CQ dry run.

[kinuko, 2017-04-29 14:10:21]

lgtm

https://codereview.chromium.org/2844913002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/loader/BaseFetchContext.cpp (right):

https://codereview.chromium.org/2844913002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/BaseFetchContext.cpp:265: :
GetParentSecurityContext();
On 2017/04/28 21:33:31, Nate Chapin wrote:
> The only reason GetMainResourceSecurityContext() needed to reference
> GetFrame()->GetDocument() was to handle the iframe load case. In that case,
> there must be a parent with a valid SecurityContext (whether local or remote),
> and technically the parent is what's embedding things we want to deprecate
> anyway. Reference this frame's for subresources, and the parent's for iframe
> main resources.

This is much clearer now, thanks!

https://codereview.chromium.org/2844913002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/loader/LinkLoader.cpp (right):

https://codereview.chromium.org/2844913002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/LinkLoader.cpp:133: static void
SendMessageToConsoleForPossiblyNullDocument(
On 2017/04/28 21:33:31, Nate Chapin wrote:
> I hate this name, but I don't have a better idea. It's a similar problem to
the
> one in FrameFetchContext::AddConsoleMessage.

Maybe add the same comment with the one in FrameFetchContext?

[Yoav Weiss, 2017-05-03 07:13:43]

lgtm

[Nate Chapin, 2017-05-03 19:24:04]

The CQ bit was checked by japhet@chromium.org

[Nate Chapin, 2017-05-03 19:24:04]

The patchset sent to the CQ was uploaded after l-g-t-m from kinuko@chromium.org,
yoav@yoav.ws
Link to the patchset: https://codereview.chromium.org/2844913002/#ps60001
(title: "Add comment in SendMessageToConsoleForPossiblyNullDocument")

[commit-bot: I haz the power, 2017-05-03 19:24:53]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 21:15:42]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1493839444425350,
"parent_rev": "f2a6f71677b02832b9dec1b94ce8abc43cd696df", "commit_rev":
"20f06e18b747e0f99ed657ce461c4db97fb97f7c"}

[commit-bot: I haz the power, 2017-05-03 21:16:02]

Description was changed from

==========
Drop GetFrame()->GetDocument() usage in FrameFetchContext

It's a workaround for the fact that FrameFetchContext::GetDocument() will be
null before FrameFetchConext::document_loader_ commits, and in that case,
it's not right to go to GetFrame()->GetDocument(), which is an unrelated
Document. Either get to the relevant ExecutionContext, or use LocalFrame
directly where an ExecutionContext/SecurityContext isn't needed (e.g., for
UseCounters).

BUG=
==========

to

==========
Drop GetFrame()->GetDocument() usage in FrameFetchContext

It's a workaround for the fact that FrameFetchContext::GetDocument() will be
null before FrameFetchConext::document_loader_ commits, and in that case,
it's not right to go to GetFrame()->GetDocument(), which is an unrelated
Document. Either get to the relevant ExecutionContext, or use LocalFrame
directly where an ExecutionContext/SecurityContext isn't needed (e.g., for
UseCounters).

BUG=

Review-Url: https://codereview.chromium.org/2844913002
Cr-Commit-Position: refs/heads/master@{#469127}
Committed:
https://chromium.googlesource.com/chromium/src/+/20f06e18b747e0f99ed657ce461c...
==========

[commit-bot: I haz the power, 2017-05-03 21:16:04]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/20f06e18b747e0f99ed657ce461c...