Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 2844883004: Revert of [tools/perf] Disable browse:chrome:newtab (Closed)

Created:
3 years, 8 months ago by ssid
Modified:
3 years, 8 months ago
Reviewers:
nednguyen, perezju
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [tools/perf] Disable browse:chrome:newtab (patchset #1 id:1 of https://codereview.chromium.org/2827623002/ ) Reason for revert: The issue with InputText was fixed in crrev.com/2822573002 Original issue's description: > [tools/perf] Disable browse:chrome:newtab > > Story is failing on android bots. > > TBR=nednguyen@google.com,ssid@chromium.org > BUG=712590 > > Review-Url: https://codereview.chromium.org/2827623002 > Cr-Commit-Position: refs/heads/master@{#465199} > Committed: https://chromium.googlesource.com/chromium/src/+/6a10d876438a19c51bf3d73d7f4484255718a5a2 TBR=nednguyen@google.com,perezju@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=712590 Review-Url: https://codereview.chromium.org/2844883004 Cr-Commit-Position: refs/heads/master@{#467579} Committed: https://chromium.googlesource.com/chromium/src/+/8a4c38833ae890a2b12fb416d4c9375a6de5c051

Patch Set 1 #

Patch Set 2 : Do not remove import. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M tools/perf/page_sets/system_health/searching_stories.py View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
ssid
Created Revert of [tools/perf] Disable browse:chrome:newtab
3 years, 8 months ago (2017-04-27 00:35:55 UTC) #1
ssid
ptal, thanks!
3 years, 8 months ago (2017-04-27 00:41:31 UTC) #4
nednguyen
lgtm
3 years, 8 months ago (2017-04-27 00:42:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2844883004/40001
3 years, 8 months ago (2017-04-27 01:06:59 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-27 04:30:42 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/8a4c38833ae890a2b12fb416d4c9...

Powered by Google App Engine
This is Rietveld 408576698