Override MAXIMIZED window show state if window size / position is manually specified.

Override MAXIMIZED window show state if window size / position is manually specified.

BUG=715729
Review-Url: https://codereview.chromium.org/2844843002
Cr-Commit-Position: refs/heads/master@{#468321}
Committed: https://chromium.googlesource.com/chromium/src/+/7938b191e4a1bae161445ab33dd664a1afa799b7

[chrisha, 2017-04-26 21:32:18]

The CQ bit was checked by chrisha@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-26 21:33:25]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chrisha, 2017-04-26 21:33:53]

chrisha@chromium.org changed reviewers:
+ pkasting@chromium.org

[chrisha, 2017-04-26 21:33:54]

Do you think this makes sense?

[Peter Kasting, 2017-04-26 22:30:28]

LGTM, but I'd like to see a test for this.

If you think this is the root cause of bug 715729, set that as BUG= and take
that bug.

[Peter Kasting, 2017-04-26 22:31:54]

Also note that the bug talks about --ash-host-window-bounds, dunno what that is.

[commit-bot: I haz the power, 2017-04-26 23:01:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-26 23:01:17]

Dry run: This issue passed the CQ dry run.

[chrisha, 2017-04-28 13:52:10]

Description was changed from

==========
Override MAXIMIZED window show state if window size / position is manually
specified.

BUG=
==========

to

==========
Override MAXIMIZED window show state if window size / position is manually
specified.

BUG=715729
==========

[chrisha, 2017-04-28 13:53:00]

On 2017/04/26 22:31:54, Peter Kasting (OOO thru May 3) wrote:
> Also note that the bug talks about --ash-host-window-bounds, dunno what that
is.

Yeah, I'll look into that separately.

Added a quick unittest of the command-line parsing logic. Another look?

[chrisha, 2017-04-28 13:53:58]

The CQ bit was checked by chrisha@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 13:54:33]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 14:04:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 14:04:48]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[chrisha, 2017-05-01 15:00:52]

The CQ bit was checked by chrisha@chromium.org

[chrisha, 2017-05-01 15:00:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org
Link to the patchset: https://codereview.chromium.org/2844843002/#ps40001
(title: "Added missing unittest file.")

[commit-bot: I haz the power, 2017-05-01 15:01:06]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-01 16:14:26]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493650852679680,
"parent_rev": "8ad94eb92a8269ec545b6ef30c4311f8125d6f22", "commit_rev":
"7938b191e4a1bae161445ab33dd664a1afa799b7"}

[commit-bot: I haz the power, 2017-05-01 16:14:38]

Description was changed from

==========
Override MAXIMIZED window show state if window size / position is manually
specified.

BUG=715729
==========

to

==========
Override MAXIMIZED window show state if window size / position is manually
specified.

BUG=715729

Review-Url: https://codereview.chromium.org/2844843002
Cr-Commit-Position: refs/heads/master@{#468321}
Committed:
https://chromium.googlesource.com/chromium/src/+/7938b191e4a1bae161445ab33dd6...
==========

[commit-bot: I haz the power, 2017-05-01 16:14:39]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/7938b191e4a1bae161445ab33dd6...