Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Issue 2844813002: Revert of [Mojo Video Capture] Adapt video_capture service to refactored video capture stack (Closed)

Created:
3 years, 8 months ago by alph
Modified:
3 years, 8 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, Aaron Boodman, posciak+watch_chromium.org, chfremer+watch_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, feature-media-reviews_chromium.org, xjz+watch_chromium.org, darin (slow to review), miu+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Mojo Video Capture] Adapt video_capture service to refactored video capture stack (patchset #3 id:100001 of https://codereview.chromium.org/2818513003/ ) Reason for revert: FakeVideoCaptureDeviceDescriptorTest.AccessIsRevokedOnSecondAccess test is flaky. https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=service_unittests&tests=FakeVideoCaptureDeviceDescriptorTest.AccessIsRevokedOnSecondAccess Original issue's description: > [Mojo Video Capture] Adapt video_capture service to refactored video capture stack > > This CL is part of the Mojo Video Capture work. For the bigger picture, > see [1] CL22b. > > Note: The video capture service implementation is currently in an incomplete and > outdated state and its tests are disabled. With the refactoring of the legacy > video capture stack now being complete, the next goal is to update the service > implementation and fit it into the refactored stack. > > Changes in this CL: > * Update Mojo interfaces to more closely resemble their native counterparts. > - video_capture.mojom.Device offers functionality similar to > VideoCaptureDeviceLauncher + LaunchedVideoCaptureDevice. > - video_capture.mojom.DeviceFactory offers functionality similar to > media::VideoCaptureProvider. > - video_capture.mojom.Receiver offers functionality similar to > media::VideoFrameReceiver. > * In the service implementation, use a VideoCaptureSystem instead of a > VideoCaptureDeviceFactory directly. > * Add new adapter classes for plumbing between Mojo service and its usage in > the native code. > * Re-enable existing video_capture_unittests and add a few more. > > BUG=584797 > TEST= > service_unittests --gtest_filter="*Video*" > content_unittests --gtest_filter="*Video*" > content_browsertests --gtest_filter="VideoCaptureBrowserTest.*" > > [1] https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxsxWslJ_X-zpOhijvI8/edit?usp=sharing > > Review-Url: https://codereview.chromium.org/2818513003 > Cr-Commit-Position: refs/heads/master@{#467398} > Committed: https://chromium.googlesource.com/chromium/src/+/308b44e5bfb17c42ca3ea5b4fa5ed66c2698107b TBR=mcasas@chromium.org,emircan@chromium.org,miu@chromium.org,ochang@chromium.org,chfremer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=584797 Review-Url: https://codereview.chromium.org/2844813002 Cr-Commit-Position: refs/heads/master@{#467447} Committed: https://chromium.googlesource.com/chromium/src/+/199e9a55bbdfb7015f8c4202af7cae54cca75a62

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -626 lines) Patch
M media/capture/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M media/capture/video/fake_video_capture_device_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D media/capture/video/shared_memory_buffer_handle.h View 1 chunk +0 lines, -37 lines 0 comments Download
D media/capture/video/shared_memory_buffer_handle.cc View 1 chunk +0 lines, -31 lines 0 comments Download
M media/capture/video/shared_memory_buffer_tracker.h View 2 chunks +20 lines, -1 line 0 comments Download
M media/capture/video/shared_memory_buffer_tracker.cc View 3 chunks +19 lines, -3 lines 0 comments Download
M media/capture/video/video_capture_buffer_handle.h View 1 chunk +2 lines, -2 lines 0 comments Download
M services/video_capture/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M services/video_capture/device_factory_media_to_mojo_adapter.h View 3 chunks +12 lines, -7 lines 0 comments Download
M services/video_capture/device_factory_media_to_mojo_adapter.cc View 4 chunks +26 lines, -53 lines 0 comments Download
M services/video_capture/device_media_to_mojo_adapter.h View 1 chunk +0 lines, -6 lines 0 comments Download
M services/video_capture/device_media_to_mojo_adapter.cc View 4 chunks +4 lines, -23 lines 0 comments Download
D services/video_capture/public/cpp/device_to_feedback_observer_adapter.h View 1 chunk +0 lines, -30 lines 0 comments Download
D services/video_capture/public/cpp/device_to_feedback_observer_adapter.cc View 1 chunk +0 lines, -20 lines 0 comments Download
D services/video_capture/public/cpp/receiver_media_to_mojo_adapter.h View 1 chunk +0 lines, -39 lines 0 comments Download
D services/video_capture/public/cpp/receiver_media_to_mojo_adapter.cc View 1 chunk +0 lines, -112 lines 0 comments Download
M services/video_capture/public/interfaces/device.mojom View 1 chunk +0 lines, -2 lines 0 comments Download
M services/video_capture/public/interfaces/receiver.mojom View 1 chunk +2 lines, -10 lines 0 comments Download
M services/video_capture/receiver_mojo_to_media_adapter.h View 1 chunk +1 line, -1 line 0 comments Download
M services/video_capture/receiver_mojo_to_media_adapter.cc View 4 chunks +8 lines, -37 lines 0 comments Download
M services/video_capture/service_impl.cc View 2 chunks +3 lines, -9 lines 0 comments Download
M services/video_capture/test/fake_device_descriptor_unittest.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M services/video_capture/test/fake_device_unittest.cc View 6 chunks +27 lines, -62 lines 0 comments Download
M services/video_capture/test/mock_device_factory.cc View 2 chunks +1 line, -6 lines 0 comments Download
M services/video_capture/test/mock_device_test.h View 2 chunks +1 line, -12 lines 0 comments Download
M services/video_capture/test/mock_device_test.cc View 4 chunks +1 line, -35 lines 0 comments Download
M services/video_capture/test/mock_device_unittest.cc View 3 chunks +22 lines, -43 lines 0 comments Download
M services/video_capture/test/mock_receiver.h View 1 chunk +4 lines, -16 lines 0 comments Download
M services/video_capture/test/mock_receiver.cc View 1 chunk +3 lines, -13 lines 0 comments Download
M services/video_capture/test/service_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
alph
Created Revert of [Mojo Video Capture] Adapt video_capture service to refactored video capture stack
3 years, 8 months ago (2017-04-26 20:47:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2844813002/1
3 years, 8 months ago (2017-04-26 20:48:08 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-26 20:49:21 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/199e9a55bbdfb7015f8c4202af7c...

Powered by Google App Engine
This is Rietveld 408576698