Introduce FragmentData, and put ObjectPaintProperties into it.

Introduce FragmentData, and put ObjectPaintProperties into it

This is a step towards supporting multicol in SPv2.

BUG=648274
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2844803007
Cr-Commit-Position: refs/heads/master@{#468207}
Committed: https://chromium.googlesource.com/chromium/src/+/23f34f4ed43b0e08be9ad4d13cc435f4ee78a813

[chrishtr, 2017-04-28 23:08:56]

Description was changed from

==========
none


none


none

BUG=
==========

to

==========
none


none


none

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[chrishtr, 2017-04-28 23:09:33]

Description was changed from

==========
none


none


none

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Introduce FragmentData, and put ObjectPaintProperties into it

This is a step towards supporting multicol in SPv2.

BUG=648274
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[chrishtr, 2017-04-28 23:09:58]

chrishtr@chromium.org changed reviewers:
+ pdr@chromium.org

[chrishtr, 2017-04-28 23:09:58]

WIP, but close.

[pdr., 2017-04-28 23:13:41]

LGTM

We could do ObjectPaintProperties.h -> ObjectProperties.h in a future patch too.

https://codereview.chromium.org/2844803007/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/paint/README.md (right):

https://codereview.chromium.org/2844803007/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/paint/README.md:212: This class is responsible
for building property trees
Nit: please fix the column wrapping.

https://codereview.chromium.org/2844803007/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/paint/README.md:225: In the absence of
multicolumn/pagination, there is a 1:1 correspondence betwen
between

https://codereview.chromium.org/2844803007/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/paint/README.md:227: may be more fragments. If a
`PaintLayer` has a property node, each of its fragments will have
... may be more `FragmentData`s.

https://codereview.chromium.org/2844803007/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/paint/README.md:229: `PaintLayer` which part of
the same column. For example, if there are 3 columns and both
...which [is] part...

https://codereview.chromium.org/2844803007/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/paint/README.md:230: a parent and child
`PaintLayer` have a transform, there wil be 3 `FragmentData`
will

[chrishtr, 2017-04-28 23:47:04]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2017-04-28 23:47:05]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/2844803007/#ps90001
(title: "none")

[commit-bot: I haz the power, 2017-04-28 23:47:35]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-29 01:35:55]

CQ is committing da patch.

Bot data: {"patchset_id": 90001, "attempt_start_ts": 1493423224997840,
"parent_rev": "276cc56b7c04cc3a28ec6315feb00f056ea8327b", "commit_rev":
"23f34f4ed43b0e08be9ad4d13cc435f4ee78a813"}

[commit-bot: I haz the power, 2017-04-29 01:36:06]

Description was changed from

==========
Introduce FragmentData, and put ObjectPaintProperties into it

This is a step towards supporting multicol in SPv2.

BUG=648274
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Introduce FragmentData, and put ObjectPaintProperties into it

This is a step towards supporting multicol in SPv2.

BUG=648274
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2844803007
Cr-Commit-Position: refs/heads/master@{#468207}
Committed:
https://chromium.googlesource.com/chromium/src/+/23f34f4ed43b0e08be9ad4d13cc4...
==========

[commit-bot: I haz the power, 2017-04-29 01:36:07]

Committed patchset #6 (id:90001) as
https://chromium.googlesource.com/chromium/src/+/23f34f4ed43b0e08be9ad4d13cc4...

[chrishtr, 2017-05-02 00:55:56]

https://codereview.chromium.org/2844803007/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/paint/README.md (right):

https://codereview.chromium.org/2844803007/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/paint/README.md:212: This class is responsible
for building property trees
On 2017/04/28 at 23:13:40, pdr (OOO until May 3rd) wrote:
> Nit: please fix the column wrapping.

Done.

https://codereview.chromium.org/2844803007/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/paint/README.md:225: In the absence of
multicolumn/pagination, there is a 1:1 correspondence betwen
On 2017/04/28 at 23:13:41, pdr (OOO until May 3rd) wrote:
> between

Done

https://codereview.chromium.org/2844803007/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/paint/README.md:227: may be more fragments. If a
`PaintLayer` has a property node, each of its fragments will have
On 2017/04/28 at 23:13:40, pdr (OOO until May 3rd) wrote:
> ... may be more `FragmentData`s.

Done.

https://codereview.chromium.org/2844803007/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/paint/README.md:229: `PaintLayer` which part of
the same column. For example, if there are 3 columns and both
On 2017/04/28 at 23:13:40, pdr (OOO until May 3rd) wrote:
> ...which [is] part...

Done.

https://codereview.chromium.org/2844803007/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/paint/README.md:230: a parent and child
`PaintLayer` have a transform, there wil be 3 `FragmentData`
On 2017/04/28 at 23:13:41, pdr (OOO until May 3rd) wrote:
> will

Done.