|
|
DescriptionAdd a doc in the presubmit script checking if layout tests use eventSender
In https://codereview.chromium.org/2810943005/, we added a presubmit script
to check if eventSender is still used in new layout tests. Here, We add a
doc to explain why we want to replace EventSender and give some examples
on how to use this new API in testing.
BUG=711340
Review-Url: https://codereview.chromium.org/2844803005
Cr-Commit-Position: refs/heads/master@{#468323}
Committed: https://chromium.googlesource.com/chromium/src/+/3e1724e5ccd3d41d417d13487c4b1376a6815a93
Patch Set 1 : comments #
Total comments: 2
Patch Set 2 : comments #Messages
Total messages: 25 (18 generated)
The CQ bit was checked by lanwei@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== comments hover BUG= ========== to ========== Add a doc in the presubmit script checking if layout tests use eventSender In https://codereview.chromium.org/2810943005/, we added a presubmit script to check if eventSender still be used for new layout tests. We add a doc to explain why we want to replace EventSender and give some examples on how to use this new API in testing. BUG=711340 ==========
lanwei@chromium.org changed reviewers: + dtapuska@chromium.org, tdresser@chromium.org
Patchset #1 (id:1) has been deleted
Description was changed from ========== Add a doc in the presubmit script checking if layout tests use eventSender In https://codereview.chromium.org/2810943005/, we added a presubmit script to check if eventSender still be used for new layout tests. We add a doc to explain why we want to replace EventSender and give some examples on how to use this new API in testing. BUG=711340 ========== to ========== Add a doc in the presubmit script checking if layout tests use eventSender In https://codereview.chromium.org/2810943005/, we added a presubmit script to check if eventSender is still used in new layout tests. Here, We add a doc to explain why we want to replace EventSender and give some examples on how to use this new API in testing. BUG=711340 ==========
Description was changed from ========== Add a doc in the presubmit script checking if layout tests use eventSender In https://codereview.chromium.org/2810943005/, we added a presubmit script to check if eventSender is still used in new layout tests. Here, We add a doc to explain why we want to replace EventSender and give some examples on how to use this new API in testing. BUG=711340 ========== to ========== Add a doc in the presubmit script checking if layout tests use eventSender In https://codereview.chromium.org/2810943005/, we added a presubmit script to check if eventSender is still used in new layout tests. Here, We add a doc to explain why we want to replace EventSender and give some examples on how to use this new API in testing. BUG=711340 ==========
Description was changed from ========== Add a doc in the presubmit script checking if layout tests use eventSender In https://codereview.chromium.org/2810943005/, we added a presubmit script to check if eventSender is still used in new layout tests. Here, We add a doc to explain why we want to replace EventSender and give some examples on how to use this new API in testing. BUG=711340 ========== to ========== Add a doc in the presubmit script checking if layout tests use eventSender In https://codereview.chromium.org/2810943005/, we added a presubmit script to check if eventSender is still used in new layout tests. Here, We add a doc to explain why we want to replace EventSender and give some examples on how to use this new API in testing. BUG=711340 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2844803005/diff/20001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/PRESUBMIT.py (right): https://codereview.chromium.org/2844803005/diff/20001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/PRESUBMIT.py:101: 'Files that still use eventSender, please use chrome.gpuBenchmarking.pointerActionSequence instead: ' + Not sure this is a complete sentence anymore. Perhaps "eventSender is deprecated, please use.... ' '(see....' + 'Files: %s:%d....'
LGTM
The CQ bit was checked by lanwei@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #2 (id:40001) has been deleted
https://codereview.chromium.org/2844803005/diff/20001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/PRESUBMIT.py (right): https://codereview.chromium.org/2844803005/diff/20001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/PRESUBMIT.py:101: 'Files that still use eventSender, please use chrome.gpuBenchmarking.pointerActionSequence instead: ' + On 2017/04/28 21:13:17, dtapuska wrote: > Not sure this is a complete sentence anymore. Perhaps > > "eventSender is deprecated, please use.... ' > '(see....' + > 'Files: %s:%d....' Done.
On 2017/05/01 15:53:10, lanwei wrote: > https://codereview.chromium.org/2844803005/diff/20001/third_party/WebKit/Layo... > File third_party/WebKit/LayoutTests/PRESUBMIT.py (right): > > https://codereview.chromium.org/2844803005/diff/20001/third_party/WebKit/Layo... > third_party/WebKit/LayoutTests/PRESUBMIT.py:101: 'Files that still use > eventSender, please use chrome.gpuBenchmarking.pointerActionSequence instead: ' > + > On 2017/04/28 21:13:17, dtapuska wrote: > > Not sure this is a complete sentence anymore. Perhaps > > > > "eventSender is deprecated, please use.... ' > > '(see....' + > > 'Files: %s:%d....' > > Done. lgtm
The CQ bit was unchecked by lanwei@chromium.org
The CQ bit was checked by lanwei@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from tdresser@chromium.org Link to the patchset: https://codereview.chromium.org/2844803005/#ps60001 (title: "comments")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 60001, "attempt_start_ts": 1493655181100710, "parent_rev": "7ad7f6d7a7478d21b30a505dd00e473a609b687d", "commit_rev": "3e1724e5ccd3d41d417d13487c4b1376a6815a93"}
Message was sent while issue was closed.
Description was changed from ========== Add a doc in the presubmit script checking if layout tests use eventSender In https://codereview.chromium.org/2810943005/, we added a presubmit script to check if eventSender is still used in new layout tests. Here, We add a doc to explain why we want to replace EventSender and give some examples on how to use this new API in testing. BUG=711340 ========== to ========== Add a doc in the presubmit script checking if layout tests use eventSender In https://codereview.chromium.org/2810943005/, we added a presubmit script to check if eventSender is still used in new layout tests. Here, We add a doc to explain why we want to replace EventSender and give some examples on how to use this new API in testing. BUG=711340 Review-Url: https://codereview.chromium.org/2844803005 Cr-Commit-Position: refs/heads/master@{#468323} Committed: https://chromium.googlesource.com/chromium/src/+/3e1724e5ccd3d41d417d13487c4b... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:60001) as https://chromium.googlesource.com/chromium/src/+/3e1724e5ccd3d41d417d13487c4b... |