Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2844803005: Add a doc in the presubmit script checking if layout tests use eventSender (Closed)

Created:
3 years, 7 months ago by lanwei
Modified:
3 years, 7 months ago
Reviewers:
dtapuska, tdresser
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a doc in the presubmit script checking if layout tests use eventSender In https://codereview.chromium.org/2810943005/, we added a presubmit script to check if eventSender is still used in new layout tests. Here, We add a doc to explain why we want to replace EventSender and give some examples on how to use this new API in testing. BUG=711340 Review-Url: https://codereview.chromium.org/2844803005 Cr-Commit-Position: refs/heads/master@{#468323} Committed: https://chromium.googlesource.com/chromium/src/+/3e1724e5ccd3d41d417d13487c4b1376a6815a93

Patch Set 1 : comments #

Total comments: 2

Patch Set 2 : comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/PRESUBMIT.py View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 25 (18 generated)
lanwei
3 years, 7 months ago (2017-04-28 19:36:43 UTC) #9
dtapuska
https://codereview.chromium.org/2844803005/diff/20001/third_party/WebKit/LayoutTests/PRESUBMIT.py File third_party/WebKit/LayoutTests/PRESUBMIT.py (right): https://codereview.chromium.org/2844803005/diff/20001/third_party/WebKit/LayoutTests/PRESUBMIT.py#newcode101 third_party/WebKit/LayoutTests/PRESUBMIT.py:101: 'Files that still use eventSender, please use chrome.gpuBenchmarking.pointerActionSequence instead: ...
3 years, 7 months ago (2017-04-28 21:13:17 UTC) #12
tdresser
LGTM
3 years, 7 months ago (2017-05-01 13:20:41 UTC) #13
lanwei
https://codereview.chromium.org/2844803005/diff/20001/third_party/WebKit/LayoutTests/PRESUBMIT.py File third_party/WebKit/LayoutTests/PRESUBMIT.py (right): https://codereview.chromium.org/2844803005/diff/20001/third_party/WebKit/LayoutTests/PRESUBMIT.py#newcode101 third_party/WebKit/LayoutTests/PRESUBMIT.py:101: 'Files that still use eventSender, please use chrome.gpuBenchmarking.pointerActionSequence instead: ...
3 years, 7 months ago (2017-05-01 15:53:10 UTC) #17
dtapuska
On 2017/05/01 15:53:10, lanwei wrote: > https://codereview.chromium.org/2844803005/diff/20001/third_party/WebKit/LayoutTests/PRESUBMIT.py > File third_party/WebKit/LayoutTests/PRESUBMIT.py (right): > > https://codereview.chromium.org/2844803005/diff/20001/third_party/WebKit/LayoutTests/PRESUBMIT.py#newcode101 > ...
3 years, 7 months ago (2017-05-01 15:54:33 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2844803005/60001
3 years, 7 months ago (2017-05-01 16:13:12 UTC) #22
commit-bot: I haz the power
3 years, 7 months ago (2017-05-01 16:24:27 UTC) #25
Message was sent while issue was closed.
Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/3e1724e5ccd3d41d417d13487c4b...

Powered by Google App Engine
This is Rietveld 408576698