Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 2844703002: Roll WebGL 40d75ac..f7157c2 (Closed)

Created:
3 years, 8 months ago by xlai (Olivia)
Modified:
3 years, 7 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll WebGL 40d75ac..f7157c2 https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/40d75ac..f7157c2 BUG=696223, 715696 TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2844703002 Cr-Commit-Position: refs/heads/master@{#467841} Committed: https://chromium.googlesource.com/chromium/src/+/96ce1dbb12faf3c6771ec294f982c42dac090f99

Patch Set 1 #

Patch Set 2 : one less commit #

Patch Set 3 : Add expectations #

Patch Set 4 : remove suppression in expectations #

Patch Set 5 : still need one suprresion #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M content/test/gpu/gpu_tests/webgl2_conformance_expectations.py View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M content/test/gpu/gpu_tests/webgl_conformance_revision.txt View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 35 (28 generated)
xlai (Olivia)
3 years, 8 months ago (2017-04-26 19:00:14 UTC) #11
Ken Russell (switch to Gerrit)
Could we hold off on this for a bit? https://codereview.chromium.org/2837213003 is going to likely fix ...
3 years, 8 months ago (2017-04-26 23:00:59 UTC) #15
Ken Russell (switch to Gerrit)
Could you try this one more time without the expectations updates? These tests should pass ...
3 years, 8 months ago (2017-04-27 00:02:19 UTC) #16
xlai (Olivia)
On 2017/04/27 00:02:19, Ken Russell wrote: > Could you try this one more time without ...
3 years, 7 months ago (2017-04-27 15:58:09 UTC) #23
Ken Russell (switch to Gerrit)
lgtm. I've updated http://crbug.com/715696 . It's a similar bug as before. Clearly something else needs ...
3 years, 7 months ago (2017-04-27 21:09:55 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2844703002/100001
3 years, 7 months ago (2017-04-27 21:14:17 UTC) #32
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 02:14:06 UTC) #35
Message was sent while issue was closed.
Committed patchset #5 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/96ce1dbb12faf3c6771ec294f982...

Powered by Google App Engine
This is Rietveld 408576698