|
|
Created:
3 years, 8 months ago by xlai (Olivia) Modified:
3 years, 7 months ago Reviewers:
Ken Russell (switch to Gerrit) CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionRoll WebGL 40d75ac..f7157c2
https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/40d75ac..f7157c2
BUG=696223, 715696
TEST=bots
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2844703002
Cr-Commit-Position: refs/heads/master@{#467841}
Committed: https://chromium.googlesource.com/chromium/src/+/96ce1dbb12faf3c6771ec294f982c42dac090f99
Patch Set 1 #Patch Set 2 : one less commit #Patch Set 3 : Add expectations #Patch Set 4 : remove suppression in expectations #Patch Set 5 : still need one suprresion #
Messages
Total messages: 35 (28 generated)
The CQ bit was checked by xlai@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_optional_gpu_tests_rel on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_...)
Description was changed from ========== Roll WebGL 40d75ac..7d55f1d https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/40d75a... BUG=696223 TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ========== to ========== Roll WebGL 40d75ac..f7157c2 https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/40d75a... BUG=696223 TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ==========
xlai@chromium.org changed reviewers: + kbr@chromium.org
The CQ bit was checked by xlai@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by xlai@chromium.org
The CQ bit was checked by xlai@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Could we hold off on this for a bit? https://codereview.chromium.org/2837213003 is going to likely fix the failure noted in http://crbug.com/715696 . I'd like to get that landed instead of adding more suppressions for the same underlying bug.
Could you try this one more time without the expectations updates? These tests should pass now that http://crbug.com/713127 is fixed. Thanks.
The CQ bit was checked by xlai@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by xlai@chromium.org
Patchset #5 (id:80001) has been deleted
The CQ bit was checked by xlai@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2017/04/27 00:02:19, Ken Russell wrote: > Could you try this one more time without the expectations updates? These tests > should pass now that http://crbug.com/713127 is fixed. > > Thanks. The multi-context-sampler-test.html does pass now. But the tex-2d-rgb16f-rgb-float.html is still failing. (See the Linux build result of Patch Set 4). So we still need one suppression.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm. I've updated http://crbug.com/715696 . It's a similar bug as before. Clearly something else needs to be virtualized properly.
The CQ bit was checked by xlai@chromium.org
The CQ bit was unchecked by xlai@chromium.org
The CQ bit was unchecked by kbr@chromium.org
Description was changed from ========== Roll WebGL 40d75ac..f7157c2 https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/40d75a... BUG=696223 TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ========== to ========== Roll WebGL 40d75ac..f7157c2 https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/40d75a... BUG=696223,715696 TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ==========
The CQ bit was checked by xlai@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 100001, "attempt_start_ts": 1493327629463520, "parent_rev": "eab6fcca575e4781af96c9f1b81265e05f370744", "commit_rev": "96ce1dbb12faf3c6771ec294f982c42dac090f99"}
Message was sent while issue was closed.
Description was changed from ========== Roll WebGL 40d75ac..f7157c2 https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/40d75a... BUG=696223,715696 TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ========== to ========== Roll WebGL 40d75ac..f7157c2 https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/40d75a... BUG=696223,715696 TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2844703002 Cr-Commit-Position: refs/heads/master@{#467841} Committed: https://chromium.googlesource.com/chromium/src/+/96ce1dbb12faf3c6771ec294f982... ==========
Message was sent while issue was closed.
Committed patchset #5 (id:100001) as https://chromium.googlesource.com/chromium/src/+/96ce1dbb12faf3c6771ec294f982... |