PaymentHandler: Implement PaymentInstruments.has().

PaymentHandler: Implement PaymentInstruments.has().

The method to check whether the payment instrument for the specified key is
stored.

Related Spec Link:
  https://w3c.github.io/webpayments-payment-handler/#paymentinstruments-interface

BUG=661608
TEST=payment_manager_unittest.cc, payment-instruments.html

Review-Url: https://codereview.chromium.org/2844673002
Cr-Commit-Position: refs/heads/master@{#467701}
Committed: https://chromium.googlesource.com/chromium/src/+/8f5656549a8eb15b9566d42b3d9abc6e4d422f77

[zino, 2017-04-26 15:01:16]

Description was changed from

==========
PaymentHandler: Implement PaymentInstruments.has().

The method to check whether the payment instrument for the specified key is
stored.

Related Spec Link:
 
https://w3c.github.io/webpayments-payment-handler/#paymentinstruments-interface

BUG=661608
TEST=payment_manager_unittest.cc, payment-instruments.html
==========

to

==========
PaymentHandler: Implement PaymentInstruments.has().

The method to check whether the payment instrument for the specified key is
stored.

Related Spec Link:
 
https://w3c.github.io/webpayments-payment-handler/#paymentinstruments-interface

BUG=661608
TEST=payment_manager_unittest.cc, payment-instruments.html
==========

[zino, 2017-04-26 15:01:16]

jinho.bang@samsung.com changed reviewers:
+ rouslan@chromium.org, tsepez@chromium.org

[zino, 2017-04-26 15:01:25]

PTAL

[please use gerrit instead, 2017-04-26 15:18:26]

lgtm % comment

https://codereview.chromium.org/2844673002/diff/1/content/browser/payments/pa...
File content/browser/payments/payment_manager_unittest.cc (right):

https://codereview.chromium.org/2844673002/diff/1/content/browser/payments/pa...
content/browser/payments/payment_manager_unittest.cc:244:
ASSERT_EQ(PaymentHandlerStatus::NOT_FOUND, write_status);
Here and everywhere: There's no need to ASSERT_EQ(success, status) immediately
after "status = success" statement.

[Tom Sepez, 2017-04-26 16:20:16]

https://codereview.chromium.org/2844673002/diff/1/components/payments/mojom/p...
File components/payments/mojom/payment_app.mojom (right):

https://codereview.chromium.org/2844673002/diff/1/components/payments/mojom/p...
components/payments/mojom/payment_app.mojom:55: HasPaymentInstrument(string
instrument_key)
Isn't this a subset of the functionality of Get()?  Do you need to do this
rather than just a get discarding the |instrument| result?

[zino, 2017-04-26 17:35:21]

Thank you for review.

https://codereview.chromium.org/2844673002/diff/1/components/payments/mojom/p...
File components/payments/mojom/payment_app.mojom (right):

https://codereview.chromium.org/2844673002/diff/1/components/payments/mojom/p...
components/payments/mojom/payment_app.mojom:55: HasPaymentInstrument(string
instrument_key)
On 2017/04/26 16:20:15, Tom Sepez wrote:
> Isn't this a subset of the functionality of Get()?  Do you need to do this
> rather than just a get discarding the |instrument| result?

The function is defined in the spec. (It's a map-like interface)
Anyway, we will able to share the get() implementation and then provide
different functions in only blink side.

But I'm not sure what is advantage. If we use get() implementation, then we will
have to read and deserialize stored data unnecessarily whenever just calling
has() method.

[Tom Sepez, 2017-04-26 17:48:51]

lgtm

[zino, 2017-04-27 14:17:17]

The CQ bit was checked by jinho.bang@samsung.com

[zino, 2017-04-27 14:17:17]

The patchset sent to the CQ was uploaded after l-g-t-m from rouslan@chromium.org
Link to the patchset: https://codereview.chromium.org/2844673002/#ps20001
(title: "PaymentHandler: Implement PaymentInstruments.has().")

[commit-bot: I haz the power, 2017-04-27 14:17:54]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 16:15:23]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493302637192300,
"parent_rev": "5d1496cb9aab8adfd300df7c8dfe1e059100048a", "commit_rev":
"8f5656549a8eb15b9566d42b3d9abc6e4d422f77"}

[commit-bot: I haz the power, 2017-04-27 16:17:04]

Description was changed from

==========
PaymentHandler: Implement PaymentInstruments.has().

The method to check whether the payment instrument for the specified key is
stored.

Related Spec Link:
 
https://w3c.github.io/webpayments-payment-handler/#paymentinstruments-interface

BUG=661608
TEST=payment_manager_unittest.cc, payment-instruments.html
==========

to

==========
PaymentHandler: Implement PaymentInstruments.has().

The method to check whether the payment instrument for the specified key is
stored.

Related Spec Link:
 
https://w3c.github.io/webpayments-payment-handler/#paymentinstruments-interface

BUG=661608
TEST=payment_manager_unittest.cc, payment-instruments.html

Review-Url: https://codereview.chromium.org/2844673002
Cr-Commit-Position: refs/heads/master@{#467701}
Committed:
https://chromium.googlesource.com/chromium/src/+/8f5656549a8eb15b9566d42b3d9a...
==========

[commit-bot: I haz the power, 2017-04-27 16:17:06]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8f5656549a8eb15b9566d42b3d9a...