Chromium Code Reviews Chromium Code Reviews
Issue 2844593002:
Protect against lifecycle updates that delete a layout object for autoscroll (Closed)
| Index: third_party/WebKit/LayoutTests/fast/events/autoscroll-select-crash.html |
| diff --git a/third_party/WebKit/LayoutTests/fast/events/autoscroll-select-crash.html b/third_party/WebKit/LayoutTests/fast/events/autoscroll-select-crash.html |
| new file mode 100644 |
| index 0000000000000000000000000000000000000000..fae42d4dfe03adb1f59ae2aa93ec7f055f44724e |
| --- /dev/null |
| +++ b/third_party/WebKit/LayoutTests/fast/events/autoscroll-select-crash.html |
| @@ -0,0 +1,38 @@ |
| +<!DOCTYPE html> |
| +Test passes if it does not crash.<br> |
|
mstensho (USE GERRIT)
2017/04/27 20:16:11
I can't get it to crash (without the patch).
Also
chrishtr
2017/04/28 02:21:34
Fixed - the uploaded version has a one-character t
mstensho (USE GERRIT)
2017/04/28 07:46:48
Take a look at e.g. LayoutTests/fast/events/focus-
|
| +<iframe id=iframe srcdoc=" |
| +<style> |
| +.c:hover { display: block; } |
| +.c { content: attr(class); width: 400px; height: 400px; } |
| +</style<meta http-equiv=refresh content=1 /> |
| +<body id=body> |
| + <select id=target autofocus=autofocus size=2 class=c></select> |
| +</body>"></iframe> |
| +<script> |
| +if (window.testRunner) { |
| + window.testRunner.waitUntilDone(); |
| + window.testRunner.dumpAsText(); |
| +} |
| +function callback() {} |
| +function go() { |
| + if (chrome.gpuBenchmarking) { |
| + var pointerActions = |
| + [{source: "mouse", |
| + actions: [{name: "pointerMove", x: 200, y: 50 }, |
| + { name: "pointerDown", x: 200, y: 50 }] |
| + }]; |
| + chrome.gpuBenchmarking.pointerActionSequence(pointerActions, callback); |
| + setTimeout(function() { |
| + pointerActions = |
| + [{source: "mouse", |
| + actions: [{ name: "pointerMove", x: 200, y: 51 }, |
| + { name: "pointerUp", x: 200, y: 51 }] |
| + }]; |
| + chrome.gpuBenchmarking.pointerActionSequence(pointerActions, callback); |
| + if (testRunner) |
| + testRunner.notifyDone(); |
| + }, 1000); |
|
mstensho (USE GERRIT)
2017/04/27 20:16:11
1000ms is quite a lot. Is it really necessary?
chrishtr
2017/04/28 02:21:34
Found a way to reduce to 50ms.
mstensho (USE GERRIT)
2017/04/28 07:46:48
W00t!! :)
|
| + } |
| +} |
| +onload = setTimeout(go, 0); |
| +</script> |
