third_party/WebKit/LayoutTests/fast/events/autoscroll-select-crash.html - Issue 2844593002: Protect against lifecycle updates that delete a layout object for autoscroll

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/events/autoscroll-select-crash.html

Issue 2844593002: Protect against lifecycle updates that delete a layout object for autoscroll (Closed)

Patch Set: none Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/events/autoscroll-select-crash-expected.txt » ('j') | third_party/WebKit/Source/core/input/MouseEventManager.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 Test passes if it does not crash.<br>
	mstensho (USE GERRIT) 2017/04/27 20:16:11 I can't get it to crash (without the patch). Also I can't get it to crash (without the patch). Also, it should be converted to a testharness test, so that you don't need the -expected.txt counterpart. chrishtr 2017/04/28 02:21:34 Fixed - the uploaded version has a one-character t Show quoted text On 2017/04/27 at 20:16:11, mstensho wrote: > I can't get it to crash (without the patch). Fixed - the uploaded version has a one-character typo (missing > after style) Show quoted text > > Also, it should be converted to a testharness test, so that you don't need the -expected.txt counterpart. How exactly do I do that? including testharness doesn't omit the expected file, is there a method I should run? mstensho (USE GERRIT) 2017/04/28 07:46:48 Take a look at e.g. LayoutTests/fast/events/focus- Show quoted text On 2017/04/28 02:21:34, chrishtr wrote: > On 2017/04/27 at 20:16:11, mstensho wrote: > > Also, it should be converted to a testharness test, so that you don't need the > -expected.txt counterpart. > > How exactly do I do that? including testharness doesn't omit the expected file, > is there a method > I should run? Take a look at e.g. LayoutTests/fast/events/focus-iframe-crash.html
	3 <iframe id=iframe srcdoc="

	4 <style>

	5 .c:hover { display: block; }

	6 .c { content: attr(class); width: 400px; height: 400px; }

	7 </style<meta http-equiv=refresh content=1 />

	8 <body id=body>

	9 <select id=target autofocus=autofocus size=2 class=c></select>

	10 </body>"></iframe>

	11 <script>

	12 if (window.testRunner) {

	13 window.testRunner.waitUntilDone();

	14 window.testRunner.dumpAsText();

	15 }

	16 function callback() {}

	17 function go() {

	18 if (chrome.gpuBenchmarking) {

	19 var pointerActions =

	20 [{source: "mouse",

	21 actions: [{name: "pointerMove", x: 200, y: 50 },

	22 { name: "pointerDown", x: 200, y: 50 }]

	23 }];

	24 chrome.gpuBenchmarking.pointerActionSequence(pointerActions, callback);

	25 setTimeout(function() {

	26 pointerActions =

	27 [{source: "mouse",

	28 actions: [{ name: "pointerMove", x: 200, y: 51 },

	29 { name: "pointerUp", x: 200, y: 51 }]

	30 }];

	31 chrome.gpuBenchmarking.pointerActionSequence(pointerActions, callbac k);

	32 if (testRunner)

	33 testRunner.notifyDone();

	34 }, 1000);
	mstensho (USE GERRIT) 2017/04/27 20:16:11 1000ms is quite a lot. Is it really necessary? 1000ms is quite a lot. Is it really necessary? chrishtr 2017/04/28 02:21:34 Found a way to reduce to 50ms. Show quoted text On 2017/04/27 at 20:16:11, mstensho wrote: > 1000ms is quite a lot. Is it really necessary? Found a way to reduce to 50ms. mstensho (USE GERRIT) 2017/04/28 07:46:48 W00t!! :) Show quoted text On 2017/04/28 02:21:34, chrishtr wrote: > On 2017/04/27 at 20:16:11, mstensho wrote: > > 1000ms is quite a lot. Is it really necessary? > > Found a way to reduce to 50ms. W00t!! :)
	35 }

	36 }

	37 onload = setTimeout(go, 0);

	38 </script>

OLD	NEW