Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 2844583004: WTF::HashTraits: Remove unnecessary Peek() functions. (Closed)

Created:
3 years, 8 months ago by Yuta Kitamura
Modified:
3 years, 7 months ago
Reviewers:
tzik
CC:
chromium-reviews, blink-reviews, kinuko+watch
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

WTF::HashTraits: Remove unnecessary Peek() functions. Peek() always takes a reference to an existing slot in a table. Therefore, Peek() does not take a nullptr_t value, since nullptr_t is not stored in the backing buffer. BUG=715430 R=tzik@chromium.org Review-Url: https://codereview.chromium.org/2844583004 Cr-Commit-Position: refs/heads/master@{#467920} Committed: https://chromium.googlesource.com/chromium/src/+/d9e025eb1e744fb28cf8354d8ac42c572215183c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M third_party/WebKit/Source/platform/wtf/HashTraits.h View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Yuta Kitamura
tzik: PTAL?
3 years, 8 months ago (2017-04-26 11:17:01 UTC) #4
tzik
lgtm
3 years, 7 months ago (2017-04-28 03:39:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2844583004/1
3 years, 7 months ago (2017-04-28 05:00:47 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 06:57:01 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d9e025eb1e744fb28cf8354d8ac4...

Powered by Google App Engine
This is Rietveld 408576698