Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Unified Diff: third_party/WebKit/Source/core/dom/ClassicPendingScript.cpp

Issue 2844583002: 4. Do not call Dispose() as ClassicPendingScript's prefinalizer (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/ClassicPendingScript.cpp
diff --git a/third_party/WebKit/Source/core/dom/ClassicPendingScript.cpp b/third_party/WebKit/Source/core/dom/ClassicPendingScript.cpp
index e1c747e4e89d3a3c93f5b5fbca2ec03ba70c4d6c..4ab6c71f21acde2a6f8127d44d7721042da053c8 100644
--- a/third_party/WebKit/Source/core/dom/ClassicPendingScript.cpp
+++ b/third_party/WebKit/Source/core/dom/ClassicPendingScript.cpp
@@ -47,8 +47,11 @@ NOINLINE void ClassicPendingScript::CheckState() const {
CHECK(!streamer_ || streamer_->GetResource() == GetResource());
}
-NOINLINE void ClassicPendingScript::Dispose() {
- PendingScript::Dispose();
+void ClassicPendingScript::Prefinalize() {
+ // TODO(hiroshige): Consider moving this to ScriptStreamer's prefinalizer.
kouhei (in TOK) 2017/04/26 00:22:52 Maybe dtor is enough.
haraken 2017/04/26 01:06:23 Agreed.
+ // https://crbug.com/715309
+ if (streamer_)
+ streamer_->Cancel();
prefinalizer_called_ = true;
}

Powered by Google App Engine
This is Rietveld 408576698