4. Do not call Dispose() as ClassicPendingScript's prefinalizer

third_party/WebKit/Source/core/dom/ClassicPendingScript.cpp

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/dom/ClassicPendingScript.h"
 
 #include "bindings/core/v8/ScriptSourceCode.h"
 #include "bindings/core/v8/ScriptState.h"
 #include "bindings/core/v8/ScriptStreamer.h"
 #include "bindings/core/v8/V8BindingForCore.h"
@@ skipping 29 matching lines @@
 ClassicPendingScript::~ClassicPendingScript() {}
 
 NOINLINE void ClassicPendingScript::CheckState() const {
   // TODO(hiroshige): Turn these CHECK()s into DCHECK() before going to beta.
   CHECK(!prefinalizer_called_);
   CHECK(GetElement());
   CHECK(GetResource() || !streamer_);
   CHECK(!streamer_ || streamer_->GetResource() == GetResource());
 }
 
-NOINLINE void ClassicPendingScript::Dispose() {
-  PendingScript::Dispose();
+void ClassicPendingScript::Prefinalize() {
+  // TODO(hiroshige): Consider moving this to ScriptStreamer's prefinalizer.

[kouhei (in TOK), 2017/04/26 00:22:52]

Maybe dtor is enough.

[haraken, 2017/04/26 01:06:23]

Agreed.

+  // https://crbug.com/715309
+  if (streamer_)
+    streamer_->Cancel();
   prefinalizer_called_ = true;
 }
 
 void ClassicPendingScript::DisposeInternal() {
   MemoryCoordinator::Instance().UnregisterClient(this);
   SetResource(nullptr);
   integrity_failure_ = false;
   if (streamer_)
     streamer_->Cancel();
   streamer_ = nullptr;
@@ skipping 168 matching lines @@
 
 KURL ClassicPendingScript::UrlForClassicScript() const {
   return GetResource()->Url();
 }
 
 void ClassicPendingScript::RemoveFromMemoryCache() {
   GetMemoryCache()->Remove(GetResource());
 }
 
 }  // namespace blink