Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1098)

Issue 2844563003: chromeos: Remove wm_shelf_util.h (Closed)

Created:
3 years, 8 months ago by James Cook
Modified:
3 years, 8 months ago
Reviewers:
msw
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

chromeos: Remove wm_shelf_util.h Eliminate the one remaining caller of ash::IsHorizontalAlignment(). Everything uses WmShelf::IsHorizontalAlignment() now. Just cleanup, no behavior changes. BUG=635963 TEST=ash_unittests, manually test panels and shelf alignment Review-Url: https://codereview.chromium.org/2844563003 Cr-Commit-Position: refs/heads/master@{#467183} Committed: https://chromium.googlesource.com/chromium/src/+/7924a4308a1956e0c4b065c483de4da44cb6c383

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -52 lines) Patch
M ash/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M ash/shelf/shelf_widget.cc View 1 chunk +0 lines, -1 line 0 comments Download
D ash/shelf/wm_shelf_util.h View 1 chunk +0 lines, -19 lines 0 comments Download
D ash/shelf/wm_shelf_util.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M ash/system/ime_menu/ime_menu_tray.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/system/network/tray_network.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/system/palette/palette_tray.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/system/tray/system_tray.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/system/tray/tray_image_item.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/system/web_notification/web_notification_tray.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/panels/panel_layout_manager.cc View 7 chunks +9 lines, -10 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
James Cook
msw, please take a look.
3 years, 8 months ago (2017-04-25 23:23:44 UTC) #3
msw
Nice; lgtm!
3 years, 8 months ago (2017-04-25 23:27:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2844563003/20001
3 years, 8 months ago (2017-04-25 23:34:09 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-26 00:52:29 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7924a4308a1956e0c4b065c483de...

Powered by Google App Engine
This is Rietveld 408576698