Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Issue 2844553003: MD-Settings - Update dialog for federated text in passwords dialog. (Closed)

Created:
3 years, 8 months ago by hcarmona
Modified:
3 years, 8 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, vabr+watchlistpasswordmanager_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, gcasto+watchlist_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD-Settings - Update dialog for federated text in passwords dialog. Screenshot in bug. R=dbeam@chromium.org BUG=706310 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2844553003 Cr-Commit-Position: refs/heads/master@{#467452} Committed: https://chromium.googlesource.com/chromium/src/+/4c51a9e3549b99eaf922bf15dd1e9c2fb1d6da8a

Patch Set 1 #

Patch Set 2 : git cl format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -12 lines) Patch
M chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.js View 1 2 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
hcarmona
PTAL
3 years, 8 months ago (2017-04-26 19:00:05 UTC) #5
Dan Beam
can we add tests in a followup? lgtm
3 years, 8 months ago (2017-04-26 20:42:52 UTC) #9
hcarmona
On 2017/04/26 20:42:52, Dan Beam wrote: > can we add tests in a followup? lgtm ...
3 years, 8 months ago (2017-04-26 20:54:12 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2844553003/20001
3 years, 8 months ago (2017-04-26 20:54:59 UTC) #12
commit-bot: I haz the power
3 years, 8 months ago (2017-04-26 21:01:01 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4c51a9e3549b99eaf922bf15dd1e...

Powered by Google App Engine
This is Rietveld 408576698