Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Unified Diff: cc/output/overlay_processor.cc

Issue 2844483004: Reset the state of the previous frame if overlay processing is skipped. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/output/overlay_processor.cc
diff --git a/cc/output/overlay_processor.cc b/cc/output/overlay_processor.cc
index 73e0a59a9b88dca34157e8f3e96ed3b99baca49d..f1a40c79704f5bb622fe37b482e8f9673266d5bb 100644
--- a/cc/output/overlay_processor.cc
+++ b/cc/output/overlay_processor.cc
@@ -143,12 +143,14 @@ void OverlayProcessor::ProcessForOverlays(
if (ProcessForCALayers(resource_provider, render_pass, render_pass_filters,
render_pass_background_filters, candidates,
ca_layer_overlays, damage_rect)) {
+ previous_frame_underlay_rect_ = gfx::Rect();
liberato (no reviews please) 2017/04/26 18:40:31 clearing it seems to be the default (and safe) act
watk 2017/04/26 19:20:04 +1
AndyWu 2017/04/26 20:40:53 Done, thanks for your suggestion.
return;
}
if (ProcessForDCLayers(resource_provider, render_pass, render_pass_filters,
render_pass_background_filters, candidates,
dc_layer_overlays, damage_rect)) {
+ previous_frame_underlay_rect_ = gfx::Rect();
return;
}
@@ -161,6 +163,8 @@ void OverlayProcessor::ProcessForOverlays(
UpdateDamageRect(candidates, damage_rect);
return;
}
+
+ previous_frame_underlay_rect_ = gfx::Rect();
}
// Subtract on-top overlays from the damage rect, unless the overlays use
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698