Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 2844483002: [Web Payments] Fix some ScrollView issues in the dialog. (Closed)

Created:
3 years, 7 months ago by anthonyvd
Modified:
3 years, 7 months ago
Reviewers:
Mathieu
CC:
chromium-reviews, tfarina
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Web Payments] Fix some ScrollView issues in the dialog. BUG=704254 Review-Url: https://codereview.chromium.org/2844483002 Cr-Commit-Position: refs/heads/master@{#467066} Committed: https://chromium.googlesource.com/chromium/src/+/81f1ef0b451bba880803d6c230a1fe384c1be9f3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -6 lines) Patch
M chrome/browser/ui/views/payments/payment_request_sheet_controller.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/payments/payment_request_sheet_controller.cc View 2 chunks +9 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
anthonyvd
Hi Math, PTAL!
3 years, 7 months ago (2017-04-25 17:42:32 UTC) #6
Mathieu
lgtm
3 years, 7 months ago (2017-04-25 17:49:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2844483002/1
3 years, 7 months ago (2017-04-25 18:55:37 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-04-25 19:05:17 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/81f1ef0b451bba880803d6c230a1...

Powered by Google App Engine
This is Rietveld 408576698