Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Unified Diff: ios/chrome/browser/ui/settings/autofill_credit_card_edit_collection_view_controller.mm

Issue 2844463004: Rename card 'type' into 'issuer network.' (Closed)
Patch Set: read -> use Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/settings/autofill_credit_card_edit_collection_view_controller.mm
diff --git a/ios/chrome/browser/ui/settings/autofill_credit_card_edit_collection_view_controller.mm b/ios/chrome/browser/ui/settings/autofill_credit_card_edit_collection_view_controller.mm
index ce984d06bb2498b5b961b7d6660f9d53dddb8501..0c2e6a5ca37dcc3c721b5625b0cd40f2cbcafd6b 100644
--- a/ios/chrome/browser/ui/settings/autofill_credit_card_edit_collection_view_controller.mm
+++ b/ios/chrome/browser/ui/settings/autofill_credit_card_edit_collection_view_controller.mm
@@ -43,7 +43,7 @@ using ::AutofillTypeFromAutofillUIType;
NSString* const kAutofillCreditCardEditCollectionViewId =
@"kAutofillCreditCardEditCollectionViewId";
-const CGFloat kCardTypeIconDimension = 30.0;
+const CGFloat kCardIssuerNetworkIconDimension = 30.0;
typedef NS_ENUM(NSInteger, SectionIdentifier) {
SectionIdentifierFields = kSectionIdentifierEnumZero,
@@ -318,13 +318,13 @@ typedef NS_ENUM(NSInteger, ItemType) {
#pragma mark - Helper Methods
- (UIImage*)cardTypeIconFromCardNumber:(NSString*)cardNumber {
- const char* cardType = autofill::CreditCard::GetCreditCardType(
+ const char* network = autofill::CreditCard::GetCardNetwork(
base::SysNSStringToUTF16(cardNumber));
- if (cardType != autofill::kGenericCard) {
+ if (network != autofill::kGenericCard) {
int resourceID =
- autofill::data_util::GetPaymentRequestData(cardType).icon_resource_id;
- // Resize and set the card type icon.
- CGFloat dimension = kCardTypeIconDimension;
+ autofill::data_util::GetPaymentRequestData(network).icon_resource_id;
+ // Resize and set the card issuer network icon.
+ CGFloat dimension = kCardIssuerNetworkIconDimension;
return ResizeImage(NativeImage(resourceID),
CGSizeMake(dimension, dimension),
ProjectionMode::kAspectFillNoClipping);

Powered by Google App Engine
This is Rietveld 408576698