Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1031)

Unified Diff: components/autofill/core/browser/webdata/autofill_table.h

Issue 2844463004: Rename card 'type' into 'issuer network.' (Closed)
Patch Set: read -> use Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/webdata/autofill_table.h
diff --git a/components/autofill/core/browser/webdata/autofill_table.h b/components/autofill/core/browser/webdata/autofill_table.h
index 97b8bc8f9398c4dec1b5f1a4ddd4d4d3736dcf38..161b033fe694a8d366fcf7db3e0ef322cf4b7cb1 100644
--- a/components/autofill/core/browser/webdata/autofill_table.h
+++ b/components/autofill/core/browser/webdata/autofill_table.h
@@ -160,8 +160,8 @@ struct FormFieldData;
// status Server's status of this card.
// TODO(brettw) define constants for this.
// name_on_card
-// type Type of the credit card. This is one of the
-// kSyncCardType* strings.
+// network Issuer network of the card. For example, "VISA". Renamed
+// from "type" in version 72.
// last_four Last four digits of the card number. For de-duping
// with locally stored cards and generating descriptions.
// exp_month Expiration month: 1-12
@@ -331,7 +331,7 @@ class AutofillTable : public WebDatabaseTable,
// Records a single Autofill profile in the autofill_profiles table.
virtual bool AddAutofillProfile(const AutofillProfile& profile);
- // Updates the database values for the specified profile. Mulit-value aware.
+ // Updates the database values for the specified profile. Multi-value aware.
virtual bool UpdateAutofillProfile(const AutofillProfile& profile);
// Removes a row from the autofill_profiles table. |guid| is the identifier
@@ -463,6 +463,7 @@ class AutofillTable : public WebDatabaseTable,
bool MigrateToVersion67AddMaskedCardBillingAddress();
bool MigrateToVersion70AddSyncMetadata();
bool MigrateToVersion71AddHasConvertedAndBillingAddressIdMetadata();
+ bool MigrateToVersion72RenameCardTypeToIssuerNetwork();
// Max data length saved in the table, AKA the maximum length allowed for
// form data.
« no previous file with comments | « components/autofill/core/browser/validation.cc ('k') | components/autofill/core/browser/webdata/autofill_table.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698