OLD | NEW |
---|---|
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. | 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. |
2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
4 | 4 |
5 #ifndef COMPONENTS_WEBDATA_COMMON_WEB_DATABASE_TABLE_H_ | 5 #ifndef COMPONENTS_WEBDATA_COMMON_WEB_DATABASE_TABLE_H_ |
6 #define COMPONENTS_WEBDATA_COMMON_WEB_DATABASE_TABLE_H_ | 6 #define COMPONENTS_WEBDATA_COMMON_WEB_DATABASE_TABLE_H_ |
7 | 7 |
8 #include "base/logging.h" | 8 #include "base/logging.h" |
9 #include "base/macros.h" | 9 #include "base/macros.h" |
10 #include "components/webdata/common/webdata_export.h" | 10 #include "components/webdata/common/webdata_export.h" |
(...skipping 29 matching lines...) Expand all Loading... | |
40 // In order to encourage developers to think about sync when adding or | 40 // In order to encourage developers to think about sync when adding or |
41 // or altering new tables, this method must be implemented. Please get in | 41 // or altering new tables, this method must be implemented. Please get in |
42 // contact with the sync team if you believe you're making a change that they | 42 // contact with the sync team if you believe you're making a change that they |
43 // should be aware of (or if you could break something). | 43 // should be aware of (or if you could break something). |
44 // TODO(andybons): Implement something more robust. | 44 // TODO(andybons): Implement something more robust. |
45 virtual bool IsSyncable() = 0; | 45 virtual bool IsSyncable() = 0; |
46 | 46 |
47 // Migrates this table to |version|. Returns false if there was | 47 // Migrates this table to |version|. Returns false if there was |
48 // migration work to do and it failed, true otherwise. | 48 // migration work to do and it failed, true otherwise. |
49 // | 49 // |
50 // Implementations may set |*update_compatible_version| to true if | 50 // Implementations may set |*update_compatible_version| to true if the |
51 // the compatible version should be changed to |version|. | 51 // compatible version should be changed to |version|, i.e., if the change will |
52 // break previous versions when they try to read the updated database. | |
Peter Kasting
2017/04/26 18:35:53
Nit: read -> use
(E.g. they might be able to read
please use gerrit instead
2017/04/26 18:37:16
Done.
| |
52 // Implementations should otherwise not modify this parameter. | 53 // Implementations should otherwise not modify this parameter. |
53 virtual bool MigrateToVersion(int version, | 54 virtual bool MigrateToVersion(int version, |
54 bool* update_compatible_version) = 0; | 55 bool* update_compatible_version) = 0; |
55 | 56 |
56 protected: | 57 protected: |
57 // Non-owning. These are owned by WebDatabase, valid as long as that | 58 // Non-owning. These are owned by WebDatabase, valid as long as that |
58 // class exists. Since lifetime of WebDatabaseTable objects slightly | 59 // class exists. Since lifetime of WebDatabaseTable objects slightly |
59 // exceeds that of WebDatabase, they should not be used in | 60 // exceeds that of WebDatabase, they should not be used in |
60 // ~WebDatabaseTable. | 61 // ~WebDatabaseTable. |
61 sql::Connection* db_; | 62 sql::Connection* db_; |
62 sql::MetaTable* meta_table_; | 63 sql::MetaTable* meta_table_; |
63 | 64 |
64 private: | 65 private: |
65 DISALLOW_COPY_AND_ASSIGN(WebDatabaseTable); | 66 DISALLOW_COPY_AND_ASSIGN(WebDatabaseTable); |
66 }; | 67 }; |
67 | 68 |
68 #endif // COMPONENTS_WEBDATA_COMMON_WEB_DATABASE_TABLE_H_ | 69 #endif // COMPONENTS_WEBDATA_COMMON_WEB_DATABASE_TABLE_H_ |
OLD | NEW |