Rename card 'type' into 'issuer network.'

components/autofill/core/browser/personal_data_manager_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/browser/personal_data_manager.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 #include <list>
@@ skipping 36 matching lines @@
 #include "components/signin/core/browser/account_tracker_service.h"
 #include "components/signin/core/browser/fake_signin_manager.h"
 #include "components/signin/core/browser/test_signin_client.h"
 #include "components/signin/core/common/signin_pref_names.h"
 #include "components/variations/variations_params_manager.h"
 #include "components/webdata/common/web_data_service_base.h"
 #include "components/webdata/common/web_database_service.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
-using base::ASCIIToUTF16;
-using base::UTF8ToUTF16;
-
 namespace autofill {
 namespace {
 
+using ::base::ASCIIToUTF16;
+using ::base::UTF8ToUTF16;
+
 enum UserMode { USER_MODE_NORMAL, USER_MODE_INCOGNITO };
 
-const std::string kUTF8MidlineEllipsis =
+const char kUTF8MidlineEllipsis[] =
     "  "
     "\xE2\x80\xA2\xE2\x80\x86"
     "\xE2\x80\xA2\xE2\x80\x86"
     "\xE2\x80\xA2\xE2\x80\x86"
     "\xE2\x80\xA2\xE2\x80\x86";
 
 const base::Time kArbitraryTime = base::Time::FromDoubleT(25);
 const base::Time kSomeLaterTime = base::Time::FromDoubleT(1000);
 const base::Time kMuchLaterTime = base::Time::FromDoubleT(5000);
 
@@ skipping 681 matching lines @@
 }
 
 // Tests that UpdateServerCreditCard can be used to mask or unmask server cards.
 TEST_F(PersonalDataManagerTest, UpdateServerCreditCards) {
   EnableWalletCardImport();
 
   std::vector<CreditCard> server_cards;
   server_cards.push_back(CreditCard(CreditCard::MASKED_SERVER_CARD, "a123"));
   test::SetCreditCardInfo(&server_cards.back(), "John Dillinger",
                           "9012" /* Visa */, "01", "2999");
-  server_cards.back().SetTypeForMaskedCard(kVisaCard);
+  server_cards.back().SetNetworkForMaskedCard(kVisaCard);
 
   server_cards.push_back(CreditCard(CreditCard::MASKED_SERVER_CARD, "b456"));
   test::SetCreditCardInfo(&server_cards.back(), "Bonnie Parker",
                           "2109" /* Mastercard */, "12", "2999");
-  server_cards.back().SetTypeForMaskedCard(kMasterCard);
+  server_cards.back().SetNetworkForMaskedCard(kMasterCard);
 
   server_cards.push_back(CreditCard(CreditCard::FULL_SERVER_CARD, "c789"));
   test::SetCreditCardInfo(&server_cards.back(), "Clyde Barrow",
                           "347666888555" /* American Express */, "04", "2999");
 
   test::SetServerCreditCards(autofill_table_, server_cards);
   personal_data_->Refresh();
 
   EXPECT_CALL(personal_data_observer_, OnPersonalDataChanged())
       .WillOnce(QuitMainMessageLoop());
@@ skipping 1627 matching lines @@
 
 // Tests that a credit card is extracted because it only matches a masked server
 // card.
 TEST_F(PersonalDataManagerTest,
        ImportCreditCard_DuplicateServerCards_MaskedCard) {
   // Add a masked server card.
   std::vector<CreditCard> server_cards;
   server_cards.push_back(CreditCard(CreditCard::MASKED_SERVER_CARD, "a123"));
   test::SetCreditCardInfo(&server_cards.back(), "John Dillinger",
                           "1111" /* Visa */, "01", "2999");
-  server_cards.back().SetTypeForMaskedCard(kVisaCard);
+  server_cards.back().SetNetworkForMaskedCard(kVisaCard);
   test::SetServerCreditCards(autofill_table_, server_cards);
 
   // Type the same data as the masked card into a form.
   FormData form;
   AddFullCreditCardForm(&form, "John Dillinger", "4111111111111111", "01",
                         "2999");
 
   // The card should be offered to be saved locally because it only matches the
   // masked server card.
   FormStructure form_structure(form);
@@ skipping 1108 matching lines @@
 // been typed in the field.
 TEST_F(PersonalDataManagerTest,
        GetCreditCardSuggestions_MaskedCardWithMoreThan6Numbers) {
   EnableWalletCardImport();
 
   // Add a masked server card.
   std::vector<CreditCard> server_cards;
   server_cards.push_back(CreditCard(CreditCard::MASKED_SERVER_CARD, "b459"));
   test::SetCreditCardInfo(&server_cards.back(), "Emmet Dalton", "2110", "12",
                           "2999");
-  server_cards.back().SetTypeForMaskedCard(kVisaCard);
+  server_cards.back().SetNetworkForMaskedCard(kVisaCard);
 
   test::SetServerCreditCards(autofill_table_, server_cards);
   personal_data_->Refresh();
   EXPECT_CALL(personal_data_observer_, OnPersonalDataChanged())
       .WillOnce(QuitMainMessageLoop());
   base::RunLoop().Run();
 
   std::vector<Suggestion> suggestions =
       personal_data_->GetCreditCardSuggestions(AutofillType(CREDIT_CARD_NUMBER),
                                                ASCIIToUTF16("12345678"));
@@ skipping 33 matching lines @@
   SetupReferenceLocalCreditCards();
 
   // Add some server cards.
   std::vector<CreditCard> server_cards;
   server_cards.push_back(CreditCard(CreditCard::MASKED_SERVER_CARD, "b459"));
   test::SetCreditCardInfo(&server_cards.back(), "Emmet Dalton", "2110", "12",
                           "2999");
   server_cards.back().set_use_count(2);
   server_cards.back().set_use_date(AutofillClock::Now() -
                                    base::TimeDelta::FromDays(1));
-  server_cards.back().SetTypeForMaskedCard(kVisaCard);
+  server_cards.back().SetNetworkForMaskedCard(kVisaCard);
 
   server_cards.push_back(CreditCard(CreditCard::FULL_SERVER_CARD, "b460"));
   test::SetCreditCardInfo(&server_cards.back(), "Jesse James", "2109", "12",
                           "2999");
   server_cards.back().set_use_count(6);
   server_cards.back().set_use_date(AutofillClock::Now() -
                                    base::TimeDelta::FromDays(1));
 
   test::SetServerCreditCards(autofill_table_, server_cards);
   personal_data_->Refresh();
@@ skipping 96 matching lines @@
 
   ASSERT_EQ(2U, personal_data_->GetCreditCards().size());
 
   // Sublabel is expiration date when filling card number. The second card
   // doesn't have a number so it should not be included in the suggestions.
   std::vector<Suggestion> suggestions =
       personal_data_->GetCreditCardSuggestions(
           AutofillType(CREDIT_CARD_NUMBER),
           /* field_contents= */ base::string16());
   ASSERT_EQ(1U, suggestions.size());
-  EXPECT_EQ(UTF8ToUTF16("Amex" + kUTF8MidlineEllipsis + "8555"),
+  EXPECT_EQ(UTF8ToUTF16(std::string("Amex") + kUTF8MidlineEllipsis + "8555"),
             suggestions[0].value);
   EXPECT_EQ(ASCIIToUTF16("04/99"), suggestions[0].label);
 }
 
 // Tests the suggestions of duplicate local and server credit cards.
 TEST_F(PersonalDataManagerTest, GetCreditCardSuggestions_ServerDuplicates) {
   EnableWalletCardImport();
   SetupReferenceLocalCreditCards();
 
   // Add some server cards. If there are local dupes, the locals should be
   // hidden.
   std::vector<CreditCard> server_cards;
   // This server card matches a local card, except the local card is missing the
   // number. This should count as a dupe and thus not be shown in the
   // suggestions since the locally saved card takes precedence.
   server_cards.push_back(CreditCard(CreditCard::MASKED_SERVER_CARD, "a123"));
   test::SetCreditCardInfo(&server_cards.back(), "John Dillinger",
                           "9012" /* Visa */, "01", "2999");
   server_cards.back().set_use_count(2);
   server_cards.back().set_use_date(AutofillClock::Now() -
                                    base::TimeDelta::FromDays(15));
-  server_cards.back().SetTypeForMaskedCard(kVisaCard);
+  server_cards.back().SetNetworkForMaskedCard(kVisaCard);
 
   // This server card is identical to a local card, but has a different
   // card type. Not a dupe and therefore both should appear in the suggestions.
   server_cards.push_back(CreditCard(CreditCard::MASKED_SERVER_CARD, "b456"));
   test::SetCreditCardInfo(&server_cards.back(), "Bonnie Parker", "2109", "12",
                           "2999");
   server_cards.back().set_use_count(3);
   server_cards.back().set_use_date(AutofillClock::Now() -
                                    base::TimeDelta::FromDays(15));
-  server_cards.back().SetTypeForMaskedCard(kVisaCard);
+  server_cards.back().SetNetworkForMaskedCard(kVisaCard);
 
   // This unmasked server card is an exact dupe of a local card. Therefore only
   // this card should appear in the suggestions as full server cards have
   // precedence over local cards.
   server_cards.push_back(CreditCard(CreditCard::FULL_SERVER_CARD, "c789"));
   test::SetCreditCardInfo(&server_cards.back(), "Clyde Barrow",
                           "347666888555" /* American Express */, "04", "2999");
   server_cards.back().set_use_count(1);
   server_cards.back().set_use_date(AutofillClock::Now() -
                                    base::TimeDelta::FromDays(15));
@@ skipping 10 matching lines @@
           /* field_contents= */ base::string16());
   ASSERT_EQ(4U, suggestions.size());
   EXPECT_EQ(ASCIIToUTF16("John Dillinger"), suggestions[0].value);
   EXPECT_EQ(ASCIIToUTF16("Clyde Barrow"), suggestions[1].value);
   EXPECT_EQ(ASCIIToUTF16("Bonnie Parker"), suggestions[2].value);
   EXPECT_EQ(ASCIIToUTF16("Bonnie Parker"), suggestions[3].value);
 
   suggestions = personal_data_->GetCreditCardSuggestions(
       AutofillType(CREDIT_CARD_NUMBER), /* field_contents= */ base::string16());
   ASSERT_EQ(4U, suggestions.size());
-  EXPECT_EQ(UTF8ToUTF16("Visa" + kUTF8MidlineEllipsis + "9012"),
+  EXPECT_EQ(UTF8ToUTF16(std::string("Visa") + kUTF8MidlineEllipsis + "9012"),
             suggestions[0].value);
-  EXPECT_EQ(UTF8ToUTF16("Amex" + kUTF8MidlineEllipsis + "8555"),
+  EXPECT_EQ(UTF8ToUTF16(std::string("Amex") + kUTF8MidlineEllipsis + "8555"),
             suggestions[1].value);
-  EXPECT_EQ(UTF8ToUTF16("MasterCard" + kUTF8MidlineEllipsis + "2109"),
-            suggestions[2].value);
-  EXPECT_EQ(UTF8ToUTF16("Visa" + kUTF8MidlineEllipsis + "2109"),
+  EXPECT_EQ(
+      UTF8ToUTF16(std::string("MasterCard") + kUTF8MidlineEllipsis + "2109"),
+      suggestions[2].value);
+  EXPECT_EQ(UTF8ToUTF16(std::string("Visa") + kUTF8MidlineEllipsis + "2109"),
             suggestions[3].value);
 }
 
 // Tests that a full server card can be a dupe of more than one local card.
 TEST_F(PersonalDataManagerTest,
        GetCreditCardSuggestions_ServerCardDuplicateOfMultipleLocalCards) {
   EnableWalletCardImport();
   SetupReferenceLocalCreditCards();
 
   // Add a duplicate server card.
@@ skipping 77 matching lines @@
                           "423456789012" /* Visa */, "01", "2999");
   credit_cards.push_back(&local_card);
 
   // Create a masked server card that is a duplicate of a local card.
   CreditCard masked_card(CreditCard::MASKED_SERVER_CARD, "a123");
   test::SetCreditCardInfo(&masked_card, "Homer Simpson", "9012" /* Visa */,
                           "01", "2999");
   masked_card.set_use_count(2);
   masked_card.set_use_date(AutofillClock::Now() -
                            base::TimeDelta::FromDays(15));
-  masked_card.SetTypeForMaskedCard(kVisaCard);
+  masked_card.SetNetworkForMaskedCard(kVisaCard);
   credit_cards.push_back(&masked_card);
 
   PersonalDataManager::DedupeCreditCardToSuggest(&credit_cards);
   ASSERT_EQ(1U, credit_cards.size());
 
   const CreditCard* deduped_card(credit_cards.front());
   EXPECT_TRUE(*deduped_card == local_card);
 }
 
 // Tests that identical full server and masked credit cards are not deduped.
 TEST_F(PersonalDataManagerTest, DedupeCreditCardToSuggest_FullServerAndMasked) {
   std::list<CreditCard*> credit_cards;
 
   // Create a full server card that is a duplicate of one of the local cards.
   CreditCard full_server_card(CreditCard::FULL_SERVER_CARD, "c789");
   test::SetCreditCardInfo(&full_server_card, "Homer Simpson",
                           "423456789012" /* Visa */, "01", "2999");
   full_server_card.set_use_count(1);
   full_server_card.set_use_date(AutofillClock::Now() -
                                 base::TimeDelta::FromDays(15));
   credit_cards.push_back(&full_server_card);
 
   // Create a masked server card that is a duplicate of a local card.
   CreditCard masked_card(CreditCard::MASKED_SERVER_CARD, "a123");
   test::SetCreditCardInfo(&masked_card, "Homer Simpson", "9012" /* Visa */,
                           "01", "2999");
   masked_card.set_use_count(2);
   masked_card.set_use_date(AutofillClock::Now() -
                            base::TimeDelta::FromDays(15));
-  masked_card.SetTypeForMaskedCard(kVisaCard);
+  masked_card.SetNetworkForMaskedCard(kVisaCard);
   credit_cards.push_back(&masked_card);
 
   PersonalDataManager::DedupeCreditCardToSuggest(&credit_cards);
   EXPECT_EQ(2U, credit_cards.size());
 }
 
 // Tests that slightly different local, full server, and masked credit cards are
 // not deduped.
 TEST_F(PersonalDataManagerTest, DedupeCreditCardToSuggest_DifferentCards) {
   std::list<CreditCard*> credit_cards;
 
   CreditCard credit_card2("002149C1-EE28-4213-A3B9-DA243FFF021B",
                           "https://www.example.com");
   credit_card2.set_use_count(1);
   credit_card2.set_use_date(AutofillClock::Now() -
                             base::TimeDelta::FromDays(1));
   test::SetCreditCardInfo(&credit_card2, "Homer Simpson",
                           "518765432109" /* Mastercard */, "", "");
   credit_cards.push_back(&credit_card2);
 
   // Create a masked server card that is slightly different of the local card.
   CreditCard credit_card4(CreditCard::MASKED_SERVER_CARD, "b456");
   test::SetCreditCardInfo(&credit_card4, "Homer Simpson", "2109", "12", "2999");
   credit_card4.set_use_count(3);
   credit_card4.set_use_date(AutofillClock::Now() -
                             base::TimeDelta::FromDays(15));
-  credit_card4.SetTypeForMaskedCard(kVisaCard);
+  credit_card4.SetNetworkForMaskedCard(kVisaCard);
   credit_cards.push_back(&credit_card4);
 
   // Create a full server card that is slightly different of the two other
   // cards.
   CreditCard credit_card5(CreditCard::FULL_SERVER_CARD, "c789");
   test::SetCreditCardInfo(&credit_card5, "Homer Simpson",
                           "347666888555" /* American Express */, "04", "2999");
   credit_card5.set_use_count(1);
   credit_card5.set_use_date(AutofillClock::Now() -
                             base::TimeDelta::FromDays(15));
@@ skipping 66 matching lines @@
   EXPECT_EQ(kArbitraryTime, added_card->modification_date());
 }
 
 TEST_F(PersonalDataManagerTest, UpdateServerCreditCardUsageStats) {
   EnableWalletCardImport();
 
   std::vector<CreditCard> server_cards;
   server_cards.push_back(CreditCard(CreditCard::MASKED_SERVER_CARD, "a123"));
   test::SetCreditCardInfo(&server_cards.back(), "John Dillinger",
                           "9012" /* Visa */, "01", "2999");
-  server_cards.back().SetTypeForMaskedCard(kVisaCard);
+  server_cards.back().SetNetworkForMaskedCard(kVisaCard);
 
   server_cards.push_back(CreditCard(CreditCard::MASKED_SERVER_CARD, "b456"));
   test::SetCreditCardInfo(&server_cards.back(), "Bonnie Parker",
                           "4444" /* Mastercard */, "12", "2999");
-  server_cards.back().SetTypeForMaskedCard(kMasterCard);
+  server_cards.back().SetNetworkForMaskedCard(kMasterCard);
 
   server_cards.push_back(CreditCard(CreditCard::FULL_SERVER_CARD, "c789"));
   test::SetCreditCardInfo(&server_cards.back(), "Clyde Barrow",
                           "347666888555" /* American Express */, "04", "2999");
 
   // Create the test clock and set the time to a specific value.
   TestAutofillClock test_clock;
   test_clock.SetNow(kArbitraryTime);
 
   test::SetServerCreditCards(autofill_table_, server_cards);
@@ skipping 96 matching lines @@
   EXPECT_EQ(3U, personal_data_->GetCreditCards()[1]->use_count());
   EXPECT_EQ(kMuchLaterTime, personal_data_->GetCreditCards()[1]->use_date());
 }
 
 TEST_F(PersonalDataManagerTest, ClearAllServerData) {
   // Add a server card.
   std::vector<CreditCard> server_cards;
   server_cards.push_back(CreditCard(CreditCard::MASKED_SERVER_CARD, "a123"));
   test::SetCreditCardInfo(&server_cards.back(), "John Dillinger",
                           "9012" /* Visa */, "01", "2999");
-  server_cards.back().SetTypeForMaskedCard(kVisaCard);
+  server_cards.back().SetNetworkForMaskedCard(kVisaCard);
   test::SetServerCreditCards(autofill_table_, server_cards);
   personal_data_->Refresh();
 
   // Need to set the google services username
   EnableWalletCardImport();
 
   // The card and profile should be there.
   ResetPersonalDataManager(USER_MODE_NORMAL);
   EXPECT_FALSE(personal_data_->GetCreditCards().empty());
 
   personal_data_->ClearAllServerData();
 
   // Reload the database, everything should be gone.
   ResetPersonalDataManager(USER_MODE_NORMAL);
   EXPECT_TRUE(personal_data_->GetCreditCards().empty());
 }
 
 TEST_F(PersonalDataManagerTest, DontDuplicateServerCard) {
   EnableWalletCardImport();
 
   std::vector<CreditCard> server_cards;
   server_cards.push_back(CreditCard(CreditCard::MASKED_SERVER_CARD, "a123"));
   test::SetCreditCardInfo(&server_cards.back(), "John Dillinger",
                           "1881" /* Visa */, "01", "2999");
-  server_cards.back().SetTypeForMaskedCard(kVisaCard);
+  server_cards.back().SetNetworkForMaskedCard(kVisaCard);
 
   server_cards.push_back(CreditCard(CreditCard::FULL_SERVER_CARD, "c789"));
   test::SetCreditCardInfo(&server_cards.back(), "Clyde Barrow",
                           "347666888555" /* American Express */, "04", "2999");
 
   test::SetServerCreditCards(autofill_table_, server_cards);
   personal_data_->Refresh();
   EXPECT_CALL(personal_data_observer_, OnPersonalDataChanged())
       .WillOnce(QuitMainMessageLoop());
   base::RunLoop().Run();
@@ skipping 43 matching lines @@
   EXPECT_FALSE(personal_data_->ImportFormData(form_structure2, false,
                                               &imported_credit_card2));
   EXPECT_FALSE(imported_credit_card2);
 }
 
 // Tests the SaveImportedProfile method with different profiles to make sure the
 // merge logic works correctly.
 typedef struct {
   autofill::ServerFieldType field_type;
   std::string field_value;
-  } ProfileField;
-
-  typedef std::vector<ProfileField> ProfileFields;
-
-  typedef struct {
-    // Each test starts with a default pre-existing profile and applies these
-    // changes to it.
-    ProfileFields changes_to_original;
-    // Each test saves a second profile. Applies these changes to the default
-    // values before saving.
-    ProfileFields changes_to_new;
-    // For tests with profile merging, makes sure that these fields' values are
-    // the ones we expect (depending on the test).
-    ProfileFields changed_field_values;
-  } SaveImportedProfileTestCase;
-
-  class SaveImportedProfileTest
-      : public PersonalDataManagerTestBase,
-        public testing::TestWithParam<SaveImportedProfileTestCase> {
-   public:
-    SaveImportedProfileTest() {}
-    ~SaveImportedProfileTest() override {}
-
-    void SetUp() override {
-      OSCryptMocker::SetUpWithSingleton();
-      prefs_ = test::PrefServiceForTesting();
-      ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());
-      base::FilePath path = temp_dir_.GetPath().AppendASCII("TestWebDB");
-      web_database_ =
-          new WebDatabaseService(path, base::ThreadTaskRunnerHandle::Get(),
-                                 base::ThreadTaskRunnerHandle::Get());
-
-      // Setup account tracker.
-      signin_client_.reset(new TestSigninClient(prefs_.get()));
-      account_tracker_.reset(new AccountTrackerService());
-      account_tracker_->Initialize(signin_client_.get());
-      signin_manager_.reset(new FakeSigninManagerBase(signin_client_.get(),
-                                                      account_tracker_.get()));
-      signin_manager_->Initialize(prefs_.get());
-
-      // Hacky: hold onto a pointer but pass ownership.
-      autofill_table_ = new AutofillTable;
-      web_database_->AddTable(
-          std::unique_ptr<WebDatabaseTable>(autofill_table_));
-      web_database_->LoadDatabase();
-      autofill_database_service_ = new AutofillWebDataService(
-          web_database_, base::ThreadTaskRunnerHandle::Get(),
-          base::ThreadTaskRunnerHandle::Get(),
-          WebDataServiceBase::ProfileErrorCallback());
-      autofill_database_service_->Init();
-
-      test::DisableSystemServices(prefs_.get());
-      ResetPersonalDataManager(USER_MODE_NORMAL);
-
-      // Reset the deduping pref to its default value.
-      personal_data_->pref_service_->SetInteger(
-          prefs::kAutofillLastVersionDeduped, 0);
-      personal_data_->pref_service_->SetBoolean(
-          prefs::kAutofillProfileUseDatesFixed, false);
+} ProfileField;
+
+typedef std::vector<ProfileField> ProfileFields;
+
+typedef struct {
+  // Each test starts with a default pre-existing profile and applies these
+  // changes to it.
+  ProfileFields changes_to_original;
+  // Each test saves a second profile. Applies these changes to the default
+  // values before saving.
+  ProfileFields changes_to_new;
+  // For tests with profile merging, makes sure that these fields' values are
+  // the ones we expect (depending on the test).
+  ProfileFields changed_field_values;
+} SaveImportedProfileTestCase;
+
+class SaveImportedProfileTest
+    : public PersonalDataManagerTestBase,
+      public testing::TestWithParam<SaveImportedProfileTestCase> {
+ public:
+  SaveImportedProfileTest() {}
+  ~SaveImportedProfileTest() override {}
+
+  void SetUp() override {
+    OSCryptMocker::SetUpWithSingleton();
+    prefs_ = test::PrefServiceForTesting();
+    ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());
+    base::FilePath path = temp_dir_.GetPath().AppendASCII("TestWebDB");
+    web_database_ =
+        new WebDatabaseService(path, base::ThreadTaskRunnerHandle::Get(),
+                               base::ThreadTaskRunnerHandle::Get());
+
+    // Setup account tracker.
+    signin_client_.reset(new TestSigninClient(prefs_.get()));
+    account_tracker_.reset(new AccountTrackerService());
+    account_tracker_->Initialize(signin_client_.get());
+    signin_manager_.reset(new FakeSigninManagerBase(signin_client_.get(),
+                                                    account_tracker_.get()));
+    signin_manager_->Initialize(prefs_.get());
+
+    // Hacky: hold onto a pointer but pass ownership.
+    autofill_table_ = new AutofillTable;
+    web_database_->AddTable(std::unique_ptr<WebDatabaseTable>(autofill_table_));
+    web_database_->LoadDatabase();
+    autofill_database_service_ = new AutofillWebDataService(
+        web_database_, base::ThreadTaskRunnerHandle::Get(),
+        base::ThreadTaskRunnerHandle::Get(),
+        WebDataServiceBase::ProfileErrorCallback());
+    autofill_database_service_->Init();
+
+    test::DisableSystemServices(prefs_.get());
+    ResetPersonalDataManager(USER_MODE_NORMAL);
+
+    // Reset the deduping pref to its default value.
+    personal_data_->pref_service_->SetInteger(
+        prefs::kAutofillLastVersionDeduped, 0);
+    personal_data_->pref_service_->SetBoolean(
+        prefs::kAutofillProfileUseDatesFixed, false);
+  }
+
+  void TearDown() override {
+    // Order of destruction is important as AutofillManager relies on
+    // PersonalDataManager to be around when it gets destroyed.
+    signin_manager_->Shutdown();
+    signin_manager_.reset();
+
+    account_tracker_->Shutdown();
+    account_tracker_.reset();
+    signin_client_.reset();
+
+    test::DisableSystemServices(prefs_.get());
+    OSCryptMocker::TearDown();
+  }
+};
+
+TEST_P(SaveImportedProfileTest, SaveImportedProfile) {
+  // Create the test clock.
+  TestAutofillClock test_clock;
+  auto test_case = GetParam();
+  // Set the time to a specific value.
+  test_clock.SetNow(kArbitraryTime);
+
+  SetupReferenceProfile();
+  const std::vector<AutofillProfile*>& initial_profiles =
+      personal_data_->GetProfiles();
+
+  // Apply changes to the original profile (if applicable).
+  for (ProfileField change : test_case.changes_to_original) {
+    initial_profiles.front()->SetRawInfo(change.field_type,
+                                         base::UTF8ToUTF16(change.field_value));
+  }
+
+  // Set the time to a bigger value.
+  test_clock.SetNow(kSomeLaterTime);
+
+  AutofillProfile profile2(base::GenerateGUID(), "https://www.example.com");
+  test::SetProfileInfo(&profile2, "Marion", "Mitchell", "Morrison",
+                       "johnwayne@me.xyz", "Fox", "123 Zoo St", "unit 5",
+                       "Hollywood", "CA", "91601", "US", "12345678910");
+
+  // Apply changes to the second profile (if applicable).
+  for (ProfileField change : test_case.changes_to_new) {
+    profile2.SetRawInfo(change.field_type,
+                        base::UTF8ToUTF16(change.field_value));
+  }
+
+  personal_data_->SaveImportedProfile(profile2);
+
+  const std::vector<AutofillProfile*>& saved_profiles =
+      personal_data_->GetProfiles();
+
+  // If there are no merge changes to verify, make sure that two profiles were
+  // saved.
+  if (test_case.changed_field_values.empty()) {
+    EXPECT_EQ(2U, saved_profiles.size());
+  } else {
+    EXPECT_EQ(1U, saved_profiles.size());
+
+    // Make sure the new information was merged correctly.
+    for (ProfileField changed_field : test_case.changed_field_values) {
+      EXPECT_EQ(base::UTF8ToUTF16(changed_field.field_value),
+                saved_profiles.front()->GetRawInfo(changed_field.field_type));
     }
-
-    void TearDown() override {
-      // Order of destruction is important as AutofillManager relies on
-      // PersonalDataManager to be around when it gets destroyed.
-      signin_manager_->Shutdown();
-      signin_manager_.reset();
-
-      account_tracker_->Shutdown();
-      account_tracker_.reset();
-      signin_client_.reset();
-
-      test::DisableSystemServices(prefs_.get());
-      OSCryptMocker::TearDown();
-    }
-  };
-
-  TEST_P(SaveImportedProfileTest, SaveImportedProfile) {
-    // Create the test clock.
-    TestAutofillClock test_clock;
-    auto test_case = GetParam();
-    // Set the time to a specific value.
-    test_clock.SetNow(kArbitraryTime);
-
-    SetupReferenceProfile();
-    const std::vector<AutofillProfile*>& initial_profiles =
-        personal_data_->GetProfiles();
-
-    // Apply changes to the original profile (if applicable).
-    for (ProfileField change : test_case.changes_to_original) {
-      initial_profiles.front()->SetRawInfo(
-          change.field_type, base::UTF8ToUTF16(change.field_value));
-    }
-
-    // Set the time to a bigger value.
-    test_clock.SetNow(kSomeLaterTime);
-
-    AutofillProfile profile2(base::GenerateGUID(), "https://www.example.com");
-    test::SetProfileInfo(&profile2, "Marion", "Mitchell", "Morrison",
-                         "johnwayne@me.xyz", "Fox", "123 Zoo St", "unit 5",
-                         "Hollywood", "CA", "91601", "US", "12345678910");
-
-    // Apply changes to the second profile (if applicable).
-    for (ProfileField change : test_case.changes_to_new) {
-      profile2.SetRawInfo(change.field_type,
-                          base::UTF8ToUTF16(change.field_value));
-    }
-
-    personal_data_->SaveImportedProfile(profile2);
-
-    const std::vector<AutofillProfile*>& saved_profiles =
-        personal_data_->GetProfiles();
-
-    // If there are no merge changes to verify, make sure that two profiles were
-    // saved.
-    if (test_case.changed_field_values.empty()) {
-      EXPECT_EQ(2U, saved_profiles.size());
-    } else {
-      EXPECT_EQ(1U, saved_profiles.size());
-
-      // Make sure the new information was merged correctly.
-      for (ProfileField changed_field : test_case.changed_field_values) {
-        EXPECT_EQ(base::UTF8ToUTF16(changed_field.field_value),
-                  saved_profiles.front()->GetRawInfo(changed_field.field_type));
-      }
-      // Verify that the merged profile's use count, use date and modification
-      // date were properly updated.
-      EXPECT_EQ(1U, saved_profiles.front()->use_count());
-      EXPECT_EQ(kSomeLaterTime, saved_profiles.front()->use_date());
-      EXPECT_EQ(kSomeLaterTime, saved_profiles.front()->modification_date());
-    }
-
-    // Erase the profiles for the next test.
-    ResetProfiles();
+    // Verify that the merged profile's use count, use date and modification
+    // date were properly updated.
+    EXPECT_EQ(1U, saved_profiles.front()->use_count());
+    EXPECT_EQ(kSomeLaterTime, saved_profiles.front()->use_date());
+    EXPECT_EQ(kSomeLaterTime, saved_profiles.front()->modification_date());
   }
 
-  INSTANTIATE_TEST_CASE_P(
-      PersonalDataManagerTest,
-      SaveImportedProfileTest,
-      testing::Values(
-          // Test that saving an identical profile except for the name results
-          // in two profiles being saved.
-          SaveImportedProfileTestCase{ProfileFields(),
-                                      {{NAME_FIRST, "Marionette"}}},
-
-          // Test that saving an identical profile except with the middle name
-          // initial instead of the full middle name results in the profiles
-          // getting merged and the full middle name being kept.
-          SaveImportedProfileTestCase{
-              ProfileFields(),
-              {{NAME_MIDDLE, "M"}},
-              {{NAME_MIDDLE, "Mitchell"},
-               {NAME_FULL, "Marion Mitchell Morrison"}}},
-
-          // Test that saving an identical profile except with the full middle
-          // name instead of the middle name initial results in the profiles
-          // getting merged and the full middle name replacing the initial.
-          SaveImportedProfileTestCase{{{NAME_MIDDLE, "M"}},
-                                      {{NAME_MIDDLE, "Mitchell"}},
-                                      {{NAME_MIDDLE, "Mitchell"}}},
-
-          // Test that saving an identical profile except with no middle name
-          // results in the profiles getting merged and the full middle name
-          // being kept.
-          SaveImportedProfileTestCase{ProfileFields(),
-                                      {{NAME_MIDDLE, ""}},
-                                      {{NAME_MIDDLE, "Mitchell"}}},
-
-          // Test that saving an identical profile except with a middle name
-          // initial results in the profiles getting merged and the middle name
-          // initial being saved.
-          SaveImportedProfileTestCase{{{NAME_MIDDLE, ""}},
-                                      {{NAME_MIDDLE, "M"}},
-                                      {{NAME_MIDDLE, "M"}}},
-
-          // Test that saving an identical profile except with a middle name
-          // results in the profiles getting merged and the full middle name
-          // being saved.
-          SaveImportedProfileTestCase{{{NAME_MIDDLE, ""}},
-                                      {{NAME_MIDDLE, "Mitchell"}},
-                                      {{NAME_MIDDLE, "Mitchell"}}},
-
-          // Test that saving a identical profile except with the full name set
-          // instead of the name parts results in the two profiles being merged
-          // and all the name parts kept and the full name being added.
-          SaveImportedProfileTestCase{
-              {
-                  {NAME_FIRST, "Marion"},
-                  {NAME_MIDDLE, "Mitchell"},
-                  {NAME_LAST, "Morrison"},
-                  {NAME_FULL, ""},
-              },
-              {
-                  {NAME_FIRST, ""},
-                  {NAME_MIDDLE, ""},
-                  {NAME_LAST, ""},
-                  {NAME_FULL, "Marion Mitchell Morrison"},
-              },
-              {
-                  {NAME_FIRST, "Marion"},
-                  {NAME_MIDDLE, "Mitchell"},
-                  {NAME_LAST, "Morrison"},
-                  {NAME_FULL, "Marion Mitchell Morrison"},
-              },
-          },
-
-          // Test that saving a identical profile except with the name parts set
-          // instead of the full name results in the two profiles being merged
-          // and the full name being kept and all the name parts being added.
-          SaveImportedProfileTestCase{
-              {
-                  {NAME_FIRST, ""},
-                  {NAME_MIDDLE, ""},
-                  {NAME_LAST, ""},
-                  {NAME_FULL, "Marion Mitchell Morrison"},
-              },
-              {
-                  {NAME_FIRST, "Marion"},
-                  {NAME_MIDDLE, "Mitchell"},
-                  {NAME_LAST, "Morrison"},
-                  {NAME_FULL, ""},
-              },
-              {
-                  {NAME_FIRST, "Marion"},
-                  {NAME_MIDDLE, "Mitchell"},
-                  {NAME_LAST, "Morrison"},
-                  {NAME_FULL, "Marion Mitchell Morrison"},
-              },
-          },
-
-          // Test that saving a profile that has only a full name set does not
-          // get merged with a profile with only the name parts set if the names
-          // are different.
-          SaveImportedProfileTestCase{
-              {
-                  {NAME_FIRST, "Marion"},
-                  {NAME_MIDDLE, "Mitchell"},
-                  {NAME_LAST, "Morrison"},
-                  {NAME_FULL, ""},
-              },
-              {
-                  {NAME_FIRST, ""},
-                  {NAME_MIDDLE, ""},
-                  {NAME_LAST, ""},
-                  {NAME_FULL, "John Thompson Smith"},
-              },
-          },
-
-          // Test that saving a profile that has only the name parts set does
-          // not get merged with a profile with only the full name set if the
-          // names are different.
-          SaveImportedProfileTestCase{
-              {
-                  {NAME_FIRST, ""},
-                  {NAME_MIDDLE, ""},
-                  {NAME_LAST, ""},
-                  {NAME_FULL, "John Thompson Smith"},
-              },
-              {
-                  {NAME_FIRST, "Marion"},
-                  {NAME_MIDDLE, "Mitchell"},
-                  {NAME_LAST, "Morrison"},
-                  {NAME_FULL, ""},
-              },
-          },
-
-          // Test that saving an identical profile except for the first address
-          // line results in two profiles being saved.
-          SaveImportedProfileTestCase{
-              ProfileFields(),
-              {{ADDRESS_HOME_LINE1, "123 Aquarium St."}}},
-
-          // Test that saving an identical profile except for the second address
-          // line results in two profiles being saved.
-          SaveImportedProfileTestCase{ProfileFields(),
-                                      {{ADDRESS_HOME_LINE2, "unit 7"}}},
-
-          // Tests that saving an identical profile that has a new piece of
-          // information (company name) results in a merge and that the original
-          // empty value gets overwritten by the new information.
-          SaveImportedProfileTestCase{{{COMPANY_NAME, ""}},
-                                      ProfileFields(),
-                                      {{COMPANY_NAME, "Fox"}}},
-
-          // Tests that saving an identical profile except a loss of information
-          // results in a merge but the original value is not overwritten (no
-          // information loss).
-          SaveImportedProfileTestCase{ProfileFields(),
-                                      {{COMPANY_NAME, ""}},
-                                      {{COMPANY_NAME, "Fox"}}},
-
-          // Tests that saving an identical profile except a slightly different
-          // postal code results in a merge with the new value kept.
-          SaveImportedProfileTestCase{{{ADDRESS_HOME_ZIP, "R2C 0A1"}},
-                                      {{ADDRESS_HOME_ZIP, "R2C0A1"}},
-                                      {{ADDRESS_HOME_ZIP, "R2C0A1"}}},
-          SaveImportedProfileTestCase{{{ADDRESS_HOME_ZIP, "R2C0A1"}},
-                                      {{ADDRESS_HOME_ZIP, "R2C 0A1"}},
-                                      {{ADDRESS_HOME_ZIP, "R2C 0A1"}}},
-          SaveImportedProfileTestCase{{{ADDRESS_HOME_ZIP, "r2c 0a1"}},
-                                      {{ADDRESS_HOME_ZIP, "R2C0A1"}},
-                                      {{ADDRESS_HOME_ZIP, "R2C0A1"}}},
-
-          // Tests that saving an identical profile plus a new piece of
-          // information on the address line 2 results in a merge and that the
-          // original empty value gets overwritten by the new information.
-          SaveImportedProfileTestCase{{{ADDRESS_HOME_LINE2, ""}},
-                                      ProfileFields(),
-                                      {{ADDRESS_HOME_LINE2, "unit 5"}}},
-
-          // Tests that saving an identical profile except a loss of information
-          // on the address line 2 results in a merge but that the original
-          // value gets not overwritten (no information loss).
-          SaveImportedProfileTestCase{ProfileFields(),
-                                      {{ADDRESS_HOME_LINE2, ""}},
-                                      {{ADDRESS_HOME_LINE2, "unit 5"}}},
-
-          // Tests that saving an identical except with more punctuation in the
-          // fist address line, while the second is empty, results in a merge
-          // and that the original address gets overwritten.
-          SaveImportedProfileTestCase{
-              {{ADDRESS_HOME_LINE2, ""}},
-              {{ADDRESS_HOME_LINE2, ""}, {ADDRESS_HOME_LINE1, "123, Zoo St."}},
-              {{ADDRESS_HOME_LINE1, "123, Zoo St."}}},
-
-          // Tests that saving an identical profile except with less punctuation
-          // in the fist address line, while the second is empty, results in a
-          // merge and that the longer address is retained.
-          SaveImportedProfileTestCase{
-              {{ADDRESS_HOME_LINE2, ""}, {ADDRESS_HOME_LINE1, "123, Zoo St."}},
-              {{ADDRESS_HOME_LINE2, ""}},
-              {{ADDRESS_HOME_LINE1, "123 Zoo St"}}},
-
-          // Tests that saving an identical profile except additional
-          // punctuation in the two address lines results in a merge and that
-          // the newer address is retained.
-          SaveImportedProfileTestCase{ProfileFields(),
-                                      {{ADDRESS_HOME_LINE1, "123, Zoo St."},
-                                       {ADDRESS_HOME_LINE2, "unit. 5"}},
-                                      {{ADDRESS_HOME_LINE1, "123, Zoo St."},
-                                       {ADDRESS_HOME_LINE2, "unit. 5"}}},
-
-          // Tests that saving an identical profile except less punctuation in
-          // the two address lines results in a merge and that the newer address
-          // is retained.
-          SaveImportedProfileTestCase{{{ADDRESS_HOME_LINE1, "123, Zoo St."},
-                                       {ADDRESS_HOME_LINE2, "unit. 5"}},
-                                      ProfileFields(),
-                                      {{ADDRESS_HOME_LINE1, "123 Zoo St"},
-                                       {ADDRESS_HOME_LINE2, "unit 5"}}},
-
-          // Tests that saving an identical profile with accented characters in
-          // the two address lines results in a merge and that the newer address
-          // is retained.
-          SaveImportedProfileTestCase{ProfileFields(),
-                                      {{ADDRESS_HOME_LINE1, "123 Zôö St"},
-                                       {ADDRESS_HOME_LINE2, "üñìt 5"}},
-                                      {{ADDRESS_HOME_LINE1, "123 Zôö St"},
-                                       {ADDRESS_HOME_LINE2, "üñìt 5"}}},
-
-          // Tests that saving an identical profile without accented characters
-          // in the two address lines results in a merge and that the newer
-          // address is retained.
-          SaveImportedProfileTestCase{{{ADDRESS_HOME_LINE1, "123 Zôö St"},
-                                       {ADDRESS_HOME_LINE2, "üñìt 5"}},
-                                      ProfileFields(),
-                                      {{ADDRESS_HOME_LINE1, "123 Zoo St"},
-                                       {ADDRESS_HOME_LINE2, "unit 5"}}},
-
-          // Tests that saving an identical profile except that the address line
-          // 1 is in the address line 2 results in a merge and that the
-          // multi-lne address is retained.
-          SaveImportedProfileTestCase{
-              ProfileFields(),
-              {{ADDRESS_HOME_LINE1, "123 Zoo St, unit 5"},
-               {ADDRESS_HOME_LINE2, ""}},
-              {{ADDRESS_HOME_LINE1, "123 Zoo St"},
-               {ADDRESS_HOME_LINE2, "unit 5"}}},
-
-          // Tests that saving an identical profile except that the address line
-          // 2 contains part of the old address line 1 results in a merge and
-          // that the original address lines of the reference profile get
-          // overwritten.
-          SaveImportedProfileTestCase{
-              {{ADDRESS_HOME_LINE1, "123 Zoo St, unit 5"},
-               {ADDRESS_HOME_LINE2, ""}},
-              ProfileFields(),
-              {{ADDRESS_HOME_LINE1, "123 Zoo St"},
-               {ADDRESS_HOME_LINE2, "unit 5"}}},
-
-          // Tests that saving an identical profile except that the state is the
-          // abbreviation instead of the full form results in a merge and that
-          // the original state gets overwritten.
-          SaveImportedProfileTestCase{{{ADDRESS_HOME_STATE, "California"}},
-                                      ProfileFields(),
-                                      {{ADDRESS_HOME_STATE, "CA"}}},
-
-          // Tests that saving an identical profile except that the state is the
-          // full form instead of the abbreviation results in a merge and that
-          // the abbreviated state is retained.
-          SaveImportedProfileTestCase{ProfileFields(),
-                                      {{ADDRESS_HOME_STATE, "California"}},
-                                      {{ADDRESS_HOME_STATE, "CA"}}},
-
-          // Tests that saving and identical profile except that the company
-          // name has different punctuation and case results in a merge and that
-          // the syntax of the new profile replaces the old one.
-          SaveImportedProfileTestCase{{{COMPANY_NAME, "Stark inc"}},
-                                      {{COMPANY_NAME, "Stark Inc."}},
-                                      {{COMPANY_NAME, "Stark Inc."}}}));
-
-  // Tests that MergeProfile tries to merge the imported profile into the
-  // existing profile in decreasing order of frecency.
-  TEST_F(PersonalDataManagerTest, MergeProfile_Frecency) {
-    // Create two very similar profiles except with different company names.
-    std::unique_ptr<AutofillProfile> profile1 =
-        base::MakeUnique<AutofillProfile>(base::GenerateGUID(),
-                                          "https://www.example.com");
-    test::SetProfileInfo(profile1.get(), "Homer", "Jay", "Simpson",
-                         "homer.simpson@abc.com", "SNP",
-                         "742 Evergreen Terrace", "", "Springfield", "IL",
-                         "91601", "US", "12345678910");
-    AutofillProfile* profile2 =
-        new AutofillProfile(base::GenerateGUID(), "https://www.example.com");
-    test::SetProfileInfo(profile2, "Homer", "Jay", "Simpson",
-                         "homer.simpson@abc.com", "Fox",
-                         "742 Evergreen Terrace", "", "Springfield", "IL",
-                         "91601", "US", "12345678910");
-
-    // Give the "Fox" profile a bigger frecency score.
-    profile2->set_use_count(15);
-
-    // Create the |existing_profiles| vector.
-    std::vector<std::unique_ptr<AutofillProfile>> existing_profiles;
-    existing_profiles.push_back(std::move(profile1));
-    existing_profiles.push_back(base::WrapUnique(profile2));
-
-    // Create a new imported profile with no company name.
-    AutofillProfile imported_profile(base::GenerateGUID(),
-                                     "https://www.example.com");
-    test::SetProfileInfo(&imported_profile, "Homer", "Jay", "Simpson",
-                         "homer.simpson@abc.com", "", "742 Evergreen Terrace",
-                         "", "Springfield", "IL", "91601", "US", "12345678910");
-
-    // Merge the imported profile into the existing profiles.
-    std::vector<AutofillProfile> profiles;
-    std::string guid = personal_data_->MergeProfile(
-        imported_profile, &existing_profiles, "US-EN", &profiles);
-
-    // The new profile should be merged into the "fox" profile.
-    EXPECT_EQ(profile2->guid(), guid);
+  // Erase the profiles for the next test.
+  ResetProfiles();
 }
 
+INSTANTIATE_TEST_CASE_P(
+    PersonalDataManagerTest,
+    SaveImportedProfileTest,
+    testing::Values(
+        // Test that saving an identical profile except for the name results
+        // in two profiles being saved.
+        SaveImportedProfileTestCase{ProfileFields(),
+                                    {{NAME_FIRST, "Marionette"}}},
+
+        // Test that saving an identical profile except with the middle name
+        // initial instead of the full middle name results in the profiles
+        // getting merged and the full middle name being kept.
+        SaveImportedProfileTestCase{ProfileFields(),
+                                    {{NAME_MIDDLE, "M"}},
+                                    {{NAME_MIDDLE, "Mitchell"},
+                                     {NAME_FULL, "Marion Mitchell Morrison"}}},
+
+        // Test that saving an identical profile except with the full middle
+        // name instead of the middle name initial results in the profiles
+        // getting merged and the full middle name replacing the initial.
+        SaveImportedProfileTestCase{{{NAME_MIDDLE, "M"}},
+                                    {{NAME_MIDDLE, "Mitchell"}},
+                                    {{NAME_MIDDLE, "Mitchell"}}},
+
+        // Test that saving an identical profile except with no middle name
+        // results in the profiles getting merged and the full middle name
+        // being kept.
+        SaveImportedProfileTestCase{ProfileFields(),
+                                    {{NAME_MIDDLE, ""}},
+                                    {{NAME_MIDDLE, "Mitchell"}}},
+
+        // Test that saving an identical profile except with a middle name
+        // initial results in the profiles getting merged and the middle name
+        // initial being saved.
+        SaveImportedProfileTestCase{{{NAME_MIDDLE, ""}},
+                                    {{NAME_MIDDLE, "M"}},
+                                    {{NAME_MIDDLE, "M"}}},
+
+        // Test that saving an identical profile except with a middle name
+        // results in the profiles getting merged and the full middle name
+        // being saved.
+        SaveImportedProfileTestCase{{{NAME_MIDDLE, ""}},
+                                    {{NAME_MIDDLE, "Mitchell"}},
+                                    {{NAME_MIDDLE, "Mitchell"}}},
+
+        // Test that saving a identical profile except with the full name set
+        // instead of the name parts results in the two profiles being merged
+        // and all the name parts kept and the full name being added.
+        SaveImportedProfileTestCase{
+            {
+                {NAME_FIRST, "Marion"},
+                {NAME_MIDDLE, "Mitchell"},
+                {NAME_LAST, "Morrison"},
+                {NAME_FULL, ""},
+            },
+            {
+                {NAME_FIRST, ""},
+                {NAME_MIDDLE, ""},
+                {NAME_LAST, ""},
+                {NAME_FULL, "Marion Mitchell Morrison"},
+            },
+            {
+                {NAME_FIRST, "Marion"},
+                {NAME_MIDDLE, "Mitchell"},
+                {NAME_LAST, "Morrison"},
+                {NAME_FULL, "Marion Mitchell Morrison"},
+            },
+        },
+
+        // Test that saving a identical profile except with the name parts set
+        // instead of the full name results in the two profiles being merged
+        // and the full name being kept and all the name parts being added.
+        SaveImportedProfileTestCase{
+            {
+                {NAME_FIRST, ""},
+                {NAME_MIDDLE, ""},
+                {NAME_LAST, ""},
+                {NAME_FULL, "Marion Mitchell Morrison"},
+            },
+            {
+                {NAME_FIRST, "Marion"},
+                {NAME_MIDDLE, "Mitchell"},
+                {NAME_LAST, "Morrison"},
+                {NAME_FULL, ""},
+            },
+            {
+                {NAME_FIRST, "Marion"},
+                {NAME_MIDDLE, "Mitchell"},
+                {NAME_LAST, "Morrison"},
+                {NAME_FULL, "Marion Mitchell Morrison"},
+            },
+        },
+
+        // Test that saving a profile that has only a full name set does not
+        // get merged with a profile with only the name parts set if the names
+        // are different.
+        SaveImportedProfileTestCase{
+            {
+                {NAME_FIRST, "Marion"},
+                {NAME_MIDDLE, "Mitchell"},
+                {NAME_LAST, "Morrison"},
+                {NAME_FULL, ""},
+            },
+            {
+                {NAME_FIRST, ""},
+                {NAME_MIDDLE, ""},
+                {NAME_LAST, ""},
+                {NAME_FULL, "John Thompson Smith"},
+            },
+        },
+
+        // Test that saving a profile that has only the name parts set does
+        // not get merged with a profile with only the full name set if the
+        // names are different.
+        SaveImportedProfileTestCase{
+            {
+                {NAME_FIRST, ""},
+                {NAME_MIDDLE, ""},
+                {NAME_LAST, ""},
+                {NAME_FULL, "John Thompson Smith"},
+            },
+            {
+                {NAME_FIRST, "Marion"},
+                {NAME_MIDDLE, "Mitchell"},
+                {NAME_LAST, "Morrison"},
+                {NAME_FULL, ""},
+            },
+        },
+
+        // Test that saving an identical profile except for the first address
+        // line results in two profiles being saved.
+        SaveImportedProfileTestCase{ProfileFields(),
+                                    {{ADDRESS_HOME_LINE1, "123 Aquarium St."}}},
+
+        // Test that saving an identical profile except for the second address
+        // line results in two profiles being saved.
+        SaveImportedProfileTestCase{ProfileFields(),
+                                    {{ADDRESS_HOME_LINE2, "unit 7"}}},
+
+        // Tests that saving an identical profile that has a new piece of
+        // information (company name) results in a merge and that the original
+        // empty value gets overwritten by the new information.
+        SaveImportedProfileTestCase{{{COMPANY_NAME, ""}},
+                                    ProfileFields(),
+                                    {{COMPANY_NAME, "Fox"}}},
+
+        // Tests that saving an identical profile except a loss of information
+        // results in a merge but the original value is not overwritten (no
+        // information loss).
+        SaveImportedProfileTestCase{ProfileFields(),
+                                    {{COMPANY_NAME, ""}},
+                                    {{COMPANY_NAME, "Fox"}}},
+
+        // Tests that saving an identical profile except a slightly different
+        // postal code results in a merge with the new value kept.
+        SaveImportedProfileTestCase{{{ADDRESS_HOME_ZIP, "R2C 0A1"}},
+                                    {{ADDRESS_HOME_ZIP, "R2C0A1"}},
+                                    {{ADDRESS_HOME_ZIP, "R2C0A1"}}},
+        SaveImportedProfileTestCase{{{ADDRESS_HOME_ZIP, "R2C0A1"}},
+                                    {{ADDRESS_HOME_ZIP, "R2C 0A1"}},
+                                    {{ADDRESS_HOME_ZIP, "R2C 0A1"}}},
+        SaveImportedProfileTestCase{{{ADDRESS_HOME_ZIP, "r2c 0a1"}},
+                                    {{ADDRESS_HOME_ZIP, "R2C0A1"}},
+                                    {{ADDRESS_HOME_ZIP, "R2C0A1"}}},
+
+        // Tests that saving an identical profile plus a new piece of
+        // information on the address line 2 results in a merge and that the
+        // original empty value gets overwritten by the new information.
+        SaveImportedProfileTestCase{{{ADDRESS_HOME_LINE2, ""}},
+                                    ProfileFields(),
+                                    {{ADDRESS_HOME_LINE2, "unit 5"}}},
+
+        // Tests that saving an identical profile except a loss of information
+        // on the address line 2 results in a merge but that the original
+        // value gets not overwritten (no information loss).
+        SaveImportedProfileTestCase{ProfileFields(),
+                                    {{ADDRESS_HOME_LINE2, ""}},
+                                    {{ADDRESS_HOME_LINE2, "unit 5"}}},
+
+        // Tests that saving an identical except with more punctuation in the
+        // fist address line, while the second is empty, results in a merge
+        // and that the original address gets overwritten.
+        SaveImportedProfileTestCase{
+            {{ADDRESS_HOME_LINE2, ""}},
+            {{ADDRESS_HOME_LINE2, ""}, {ADDRESS_HOME_LINE1, "123, Zoo St."}},
+            {{ADDRESS_HOME_LINE1, "123, Zoo St."}}},
+
+        // Tests that saving an identical profile except with less punctuation
+        // in the fist address line, while the second is empty, results in a
+        // merge and that the longer address is retained.
+        SaveImportedProfileTestCase{
+            {{ADDRESS_HOME_LINE2, ""}, {ADDRESS_HOME_LINE1, "123, Zoo St."}},
+            {{ADDRESS_HOME_LINE2, ""}},
+            {{ADDRESS_HOME_LINE1, "123 Zoo St"}}},
+
+        // Tests that saving an identical profile except additional
+        // punctuation in the two address lines results in a merge and that
+        // the newer address is retained.
+        SaveImportedProfileTestCase{ProfileFields(),
+                                    {{ADDRESS_HOME_LINE1, "123, Zoo St."},
+                                     {ADDRESS_HOME_LINE2, "unit. 5"}},
+                                    {{ADDRESS_HOME_LINE1, "123, Zoo St."},
+                                     {ADDRESS_HOME_LINE2, "unit. 5"}}},
+
+        // Tests that saving an identical profile except less punctuation in
+        // the two address lines results in a merge and that the newer address
+        // is retained.
+        SaveImportedProfileTestCase{{{ADDRESS_HOME_LINE1, "123, Zoo St."},
+                                     {ADDRESS_HOME_LINE2, "unit. 5"}},
+                                    ProfileFields(),
+                                    {{ADDRESS_HOME_LINE1, "123 Zoo St"},
+                                     {ADDRESS_HOME_LINE2, "unit 5"}}},
+
+        // Tests that saving an identical profile with accented characters in
+        // the two address lines results in a merge and that the newer address
+        // is retained.
+        SaveImportedProfileTestCase{ProfileFields(),
+                                    {{ADDRESS_HOME_LINE1, "123 Zôö St"},
+                                     {ADDRESS_HOME_LINE2, "üñìt 5"}},
+                                    {{ADDRESS_HOME_LINE1, "123 Zôö St"},
+                                     {ADDRESS_HOME_LINE2, "üñìt 5"}}},
+
+        // Tests that saving an identical profile without accented characters
+        // in the two address lines results in a merge and that the newer
+        // address is retained.
+        SaveImportedProfileTestCase{{{ADDRESS_HOME_LINE1, "123 Zôö St"},
+                                     {ADDRESS_HOME_LINE2, "üñìt 5"}},
+                                    ProfileFields(),
+                                    {{ADDRESS_HOME_LINE1, "123 Zoo St"},
+                                     {ADDRESS_HOME_LINE2, "unit 5"}}},
+
+        // Tests that saving an identical profile except that the address line
+        // 1 is in the address line 2 results in a merge and that the
+        // multi-lne address is retained.
+        SaveImportedProfileTestCase{ProfileFields(),
+                                    {{ADDRESS_HOME_LINE1, "123 Zoo St, unit 5"},
+                                     {ADDRESS_HOME_LINE2, ""}},
+                                    {{ADDRESS_HOME_LINE1, "123 Zoo St"},
+                                     {ADDRESS_HOME_LINE2, "unit 5"}}},
+
+        // Tests that saving an identical profile except that the address line
+        // 2 contains part of the old address line 1 results in a merge and
+        // that the original address lines of the reference profile get
+        // overwritten.
+        SaveImportedProfileTestCase{{{ADDRESS_HOME_LINE1, "123 Zoo St, unit 5"},
+                                     {ADDRESS_HOME_LINE2, ""}},
+                                    ProfileFields(),
+                                    {{ADDRESS_HOME_LINE1, "123 Zoo St"},
+                                     {ADDRESS_HOME_LINE2, "unit 5"}}},
+
+        // Tests that saving an identical profile except that the state is the
+        // abbreviation instead of the full form results in a merge and that
+        // the original state gets overwritten.
+        SaveImportedProfileTestCase{{{ADDRESS_HOME_STATE, "California"}},
+                                    ProfileFields(),
+                                    {{ADDRESS_HOME_STATE, "CA"}}},
+
+        // Tests that saving an identical profile except that the state is the
+        // full form instead of the abbreviation results in a merge and that
+        // the abbreviated state is retained.
+        SaveImportedProfileTestCase{ProfileFields(),
+                                    {{ADDRESS_HOME_STATE, "California"}},
+                                    {{ADDRESS_HOME_STATE, "CA"}}},
+
+        // Tests that saving and identical profile except that the company
+        // name has different punctuation and case results in a merge and that
+        // the syntax of the new profile replaces the old one.
+        SaveImportedProfileTestCase{{{COMPANY_NAME, "Stark inc"}},
+                                    {{COMPANY_NAME, "Stark Inc."}},
+                                    {{COMPANY_NAME, "Stark Inc."}}}));
+
+// Tests that MergeProfile tries to merge the imported profile into the
+// existing profile in decreasing order of frecency.
+TEST_F(PersonalDataManagerTest, MergeProfile_Frecency) {
+  // Create two very similar profiles except with different company names.
+  std::unique_ptr<AutofillProfile> profile1 = base::MakeUnique<AutofillProfile>(
+      base::GenerateGUID(), "https://www.example.com");
+  test::SetProfileInfo(profile1.get(), "Homer", "Jay", "Simpson",
+                       "homer.simpson@abc.com", "SNP", "742 Evergreen Terrace",
+                       "", "Springfield", "IL", "91601", "US", "12345678910");
+  AutofillProfile* profile2 =
+      new AutofillProfile(base::GenerateGUID(), "https://www.example.com");
+  test::SetProfileInfo(profile2, "Homer", "Jay", "Simpson",
+                       "homer.simpson@abc.com", "Fox", "742 Evergreen Terrace",
+                       "", "Springfield", "IL", "91601", "US", "12345678910");
+
+  // Give the "Fox" profile a bigger frecency score.
+  profile2->set_use_count(15);
+
+  // Create the |existing_profiles| vector.
+  std::vector<std::unique_ptr<AutofillProfile>> existing_profiles;
+  existing_profiles.push_back(std::move(profile1));
+  existing_profiles.push_back(base::WrapUnique(profile2));
+
+  // Create a new imported profile with no company name.
+  AutofillProfile imported_profile(base::GenerateGUID(),
+                                   "https://www.example.com");
+  test::SetProfileInfo(&imported_profile, "Homer", "Jay", "Simpson",
+                       "homer.simpson@abc.com", "", "742 Evergreen Terrace", "",
+                       "Springfield", "IL", "91601", "US", "12345678910");
+
+  // Merge the imported profile into the existing profiles.
+  std::vector<AutofillProfile> profiles;
+  std::string guid = personal_data_->MergeProfile(
+      imported_profile, &existing_profiles, "US-EN", &profiles);
+
+  // The new profile should be merged into the "fox" profile.
+  EXPECT_EQ(profile2->guid(), guid);
+}
+
 // Tests that MergeProfile produces a merged profile with the expected usage
 // statistics.
 // Flaky on TSan, see crbug.com/686226.
 #if defined(THREAD_SANITIZER)
 #define MAYBE_MergeProfile_UsageStats DISABLED_MergeProfile_UsageStats
 #else
 #define MAYBE_MergeProfile_UsageStats MergeProfile_UsageStats
 #endif
 TEST_F(PersonalDataManagerTest, MAYBE_MergeProfile_UsageStats) {
   // Create the test clock and set the time to a specific value.
@@ skipping 1002 matching lines @@
   base::RunLoop().Run();
 
   EXPECT_EQ(1U, personal_data_->GetProfiles().size());
 
   // Enable the profile cleanup now. Otherwise it would be triggered by the
   // calls to AddProfile.
   EnableAutofillProfileCleanup();
   EXPECT_FALSE(personal_data_->ApplyDedupingRoutine());
 }
 
-
 // Tests that ApplyDedupingRoutine is not run a second time on the same major
 // version.
 TEST_F(PersonalDataManagerTest, ApplyDedupingRoutine_OncePerVersion) {
   // Create a profile to dedupe.
   AutofillProfile profile1(base::GenerateGUID(), "https://www.example.com");
   test::SetProfileInfo(&profile1, "Homer", "J", "Simpson",
                        "homer.simpson@abc.com", "", "742. Evergreen Terrace",
                        "", "Springfield", "IL", "91601", "US", "");
 
   // Create a similar profile.
@@ skipping 92 matching lines @@
   test::SetCreditCardInfo(&local_card, "Clyde Barrow",
                           "347666888555" /* American Express */, "04", "2999");
   local_card.set_billing_address_id(kServerAddressId);
   personal_data_->AddCreditCard(local_card);
 
   std::vector<CreditCard> server_cards;
   server_cards.push_back(
       CreditCard(CreditCard::MASKED_SERVER_CARD, "server_card1"));
   test::SetCreditCardInfo(&server_cards.back(), "John Dillinger",
                           "1111" /* Visa */, "01", "2999");
-  server_cards.back().SetTypeForMaskedCard(kVisaCard);
+  server_cards.back().SetNetworkForMaskedCard(kVisaCard);
   server_cards.back().set_billing_address_id(kServerAddressId);
   test::SetServerCreditCards(autofill_table_, server_cards);
 
   // Make sure everything is setup correctly.
   personal_data_->Refresh();
   EXPECT_CALL(personal_data_observer_, OnPersonalDataChanged())
       .WillOnce(QuitMainMessageLoop());
   base::RunLoop().Run();
   EXPECT_EQ(1U, personal_data_->web_profiles().size());
   EXPECT_EQ(1U, personal_data_->GetServerProfiles().size());
@@ skipping 86 matching lines @@
   test::SetCreditCardInfo(&local_card, "Clyde Barrow",
                           "347666888555" /* American Express */, "04", "2999");
   local_card.set_billing_address_id(kServerAddressId);
   personal_data_->AddCreditCard(local_card);
 
   std::vector<CreditCard> server_cards;
   server_cards.push_back(
       CreditCard(CreditCard::MASKED_SERVER_CARD, "server_card1"));
   test::SetCreditCardInfo(&server_cards.back(), "John Dillinger",
                           "1111" /* Visa */, "01", "2999");
-  server_cards.back().SetTypeForMaskedCard(kVisaCard);
+  server_cards.back().SetNetworkForMaskedCard(kVisaCard);
   server_cards.back().set_billing_address_id(kServerAddressId);
   test::SetServerCreditCards(autofill_table_, server_cards);
 
   // Make sure everything is setup correctly.
   personal_data_->Refresh();
   EXPECT_CALL(personal_data_observer_, OnPersonalDataChanged())
       .WillOnce(QuitMainMessageLoop());
   base::RunLoop().Run();
   EXPECT_EQ(1U, personal_data_->web_profiles().size());
   EXPECT_EQ(1U, personal_data_->GetServerProfiles().size());
@@ skipping 151 matching lines @@
   test::SetCreditCardInfo(&local_card, "Clyde Barrow",
                           "347666888555" /* American Express */, "04", "2999");
   local_card.set_billing_address_id(kServerAddressId);
   personal_data_->AddCreditCard(local_card);
 
   std::vector<CreditCard> server_cards;
   server_cards.push_back(
       CreditCard(CreditCard::MASKED_SERVER_CARD, "server_card1"));
   test::SetCreditCardInfo(&server_cards.back(), "John Dillinger",
                           "1111" /* Visa */, "01", "2999");
-  server_cards.back().SetTypeForMaskedCard(kVisaCard);
+  server_cards.back().SetNetworkForMaskedCard(kVisaCard);
   server_cards.back().set_billing_address_id(kServerAddressId2);
   test::SetServerCreditCards(autofill_table_, server_cards);
 
   // Make sure everything is setup correctly.
   personal_data_->Refresh();
   EXPECT_CALL(personal_data_observer_, OnPersonalDataChanged())
       .WillOnce(QuitMainMessageLoop());
   base::RunLoop().Run();
   EXPECT_EQ(1U, personal_data_->web_profiles().size());
   EXPECT_EQ(2U, personal_data_->GetServerProfiles().size());
@@ skipping 45 matching lines @@
   EXPECT_EQ(profiles[0]->guid(),
             personal_data_->GetCreditCards()[0]->billing_address_id());
   EXPECT_EQ(profiles[0]->guid(),
             personal_data_->GetCreditCards()[1]->billing_address_id());
 }
 
 // Tests a new server card's billing address is updated propely even if the
 // address was already converted in the past.
 TEST_F(
     PersonalDataManagerTest,
-    ConvertWalletAddressesAndUpdateWalletCards_NewCard_AddressAlreadyConverted) {
+    ConvertWalletAddressesAndUpdateWalletCards_NewCrd_AddressAlreadyConverted) {
   ///////////////////////////////////////////////////////////////////////
   // Setup.
   ///////////////////////////////////////////////////////////////////////
   // Go through the conversion process for a server address and card. Then add
   // a new server card that refers to the already converted server address as
   // its billing address.
   EnableWalletCardImport();
   base::HistogramTester histogram_tester;
   const std::string kServerAddressId("server_address1");
 
   // Add a server profile.
   std::vector<AutofillProfile> GetServerProfiles;
   GetServerProfiles.push_back(
       AutofillProfile(AutofillProfile::SERVER_PROFILE, kServerAddressId));
   test::SetProfileInfo(&GetServerProfiles.back(), "John", "", "Doe", "", "Fox",
                        "1212 Center", "Bld. 5", "Orlando", "FL", "", "US", "");
   // Wallet only provides a full name, so the above first and last names
   // will be ignored when the profile is written to the DB.
   GetServerProfiles.back().SetRawInfo(NAME_FULL, ASCIIToUTF16("John Doe"));
   GetServerProfiles.back().set_use_count(100);
   autofill_table_->SetServerProfiles(GetServerProfiles);
 
   // Add a server card that have the server address as billing address.
   std::vector<CreditCard> server_cards;
   server_cards.push_back(
       CreditCard(CreditCard::MASKED_SERVER_CARD, "server_card1"));
   test::SetCreditCardInfo(&server_cards.back(), "John Dillinger",
                           "1111" /* Visa */, "01", "2999");
-  server_cards.back().SetTypeForMaskedCard(kVisaCard);
+  server_cards.back().SetNetworkForMaskedCard(kVisaCard);
   server_cards.back().set_billing_address_id(kServerAddressId);
   test::SetServerCreditCards(autofill_table_, server_cards);
 
   // Make sure everything is setup correctly.
   personal_data_->Refresh();
   EXPECT_CALL(personal_data_observer_, OnPersonalDataChanged())
       .WillOnce(QuitMainMessageLoop());
   base::RunLoop().Run();
   EXPECT_EQ(1U, personal_data_->GetServerProfiles().size());
   EXPECT_EQ(1U, personal_data_->GetCreditCards().size());
@@ skipping 17 matching lines @@
       personal_data_->GetProfilesToSuggest();
   ASSERT_EQ(1U, profiles.size());
   EXPECT_EQ(profiles[0]->guid(),
             personal_data_->GetCreditCards()[0]->billing_address_id());
 
   // Add a new server card that has the same billing address as the old one.
   server_cards.push_back(
       CreditCard(CreditCard::MASKED_SERVER_CARD, "server_card2"));
   test::SetCreditCardInfo(&server_cards.back(), "John Dillinger",
                           "1112" /* Visa */, "01", "2888");
-  server_cards.back().SetTypeForMaskedCard(kVisaCard);
+  server_cards.back().SetNetworkForMaskedCard(kVisaCard);
   server_cards.back().set_billing_address_id(kServerAddressId);
   test::SetServerCreditCards(autofill_table_, server_cards);
 
   // Make sure everything is setup correctly.
   personal_data_->Refresh();
   EXPECT_CALL(personal_data_observer_, OnPersonalDataChanged())
       .WillOnce(QuitMainMessageLoop());
   base::RunLoop().Run();
   EXPECT_EQ(1U, personal_data_->web_profiles().size());
   EXPECT_EQ(2U, personal_data_->GetCreditCards().size());
@@ skipping 23 matching lines @@
   // to the converted address.
   EXPECT_EQ(profiles[0]->guid(),
             personal_data_->GetCreditCards()[0]->billing_address_id());
   // Make sure that the billing address id of the new server card still refers
   // to the converted address.
   EXPECT_EQ(profiles[0]->guid(),
             personal_data_->GetCreditCards()[1]->billing_address_id());
 }
 
 }  // namespace autofill