Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(605)

Issue 2844443002: Remove warning about std::map::emplace (Closed)

Created:
3 years, 8 months ago by jdoerrie
Modified:
3 years, 8 months ago
Reviewers:
danakj, jbroman
CC:
chromium-reviews, danakj+watch_chromium.org, jbroman+cpp_chromium.org, Peter Kasting, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove warning about std::map::emplace crbug.com/701894 updated the Linux sysroot, making more C++11 features available. These features include std::map::emplace, making the corresponding warning the styleguide obsolete. R=danakj@chromium.org,jbroman@chromium.org CC=pkasting@chromium.org BUG=NONE Review-Url: https://codereview.chromium.org/2844443002 Cr-Commit-Position: refs/heads/master@{#466987} Committed: https://chromium.googlesource.com/chromium/src/+/16a737caee10754926da7cc924c3233d519df814

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M base/containers/mru_cache.h View 1 chunk +2 lines, -2 lines 1 comment Download
M styleguide/c++/c++11.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
jdoerrie
Dear both, please review. https://codereview.chromium.org/2844443002/diff/1/base/containers/mru_cache.h File base/containers/mru_cache.h (right): https://codereview.chromium.org/2844443002/diff/1/base/containers/mru_cache.h#newcode101 base/containers/mru_cache.h:101: index_.emplace(key, ordering_.begin()); While |index_|'s type ...
3 years, 8 months ago (2017-04-25 11:33:47 UTC) #5
danakj
LGTM thanks
3 years, 8 months ago (2017-04-25 13:52:06 UTC) #6
jbroman
lgtm
3 years, 8 months ago (2017-04-25 14:25:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2844443002/1
3 years, 8 months ago (2017-04-25 14:29:30 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-25 14:34:12 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/16a737caee10754926da7cc924c3...

Powered by Google App Engine
This is Rietveld 408576698