Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2844413004: Switch SupportsUserData uses to use unique_ptr. (Closed)

Created:
3 years, 7 months ago by Avi (use Gerrit)
Modified:
3 years, 7 months ago
Reviewers:
alokp
CC:
chromium-reviews, alokp+watch_chromium.org, lcwu+watch_chromium.org, halliwell+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch SupportsUserData uses to use unique_ptr. The interface taking a raw pointer is deprecated and being removed. BUG=690937 Review-Url: https://codereview.chromium.org/2844413004 Cr-Commit-Position: refs/heads/master@{#468005} Committed: https://chromium.googlesource.com/chromium/src/+/d9ba67a80e774e24203bde94cb41add81567af4b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M chromecast/browser/android/cast_web_contents_activity.h View 2 chunks +3 lines, -2 lines 0 comments Download
M chromecast/browser/android/cast_web_contents_activity.cc View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
Avi (use Gerrit)
3 years, 7 months ago (2017-04-28 04:35:35 UTC) #4
alokp
lgtm
3 years, 7 months ago (2017-04-28 12:45:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2844413004/1
3 years, 7 months ago (2017-04-28 15:22:29 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 15:28:15 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d9ba67a80e774e24203bde94cb41...

Powered by Google App Engine
This is Rietveld 408576698