Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 2844413002: Guard against files that are not being analyzed (issue 29493) (Closed)

Created:
3 years, 7 months ago by Brian Wilkerson
Modified:
3 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Guard against files that are not being analyzed (issue 29493) R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/51dd0538ea5892cae5f954f044d7097266b4b971

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -23 lines) Patch
M pkg/analysis_server/lib/src/domain_completion.dart View 4 chunks +16 lines, -14 lines 0 comments Download
M pkg/analysis_server/lib/src/edit/edit_domain.dart View 3 chunks +17 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
3 years, 7 months ago (2017-04-27 21:04:01 UTC) #2
scheglov
LGTM
3 years, 7 months ago (2017-04-27 21:09:32 UTC) #3
Brian Wilkerson
3 years, 7 months ago (2017-04-27 21:10:11 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
51dd0538ea5892cae5f954f044d7097266b4b971 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698