Guard against files that are not being analyzed (issue 29493)

pkg/analysis_server/lib/src/edit/edit_domain.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:async';
 
 import 'package:analysis_server/plugin/edit/assist/assist_core.dart';
 import 'package:analysis_server/plugin/edit/assist/assist_dart.dart';
 import 'package:analysis_server/plugin/edit/fix/fix_core.dart';
 import 'package:analysis_server/plugin/edit/fix/fix_dart.dart';
@@ skipping 134 matching lines @@
     EditGetAssistsParams params = new EditGetAssistsParams.fromRequest(request);
     String file = params.file;
     int offset = params.offset;
     int length = params.length;
 
     List<SourceChange> changes = <SourceChange>[];
     if (server.options.enableNewAnalysisDriver) {
       //
       // Allow plugins to start computing assists.
       //
-      AnalysisDriver driver = server.getAnalysisDriver(file);
+      Map<PluginInfo, Future<plugin.Response>> pluginFutures;
       plugin.EditGetAssistsParams requestParams =
           new plugin.EditGetAssistsParams(file, offset, length);
-      Map<PluginInfo, Future<plugin.Response>> pluginFutures = server
-          .pluginManager
-          .broadcastRequest(requestParams, contextRoot: driver.contextRoot);
+      AnalysisDriver driver = server.getAnalysisDriver(file);
+      if (driver == null) {
+        pluginFutures = <PluginInfo, Future<plugin.Response>>{};
+      } else {
+        pluginFutures = server.pluginManager
+            .broadcastRequest(requestParams, contextRoot: driver.contextRoot);
+      }
       //
       // Compute fixes associated with server-generated errors.
       //
       AnalysisResult result = await server.getAnalysisResult(file);
       if (result != null) {
         CompilationUnit unit = result.unit;
         CompilationUnitElement compilationUnitElement =
             resolutionMap.elementDeclaredByCompilationUnit(unit);
         DartAssistContext dartAssistContext = new _DartAssistContextForValues(
             compilationUnitElement.source,
@@ skipping 48 matching lines @@
   Future getFixes(Request request) async {
     var params = new EditGetFixesParams.fromRequest(request);
     String file = params.file;
     int offset = params.offset;
 
     List<AnalysisErrorFixes> errorFixesList = <AnalysisErrorFixes>[];
     if (server.options.enableNewAnalysisDriver) {
       //
       // Allow plugins to start computing fixes.
       //
-      AnalysisDriver driver = server.getAnalysisDriver(file);
+      Map<PluginInfo, Future<plugin.Response>> pluginFutures;
       plugin.EditGetFixesParams requestParams =
           new plugin.EditGetFixesParams(file, offset);
-      Map<PluginInfo, Future<plugin.Response>> pluginFutures = server
-          .pluginManager
-          .broadcastRequest(requestParams, contextRoot: driver.contextRoot);
+      AnalysisDriver driver = server.getAnalysisDriver(file);
+      if (driver == null) {
+        pluginFutures = <PluginInfo, Future<plugin.Response>>{};
+      } else {
+        pluginFutures = server.pluginManager
+            .broadcastRequest(requestParams, contextRoot: driver.contextRoot);
+      }
       //
       // Compute fixes associated with server-generated errors.
       //
       AnalysisResult result = await server.getAnalysisResult(file);
       if (result != null) {
         CompilationUnit unit = result.unit;
         LineInfo lineInfo = result.lineInfo;
         int requestLine = lineInfo.getLocation(offset).lineNumber;
         for (engine.AnalysisError error in result.errors) {
           int errorLine = lineInfo.getLocation(error.offset).lineNumber;
@@ skipping 195 matching lines @@
       server.sendResponse(new Response.sortMembersInvalidFile(request));
       return;
     }
     // Prepare the file information.
     int fileStamp;
     String code;
     CompilationUnit unit;
     List<engine.AnalysisError> errors;
     if (server.options.enableNewAnalysisDriver) {
       AnalysisDriver driver = server.getAnalysisDriver(file);
-      ParseResult result = await driver.parseFile(file);
+      ParseResult result = await driver?.parseFile(file);
       if (result == null) {
         server.sendResponse(new Response.fileNotAnalyzed(request, file));
         return;
       }
       fileStamp = -1;
       code = result.content;
       unit = result.unit;
       errors = result.errors;
     } else {
       // prepare location
@@ skipping 609 matching lines @@
     }
     return new RefactoringStatus();
   }
 }
 
 /**
  * [_RefactoringManager] throws instances of this class internally to stop
  * processing in a manager that was reset.
  */
 class _ResetError {}