Add 404 check to BTF Litepage test

Add 404 check to BTF Litepage test

Using a local proxy instance with the associated bug, the failed
response gave a 404 status. This check differentiates between the bug
and not.

BUG=715644
Review-Url: https://codereview.chromium.org/2844403002
Cr-Commit-Position: refs/heads/master@{#468106}
Committed: https://chromium.googlesource.com/chromium/src/+/0a505cbed8bb3d14d8ad5b7631c5367e45632711

[Robert Ogden, 2017-04-27 20:53:31]

Description was changed from

==========
Add 404 check to BTF Litepage test

Using a local proxy instance with the associated bug, the failed
response gave a 404 status. This check differentiates between the bug
and not.

BUG=715644
==========

to

==========
Add 404 check to BTF Litepage test

Using a local proxy instance with the associated bug, the failed
response gave a 404 status. This check differentiates between the bug
and not.

BUG=715644
==========

[Robert Ogden, 2017-04-27 20:53:31]

robertogden@chromium.org changed reviewers:
+ ryansturm@chromium.org

[Robert Ogden, 2017-04-27 20:54:05]

Ryan, please take a look. I ran the test against a buggy proxy version and
discovered we need this check as well

[RyanSturm, 2017-04-27 21:48:32]

Is the only change from the other CL:

 self.assertNotEqual(404, response.status)

If so, I'd consider changing it to check if the status is 200.

[Robert Ogden, 2017-04-27 21:56:19]

On 2017/04/27 21:48:32, Ryan Sturm wrote:
> Is the only change from the other CL:
> 
>  self.assertNotEqual(404, response.status)
> 
> If so, I'd consider changing it to check if the status is 200.

Done as discussed offline

[RyanSturm, 2017-04-27 22:07:16]

lgtm

[Robert Ogden, 2017-04-28 15:26:32]

Added a check that scrollHeight increases per Tom's suggestion on previous CL
(https://codereview.chromium.org/2852533002/). 

Ryan, please take a look and make sure it's still good.

[RyanSturm, 2017-04-28 19:47:32]

lgtm

[Robert Ogden, 2017-04-28 19:57:40]

The CQ bit was checked by robertogden@chromium.org

[commit-bot: I haz the power, 2017-04-28 19:58:33]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 20:13:24]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493409460079290,
"parent_rev": "42f79db5eabcab9856321dcbdec9953c156784a6", "commit_rev":
"0a505cbed8bb3d14d8ad5b7631c5367e45632711"}

[commit-bot: I haz the power, 2017-04-28 20:13:37]

Description was changed from

==========
Add 404 check to BTF Litepage test

Using a local proxy instance with the associated bug, the failed
response gave a 404 status. This check differentiates between the bug
and not.

BUG=715644
==========

to

==========
Add 404 check to BTF Litepage test

Using a local proxy instance with the associated bug, the failed
response gave a 404 status. This check differentiates between the bug
and not.

BUG=715644

Review-Url: https://codereview.chromium.org/2844403002
Cr-Commit-Position: refs/heads/master@{#468106}
Committed:
https://chromium.googlesource.com/chromium/src/+/0a505cbed8bb3d14d8ad5b7631c5...
==========

[commit-bot: I haz the power, 2017-04-28 20:13:38]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/0a505cbed8bb3d14d8ad5b7631c5...