Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issue 2844383007: Add HCreateBox (Closed)

Created:
3 years, 7 months ago by sra1
Modified:
3 years, 7 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add HCreateBox Remove the JS template hack. Later we can add initialized properties. BUG= R=efortuna@google.com Committed: https://github.com/dart-lang/sdk/commit/586f4a9ec92700ebe5d4bad37b9275cc9c29b830

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -5 lines) Patch
M pkg/compiler/lib/src/ssa/codegen.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/ssa/locals_handler.dart View 1 chunk +1 line, -5 lines 0 comments Download
M pkg/compiler/lib/src/ssa/nodes.dart View 3 chunks +13 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/ssa/ssa_tracer.dart View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
sra1
3 years, 7 months ago (2017-04-29 18:17:32 UTC) #2
Emily Fortuna
lgtm
3 years, 7 months ago (2017-05-01 22:50:12 UTC) #5
sra1
3 years, 7 months ago (2017-05-01 22:51:21 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:20001) manually as
586f4a9ec92700ebe5d4bad37b9275cc9c29b830 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698