Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(770)

Unified Diff: pkg/compiler/lib/src/ssa/locals_handler.dart

Issue 2844383007: Add HCreateBox (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/ssa/codegen.dart ('k') | pkg/compiler/lib/src/ssa/nodes.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/ssa/locals_handler.dart
diff --git a/pkg/compiler/lib/src/ssa/locals_handler.dart b/pkg/compiler/lib/src/ssa/locals_handler.dart
index 1755a02612e8848f9ff9419d930b4f2c6c55cadb..d06750fdc4ee2a9998daa415ec29e97b3b92c115 100644
--- a/pkg/compiler/lib/src/ssa/locals_handler.dart
+++ b/pkg/compiler/lib/src/ssa/locals_handler.dart
@@ -126,11 +126,7 @@ class LocalsHandler {
}
HInstruction createBox() {
- // TODO(floitsch): Clean up this hack. Should we create a box-object by
- // just creating an empty object literal?
- HInstruction box = new HForeignCode(
- js.js.parseForeignJS('{}'), commonMasks.nonNullType, <HInstruction>[],
- nativeBehavior: native.NativeBehavior.PURE_ALLOCATION);
+ HInstruction box = new HCreateBox(commonMasks.nonNullType);
builder.add(box);
return box;
}
« no previous file with comments | « pkg/compiler/lib/src/ssa/codegen.dart ('k') | pkg/compiler/lib/src/ssa/nodes.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698