Issue 2844363005: Fix use-after-free in MessageListView.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2844363005: Fix use-after-free in MessageListView. (Closed)

Created:
3 years, 7 months ago by yhanada

Modified:
3 years, 7 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/branch-heads/3029

Project:
chromium

Visibility:
Public.

Fix use-after-free in MessageListView. This is caused by calling RemoveNotification() while 'Clear All' operation is in progress. A MessageView could be deleted twice. BUG=713983 Review-Url: https://codereview.chromium.org/2836023002 Cr-Commit-Position: refs/heads/master@{#467248} (cherry picked from commit 4518695792a1cad0afdb80bbe0e3ea1850f310c1) Review-Url: https://codereview.chromium.org/2844363005 . Cr-Commit-Position: refs/branch-heads/3029@{#778} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/ef773bb9e3af631d42213cd3d8eedb7dd8c3678e

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+37 lines, -5 lines)			Patch
M	ui/message_center/views/message_center_view.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/message_center/views/message_center_view.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	ui/message_center/views/message_list_view.cc	View	5 chunks	+33 lines, -1 line	0 comments	Download

Total messages: 2 (1 generated)

yhanada

3 years, 7 months ago (2017-04-28 12:31:46 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
ef773bb9e3af631d42213cd3d8eedb7dd8c3678e.