Use net::HttpContentTypeDisposition in blink

Use net::HttpContentTypeDisposition in blink

This CL replaces blink::GetContentDispositionType implementation by
net::HttpContentTypeDisposition. There are some behavior differences between
these two implementations, but because the former is used only to see if
the disposition type is attachement, there is only one difference that matters.
The former returns kAttachement for empty content disposition type (e.g.,
";foo"), but the latter returns kInline. It looks the former is intended to
return kNone, but it returns kAttachment due to misuse of confusing 
WTFString::Split interface.

Hence this CL adds IsContentDispositionAttachment and makes it return false
when a value with an empty content disposition type is given.

BUG=696967
Review-Url: https://codereview.chromium.org/2844353003
Cr-Commit-Position: refs/heads/master@{#467977}
Committed: https://chromium.googlesource.com/chromium/src/+/a397826c00c0873475842d7f9d9d03038015dcdf

[yhirano, 2017-04-28 08:55:42]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 08:55:53]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhirano, 2017-04-28 09:05:00]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 09:05:12]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhirano, 2017-04-28 09:05:18]

Description was changed from

==========
Use net::HTTPContentTypeDisposition in blink

This CL replaces blink::GetContentDispositionType impelementation by
net::HTTPContentTypeDisposition. There are some behavior differences between
these two implementations, but because the former is used only to see if
the disposition type is attachement, there is only one difference that matters.
The former returns kAttachement for empty content disposition type (e.g.,
";foo"), but the latter returns kInline. It looks the former is intended to
return kNone, but it returns kAttachment due to confusing WTFString::Split
interface.

Hence This CL adds IsContentDispositionTypeAttachment and makes it returns
false when a value with an empty content disposition type is given.

BUG=696967
==========

to

==========
Use net::HTTPContentTypeDisposition in blink

This CL replaces blink::GetContentDispositionType impelementation by
net::HTTPContentTypeDisposition. There are some behavior differences between
these two implementations, but because the former is used only to see if
the disposition type is attachement, there is only one difference that matters.
The former returns kAttachement for empty content disposition type (e.g.,
";foo"), but the latter returns kInline. It looks the former is intended to
return kNone, but it returns kAttachment due to confusing WTFString::Split
interface.

Hence This CL adds IsContentDispositionAttachment and makes it returns false
when a value with an empty content disposition type is given.

BUG=696967
==========

[yhirano, 2017-04-28 09:07:00]

Description was changed from

==========
Use net::HTTPContentTypeDisposition in blink

This CL replaces blink::GetContentDispositionType impelementation by
net::HTTPContentTypeDisposition. There are some behavior differences between
these two implementations, but because the former is used only to see if
the disposition type is attachement, there is only one difference that matters.
The former returns kAttachement for empty content disposition type (e.g.,
";foo"), but the latter returns kInline. It looks the former is intended to
return kNone, but it returns kAttachment due to confusing WTFString::Split
interface.

Hence This CL adds IsContentDispositionAttachment and makes it returns false
when a value with an empty content disposition type is given.

BUG=696967
==========

to

==========
Use net::HTTPContentTypeDisposition in blink

This CL replaces blink::GetContentDispositionType implementation by
net::HTTPContentTypeDisposition. There are some behavior differences between
these two implementations, but because the former is used only to see if
the disposition type is attachement, there is only one difference that matters.
The former returns kAttachement for empty content disposition type (e.g.,
";foo"), but the latter returns kInline. It looks the former is intended to
return kNone, but it returns kAttachment due to misuse of confusing 
WTFString::Split interface.

Hence This CL adds IsContentDispositionAttachment and makes it returns false
when a value with an empty content disposition type is given.

BUG=696967
==========

[yhirano, 2017-04-28 09:07:00]

yhirano@chromium.org changed reviewers:
+ kinuko@chromium.org

[yhirano, 2017-04-28 09:07:14]

yhirano@chromium.org changed reviewers:
- kinuko@chromium.org

[yhirano, 2017-04-28 09:08:49]

Description was changed from

==========
Use net::HTTPContentTypeDisposition in blink

This CL replaces blink::GetContentDispositionType implementation by
net::HTTPContentTypeDisposition. There are some behavior differences between
these two implementations, but because the former is used only to see if
the disposition type is attachement, there is only one difference that matters.
The former returns kAttachement for empty content disposition type (e.g.,
";foo"), but the latter returns kInline. It looks the former is intended to
return kNone, but it returns kAttachment due to misuse of confusing 
WTFString::Split interface.

Hence This CL adds IsContentDispositionAttachment and makes it returns false
when a value with an empty content disposition type is given.

BUG=696967
==========

to

==========
Use net::HttpContentTypeDisposition in blink

This CL replaces blink::GetContentDispositionType implementation by
net::HttpContentTypeDisposition. There are some behavior differences between
these two implementations, but because the former is used only to see if
the disposition type is attachement, there is only one difference that matters.
The former returns kAttachement for empty content disposition type (e.g.,
";foo"), but the latter returns kInline. It looks the former is intended to
return kNone, but it returns kAttachment due to misuse of confusing 
WTFString::Split interface.

Hence This CL adds IsContentDispositionAttachment and makes it returns false
when a value with an empty content disposition type is given.

BUG=696967
==========

[yhirano, 2017-04-28 09:08:58]

Description was changed from

==========
Use net::HttpContentTypeDisposition in blink

This CL replaces blink::GetContentDispositionType implementation by
net::HttpContentTypeDisposition. There are some behavior differences between
these two implementations, but because the former is used only to see if
the disposition type is attachement, there is only one difference that matters.
The former returns kAttachement for empty content disposition type (e.g.,
";foo"), but the latter returns kInline. It looks the former is intended to
return kNone, but it returns kAttachment due to misuse of confusing 
WTFString::Split interface.

Hence This CL adds IsContentDispositionAttachment and makes it returns false
when a value with an empty content disposition type is given.

BUG=696967
==========

to

==========
Use net::HttpContentTypeDisposition in blink

This CL replaces blink::GetContentDispositionType implementation by
net::HttpContentTypeDisposition. There are some behavior differences between
these two implementations, but because the former is used only to see if
the disposition type is attachement, there is only one difference that matters.
The former returns kAttachement for empty content disposition type (e.g.,
";foo"), but the latter returns kInline. It looks the former is intended to
return kNone, but it returns kAttachment due to misuse of confusing 
WTFString::Split interface.

Hence This CL adds IsContentDispositionAttachment and makes it return false
when a value with an empty content disposition type is given.

BUG=696967
==========

[yhirano, 2017-04-28 10:34:56]

yhirano@chromium.org changed reviewers:
+ kinuko@chromium.org

[commit-bot: I haz the power, 2017-04-28 10:48:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 10:48:32]

Dry run: This issue passed the CQ dry run.

[kinuko, 2017-04-28 13:18:27]

lgtm

[yhirano, 2017-04-28 13:26:20]

Description was changed from

==========
Use net::HttpContentTypeDisposition in blink

This CL replaces blink::GetContentDispositionType implementation by
net::HttpContentTypeDisposition. There are some behavior differences between
these two implementations, but because the former is used only to see if
the disposition type is attachement, there is only one difference that matters.
The former returns kAttachement for empty content disposition type (e.g.,
";foo"), but the latter returns kInline. It looks the former is intended to
return kNone, but it returns kAttachment due to misuse of confusing 
WTFString::Split interface.

Hence This CL adds IsContentDispositionAttachment and makes it return false
when a value with an empty content disposition type is given.

BUG=696967
==========

to

==========
Use net::HttpContentTypeDisposition in blink

This CL replaces blink::GetContentDispositionType implementation by
net::HttpContentTypeDisposition. There are some behavior differences between
these two implementations, but because the former is used only to see if
the disposition type is attachement, there is only one difference that matters.
The former returns kAttachement for empty content disposition type (e.g.,
";foo"), but the latter returns kInline. It looks the former is intended to
return kNone, but it returns kAttachment due to misuse of confusing 
WTFString::Split interface.

Hence this CL adds IsContentDispositionAttachment and makes it return false
when a value with an empty content disposition type is given.

BUG=696967
==========

[yhirano, 2017-04-28 13:26:29]

The CQ bit was checked by yhirano@chromium.org

[commit-bot: I haz the power, 2017-04-28 13:26:47]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 13:30:50]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493385989225190,
"parent_rev": "93f4a8770134544036f7d32613df9cc1c0095ca2", "commit_rev":
"a397826c00c0873475842d7f9d9d03038015dcdf"}

[commit-bot: I haz the power, 2017-04-28 13:30:58]

Description was changed from

==========
Use net::HttpContentTypeDisposition in blink

This CL replaces blink::GetContentDispositionType implementation by
net::HttpContentTypeDisposition. There are some behavior differences between
these two implementations, but because the former is used only to see if
the disposition type is attachement, there is only one difference that matters.
The former returns kAttachement for empty content disposition type (e.g.,
";foo"), but the latter returns kInline. It looks the former is intended to
return kNone, but it returns kAttachment due to misuse of confusing 
WTFString::Split interface.

Hence this CL adds IsContentDispositionAttachment and makes it return false
when a value with an empty content disposition type is given.

BUG=696967
==========

to

==========
Use net::HttpContentTypeDisposition in blink

This CL replaces blink::GetContentDispositionType implementation by
net::HttpContentTypeDisposition. There are some behavior differences between
these two implementations, but because the former is used only to see if
the disposition type is attachement, there is only one difference that matters.
The former returns kAttachement for empty content disposition type (e.g.,
";foo"), but the latter returns kInline. It looks the former is intended to
return kNone, but it returns kAttachment due to misuse of confusing 
WTFString::Split interface.

Hence this CL adds IsContentDispositionAttachment and makes it return false
when a value with an empty content disposition type is given.

BUG=696967

Review-Url: https://codereview.chromium.org/2844353003
Cr-Commit-Position: refs/heads/master@{#467977}
Committed:
https://chromium.googlesource.com/chromium/src/+/a397826c00c0873475842d7f9d9d...
==========

[commit-bot: I haz the power, 2017-04-28 13:30:59]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a397826c00c0873475842d7f9d9d...