chrome/android/java/res/layout/account_signin_view.xml - Issue 2844323003: 🔍 Add first run dialog for selecting search engine

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/res/layout/account_signin_view.xml

Issue 2844323003: 🔍 Add first run dialog for selecting search engine (Closed)

Patch Set: 🔍 Add First Run dialog for selecting search engine Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/android/java/res/layout/account_signin_view.xml

diff --git a/chrome/android/java/res/layout/account_signin_view.xml b/chrome/android/java/res/layout/account_signin_view.xml

index 4a72c233ea96edb1c5057aec4704470ec24099c9..3e859ddfa50373645c352a33e6c246d70bce9518 100644

--- a/chrome/android/java/res/layout/account_signin_view.xml

+++ b/chrome/android/java/res/layout/account_signin_view.xml

@@ -45,11 +45,7 @@

android:textSize="@dimen/fre_title_text_size"

android:text="@string/sign_in_to_chrome"/>

- <View

- android:layout_width="match_parent"

- android:layout_height="1dp"

- android:background="@color/signin_border_line_color"

Ted C 2017/05/04 00:42:43 can we remove this color from the colors.xml file?

gone 2017/05/04 01:25:36 Nope. It's used a few times for other dividers be

- android:alpha="0.08"/>

+ <View style="@style/Divider"/>

<TextView

android:id="@+id/signin_choice_description"

« no previous file with comments | « no previous file | chrome/android/java/res/layout/default_search_engine_first_run_fragment.xml » ('j') | no next file with comments »