Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Side by Side Diff: chrome/android/java/res/layout/account_signin_view.xml

Issue 2844323003: 🔍 Add first run dialog for selecting search engine (Closed)
Patch Set: 🔍 Add First Run dialog for selecting search engine Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/android/java/res/layout/default_search_engine_first_run_fragment.xml » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <?xml version="1.0" encoding="utf-8"?> 1 <?xml version="1.0" encoding="utf-8"?>
2 <!-- Copyright 2015 The Chromium Authors. All rights reserved. 2 <!-- Copyright 2015 The Chromium Authors. All rights reserved.
3 3
4 Use of this source code is governed by a BSD-style license that can be 4 Use of this source code is governed by a BSD-style license that can be
5 found in the LICENSE file. 5 found in the LICENSE file.
6 --> 6 -->
7 <org.chromium.chrome.browser.signin.AccountSigninView 7 <org.chromium.chrome.browser.signin.AccountSigninView
8 xmlns:android="http://schemas.android.com/apk/res/android" 8 xmlns:android="http://schemas.android.com/apk/res/android"
9 xmlns:chrome="http://schemas.android.com/apk/res-auto" 9 xmlns:chrome="http://schemas.android.com/apk/res-auto"
10 android:layout_width="match_parent" 10 android:layout_width="match_parent"
(...skipping 27 matching lines...) Expand all
38 android:layout_height="wrap_content" 38 android:layout_height="wrap_content"
39 android:gravity="bottom" 39 android:gravity="bottom"
40 android:paddingStart="@dimen/signin_chooser_padding" 40 android:paddingStart="@dimen/signin_chooser_padding"
41 android:paddingEnd="@dimen/signin_chooser_padding" 41 android:paddingEnd="@dimen/signin_chooser_padding"
42 android:paddingBottom="@dimen/signin_chooser_padding" 42 android:paddingBottom="@dimen/signin_chooser_padding"
43 android:background="@color/signin_head_background" 43 android:background="@color/signin_head_background"
44 android:textColor="@color/default_text_color" 44 android:textColor="@color/default_text_color"
45 android:textSize="@dimen/fre_title_text_size" 45 android:textSize="@dimen/fre_title_text_size"
46 android:text="@string/sign_in_to_chrome"/> 46 android:text="@string/sign_in_to_chrome"/>
47 47
48 <View 48 <View style="@style/Divider"/>
49 android:layout_width="match_parent"
50 android:layout_height="1dp"
51 android:background="@color/signin_border_line_color"
Ted C 2017/05/04 00:42:43 can we remove this color from the colors.xml file?
gone 2017/05/04 01:25:36 Nope. It's used a few times for other dividers be
52 android:alpha="0.08"/>
53 49
54 <TextView 50 <TextView
55 android:id="@+id/signin_choice_description" 51 android:id="@+id/signin_choice_description"
56 android:layout_width="wrap_content" 52 android:layout_width="wrap_content"
57 android:layout_height="wrap_content" 53 android:layout_height="wrap_content"
58 android:padding="@dimen/signin_chooser_padding" 54 android:padding="@dimen/signin_chooser_padding"
59 android:lineSpacingMultiplier="1.4" 55 android:lineSpacingMultiplier="1.4"
60 android:text="@string/signin_account_choice_description" 56 android:text="@string/signin_account_choice_description"
61 android:textColor="@color/default_text_color" 57 android:textColor="@color/default_text_color"
62 android:textSize="@dimen/fre_normal_text_size"/> 58 android:textSize="@dimen/fre_normal_text_size"/>
(...skipping 210 matching lines...) Expand 10 before | Expand all | Expand 10 after
273 269
274 <View 270 <View
275 android:id="@+id/positive_button_end_padding" 271 android:id="@+id/positive_button_end_padding"
276 android:layout_width="0dp" 272 android:layout_width="0dp"
277 android:layout_height="0dp" 273 android:layout_height="0dp"
278 android:layout_weight="1" 274 android:layout_weight="1"
279 android:visibility="gone"/> 275 android:visibility="gone"/>
280 </LinearLayout> 276 </LinearLayout>
281 277
282 </org.chromium.chrome.browser.signin.AccountSigninView> 278 </org.chromium.chrome.browser.signin.AccountSigninView>
OLDNEW
« no previous file with comments | « no previous file | chrome/android/java/res/layout/default_search_engine_first_run_fragment.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698