Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 2844293002: [Payments] Handle clicking back on the CVC unmask dialog (Closed)

Created:
3 years, 7 months ago by Mathieu
Modified:
3 years, 7 months ago
Reviewers:
anthonyvd
CC:
chromium-reviews, gogerald+paymentswatch_chromium.org, mahmadi+paymentswatch_chromium.org, rouslan+payments_chromium.org, sebsg+paymentswatch_chromium.org, tfarina
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Payments] Handle clicking back on the CVC unmask dialog Was previously crashing because the AutofillPaymentInstrument delegate was not being reset properly on back navigation. Now it is. BUG=715093 TEST=browser_tests Review-Url: https://codereview.chromium.org/2844293002 Cr-Commit-Position: refs/heads/master@{#467747} Committed: https://chromium.googlesource.com/chromium/src/+/f72420b280a531f5db4d636b8f1ad57cf20c9895

Patch Set 1 #

Patch Set 2 : Test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -6 lines) Patch
M chrome/browser/ui/views/payments/cvc_unmask_view_controller.cc View 2 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/ui/views/payments/cvc_unmask_view_controller_browsertest.cc View 1 2 chunks +23 lines, -4 lines 0 comments Download
M components/payments/core/autofill_payment_instrument.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
Mathieu
Anthony, PTAL
3 years, 7 months ago (2017-04-27 14:21:48 UTC) #3
anthonyvd
lgtm
3 years, 7 months ago (2017-04-27 17:24:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2844293002/20001
3 years, 7 months ago (2017-04-27 17:27:46 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-04-27 19:13:41 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f72420b280a531f5db4d636b8f1a...

Powered by Google App Engine
This is Rietveld 408576698