Adding close button in SigninPromoView

ios/chrome/browser/ui/bookmarks/bookmark_signin_promo_cell.mm

Index: ios/chrome/browser/ui/bookmarks/bookmark_signin_promo_cell.mm
diff --git a/ios/chrome/browser/ui/bookmarks/bookmark_signin_promo_cell.mm b/ios/chrome/browser/ui/bookmarks/bookmark_signin_promo_cell.mm
index 14bbbf0deb0817dd97185432e8df641d57a86198..05d46407f5f926f3b2b631b460ce05095cf5ea46 100644
--- a/ios/chrome/browser/ui/bookmarks/bookmark_signin_promo_cell.mm
+++ b/ios/chrome/browser/ui/bookmarks/bookmark_signin_promo_cell.mm
@@ -33,6 +33,7 @@
     UIView* contentView = self.contentView;
     _signinPromoView = [[SigninPromoView alloc] initWithFrame:self.bounds];
     _signinPromoView.translatesAutoresizingMaskIntoConstraints = NO;
+    _signinPromoView.dismissButton.hidden = NO;

[msarda, 2017/04/28 16:08:16]

It looks like the button is only used by the BookmarksPromoCell. Could it be
moved from the SigninPromoView to BookmarkSigninPromoCell (basically make it a
subview of the BookmarkSigninPromoCell's contentView)?

That would allow us to add the SignInPromoView to other UIs in the future that
may have a different dismiss button.

[lpromero, 2017/05/02 16:46:04]

Good idea.

[jlebel, 2017/05/03 12:41:14]

I would hope for the user, we will use the same kind of mechanism to dismiss
this promo...

     [contentView addSubview:_signinPromoView];
     AddSameConstraints(_signinPromoView, contentView);
     _signinPromoView.backgroundColor = [UIColor whiteColor];