Adding close button in SigninPromoView

ios/chrome/browser/ui/bookmarks/bookmark_signin_promo_cell.mm

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/chrome/browser/ui/bookmarks/bookmark_signin_promo_cell.h"
 
 #import "ios/chrome/browser/ui/authentication/signin_promo_view.h"
 #import "ios/chrome/browser/ui/uikit_ui_util.h"
 #include "ios/chrome/grit/ios_chromium_strings.h"
 #include "ui/base/l10n/l10n_util.h"
@@ skipping 15 matching lines @@
 + (BOOL)requiresConstraintBasedLayout {
   return YES;
 }
 
 - (instancetype)initWithFrame:(CGRect)frame {
   self = [super initWithFrame:frame];
   if (self) {
     UIView* contentView = self.contentView;
     _signinPromoView = [[SigninPromoView alloc] initWithFrame:self.bounds];
     _signinPromoView.translatesAutoresizingMaskIntoConstraints = NO;
+    _signinPromoView.dismissButton.hidden = NO;

[msarda, 2017/04/28 16:08:16]

It looks like the button is only used by the BookmarksPromoCell. Could it be
moved from the SigninPromoView to BookmarkSigninPromoCell (basically make it a
subview of the BookmarkSigninPromoCell's contentView)?

That would allow us to add the SignInPromoView to other UIs in the future that
may have a different dismiss button.

[lpromero, 2017/05/02 16:46:04]

Good idea.

[jlebel, 2017/05/03 12:41:14]

I would hope for the user, we will use the same kind of mechanism to dismiss
this promo...

     [contentView addSubview:_signinPromoView];
     AddSameConstraints(_signinPromoView, contentView);
     _signinPromoView.backgroundColor = [UIColor whiteColor];
     _signinPromoView.textLabel.text =
         l10n_util::GetNSString(IDS_IOS_SIGNIN_PROMO_SETTINGS);
   }
   return self;
 }
 
 - (void)layoutSubviews {
   // Adjust the text label preferredMaxLayoutWidth according self.frame.width,
   // so the text will adjust its height and not its width.
   CGFloat parentWidth = CGRectGetWidth(self.bounds);
   _signinPromoView.textLabel.preferredMaxLayoutWidth =
       parentWidth - 2 * _signinPromoView.horizontalPadding;
 
   // Re-layout with the new preferred width to allow the label to adjust its
   // height.
   [super layoutSubviews];
 }
 
 @end