Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 2844223004: [scheduler] Always run task queue observer callback for delayed work. (Closed)

Created:
3 years, 7 months ago by altimin
Modified:
3 years, 7 months ago
Reviewers:
Sami
CC:
chromium-reviews, blink-reviews, kinuko+watch, scheduler-bugs_chromium.org, Dan Elphick
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[scheduler] Always run task queue observer callback for delayed work. Run task queue observer callback even when there is immediate work availaible. This will prevent some renderers from stucking in a throttled state with a fence. This is a temporary solution enabling delphick@ to revert his patch. A proper fix and test coverage will come later. R=skyostil@chromium.org CC=delphick@chromium.org BUG=710095 Review-Url: https://codereview.chromium.org/2844223004 Cr-Commit-Position: refs/heads/master@{#467956} Committed: https://chromium.googlesource.com/chromium/src/+/3191760f829c032a77fa498d0147b7317028a6c0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.cc View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (7 generated)
Sami
lgtm.
3 years, 7 months ago (2017-04-28 10:13:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2844223004/1
3 years, 7 months ago (2017-04-28 10:23:33 UTC) #7
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 11:06:20 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3191760f829c032a77fa498d0147...

Powered by Google App Engine
This is Rietveld 408576698