Description was changed from ========== Fix behaviour of shadow interpolation with mismatched list lengths BUG=713674 ...
3 years, 7 months ago
(2017-04-27 05:54:22 UTC)
#1
Description was changed from
==========
Fix behaviour of shadow interpolation with mismatched list lengths
BUG=713674
==========
to
==========
Fix behaviour of shadow interpolation with mismatched list lengths
For shadow properties like box-shadow and text-shadow we were
incorrectly interpolating shadow lists with mismatched lengths.
The old behaviour would repeat each list to the lowest common multiple,
the correct behaviour is to pad the shorted list with "zero" shadows.
Spec: https://www.w3.org/TR/css3-transitions/#animatable-types
This change adds the "padding" behaviour to list interpolation and
composition and updates our test cases to match spec behaviour.
BUG=713674
==========
3 years, 7 months ago
(2017-04-27 05:55:36 UTC)
#3
shend
lgtm with nits. https://codereview.chromium.org/2844213002/diff/20001/third_party/WebKit/LayoutTests/animations/interpolation/text-shadow-interpolation.html File third_party/WebKit/LayoutTests/animations/interpolation/text-shadow-interpolation.html (right): https://codereview.chromium.org/2844213002/diff/20001/third_party/WebKit/LayoutTests/animations/interpolation/text-shadow-interpolation.html#newcode26 third_party/WebKit/LayoutTests/animations/interpolation/text-shadow-interpolation.html:26: to: 'green 20px 20px 20px', What ...
3 years, 7 months ago
(2017-04-27 06:07:49 UTC)
#4
Description was changed from ========== Fix behaviour of shadow interpolation with mismatched list lengths For ...
3 years, 7 months ago
(2017-04-27 07:08:51 UTC)
#5
Description was changed from
==========
Fix behaviour of shadow interpolation with mismatched list lengths
For shadow properties like box-shadow and text-shadow we were
incorrectly interpolating shadow lists with mismatched lengths.
The old behaviour would repeat each list to the lowest common multiple,
the correct behaviour is to pad the shorted list with "zero" shadows.
Spec: https://www.w3.org/TR/css3-transitions/#animatable-types
This change adds the "padding" behaviour to list interpolation and
composition and updates our test cases to match spec behaviour.
BUG=713674
==========
to
==========
Fix behaviour of shadow interpolation with mismatched list lengths
For shadow properties like box-shadow and text-shadow we were
incorrectly interpolating shadow lists with mismatched lengths.
The old behaviour would repeat each list to the lowest common multiple,
the correct behaviour is to pad the shorted list with "zero" shadows.
Spec: https://www.w3.org/TR/css3-transitions/#animatable-types
This change adds the "padding" behaviour to list interpolation and
composition and updates our shadow animation test cases to match
spec behaviour.
BUG=713674
==========
alancutter (OOO until 2018)
https://codereview.chromium.org/2844213002/diff/20001/third_party/WebKit/LayoutTests/animations/interpolation/text-shadow-interpolation.html File third_party/WebKit/LayoutTests/animations/interpolation/text-shadow-interpolation.html (right): https://codereview.chromium.org/2844213002/diff/20001/third_party/WebKit/LayoutTests/animations/interpolation/text-shadow-interpolation.html#newcode26 third_party/WebKit/LayoutTests/animations/interpolation/text-shadow-interpolation.html:26: to: 'green 20px 20px 20px', On 2017/04/27 at 06:07:49, ...
3 years, 7 months ago
(2017-04-27 07:09:22 UTC)
#6
https://codereview.chromium.org/2844213002/diff/20001/third_party/WebKit/LayoutTests/animations/interpolation/text-shadow-interpolation.html File third_party/WebKit/LayoutTests/animations/interpolation/text-shadow-interpolation.html (right): https://codereview.chromium.org/2844213002/diff/20001/third_party/WebKit/LayoutTests/animations/interpolation/text-shadow-interpolation.html#newcode26 third_party/WebKit/LayoutTests/animations/interpolation/text-shadow-interpolation.html:26: to: 'green 20px 20px 20px', On 2017/04/27 at 07:09:22, ...
3 years, 7 months ago
(2017-04-27 07:30:51 UTC)
#7
https://codereview.chromium.org/2844213002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/animations/interpolation/text-shadow-interpolation.html
(right):
https://codereview.chromium.org/2844213002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/animations/interpolation/text-shadow-interpolation.html:26:
to: 'green 20px 20px 20px',
On 2017/04/27 at 07:09:22, alancutter wrote:
> On 2017/04/27 at 06:07:49, shend wrote:
> > What are these changes for?
>
> Oops, forgot I did these.
> They're to make the input values consistent with the output values where the
colour is on the left to make it easier to read. Can remove if too unrelated.
Nah it seems fine to keep it.
alancutter (OOO until 2018)
The CQ bit was checked by alancutter@chromium.org
3 years, 7 months ago
(2017-04-28 23:42:25 UTC)
#8
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 7 months ago
(2017-04-28 23:43:18 UTC)
#12
No L-G-T-M from a valid reviewer yet.
CQ run can only be started once the patch has received an L-G-T-M from a full
committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a
full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.
3 years, 7 months ago
(2017-04-29 23:27:49 UTC)
#14
+suzyh for OWNERS review.
suzyh_UTC10 (ex-contributor)
rs lgtm https://codereview.chromium.org/2844213002/diff/40001/third_party/WebKit/LayoutTests/animations/interpolation/text-shadow-interpolation.html File third_party/WebKit/LayoutTests/animations/interpolation/text-shadow-interpolation.html (right): https://codereview.chromium.org/2844213002/diff/40001/third_party/WebKit/LayoutTests/animations/interpolation/text-shadow-interpolation.html#newcode26 third_party/WebKit/LayoutTests/animations/interpolation/text-shadow-interpolation.html:26: to: 'green 20px 20px 20px', Is colour-at-end ...
3 years, 7 months ago
(2017-05-01 00:23:55 UTC)
#15
https://codereview.chromium.org/2844213002/diff/40001/third_party/WebKit/LayoutTests/animations/interpolation/text-shadow-interpolation.html File third_party/WebKit/LayoutTests/animations/interpolation/text-shadow-interpolation.html (right): https://codereview.chromium.org/2844213002/diff/40001/third_party/WebKit/LayoutTests/animations/interpolation/text-shadow-interpolation.html#newcode26 third_party/WebKit/LayoutTests/animations/interpolation/text-shadow-interpolation.html:26: to: 'green 20px 20px 20px', On 2017/05/01 at 00:23:55, ...
3 years, 7 months ago
(2017-05-08 06:36:42 UTC)
#16
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/447381)
3 years, 7 months ago
(2017-05-08 08:50:49 UTC)
#21
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/448273)
3 years, 7 months ago
(2017-05-09 01:26:15 UTC)
#26
CQ is committing da patch. Bot data: {"patchset_id": 80001, "attempt_start_ts": 1494297570535110, "parent_rev": "08ce463ab55e4d777f21f394a78cefaaa5a777f1", "commit_rev": "4aaaf95a33ef49f61476ca1f3699700fa7ea3fe8"}
3 years, 7 months ago
(2017-05-09 04:29:20 UTC)
#29
CQ is committing da patch.
Bot data: {"patchset_id": 80001, "attempt_start_ts": 1494297570535110,
"parent_rev": "08ce463ab55e4d777f21f394a78cefaaa5a777f1", "commit_rev":
"4aaaf95a33ef49f61476ca1f3699700fa7ea3fe8"}
commit-bot: I haz the power
Description was changed from ========== Fix behaviour of shadow interpolation with mismatched list lengths For ...
3 years, 7 months ago
(2017-05-09 04:29:29 UTC)
#30
Message was sent while issue was closed.
Description was changed from
==========
Fix behaviour of shadow interpolation with mismatched list lengths
For shadow properties like box-shadow and text-shadow we were
incorrectly interpolating shadow lists with mismatched lengths.
The old behaviour would repeat each list to the lowest common multiple,
the correct behaviour is to pad the shorted list with "zero" shadows.
Spec: https://www.w3.org/TR/css3-transitions/#animatable-types
This change adds the "padding" behaviour to list interpolation and
composition and updates our shadow animation test cases to match
spec behaviour.
BUG=713674
==========
to
==========
Fix behaviour of shadow interpolation with mismatched list lengths
For shadow properties like box-shadow and text-shadow we were
incorrectly interpolating shadow lists with mismatched lengths.
The old behaviour would repeat each list to the lowest common multiple,
the correct behaviour is to pad the shorted list with "zero" shadows.
Spec: https://www.w3.org/TR/css3-transitions/#animatable-types
This change adds the "padding" behaviour to list interpolation and
composition and updates our shadow animation test cases to match
spec behaviour.
BUG=713674
Review-Url: https://codereview.chromium.org/2844213002
Cr-Commit-Position: refs/heads/master@{#470205}
Committed:
https://chromium.googlesource.com/chromium/src/+/4aaaf95a33ef49f61476ca1f3699...
==========
commit-bot: I haz the power
Committed patchset #5 (id:80001) as https://chromium.googlesource.com/chromium/src/+/4aaaf95a33ef49f61476ca1f3699700fa7ea3fe8
3 years, 7 months ago
(2017-05-09 04:29:30 UTC)
#31
Issue 2844213002: Fix behaviour of shadow interpolation with mismatched list lengths
(Closed)
Created 3 years, 7 months ago by alancutter (OOO until 2018)
Modified 3 years, 7 months ago
Reviewers: shend, suzyh_UTC10 (ex-contributor)
Base URL:
Comments: 7