Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2844203002:
[fetch] add tests for fetch subcommand parsing. (Closed)
|
Created:
3 years, 8 months ago by iannucci Modified:
3 years, 7 months ago CC:
chromium-reviews, infra-reviews+recipes-py_chromium.org Target Ref:
refs/heads/master Project:
recipe_engine Visibility:
Public. |
Description[fetch] add tests for fetch subcommand parsing.
R=dnj@chromium.org, phajdan.jr@chromium.org
BUG=
Review-Url: https://codereview.chromium.org/2844203002
Committed: https://github.com/luci/recipes-py/commit/b88c9ec7e384c253a3d7839e00281c981f0eb87b
Patch Set 1 #Patch Set 2 : rebase #Patch Set 3 : rebase #Patch Set 4 : vendored argparse #Patch Set 5 : rebase #
Messages
Total messages: 24 (20 generated)
The CQ bit was checked by iannucci@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Recipes-py Presubmit on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/35c6314768629010)
The CQ bit was checked by iannucci@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Recipes-py Presubmit on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/35c67878dbce0710)
The CQ bit was checked by iannucci@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Recipes-py Presubmit on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/35c6987b620f2910)
The CQ bit was checked by iannucci@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by iannucci@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dnj@chromium.org Link to the patchset: https://codereview.chromium.org/2844203002/#ps80001 (title: "rebase")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 80001, "attempt_start_ts": 1493491903199740,
"parent_rev": "aa45f3d6a7daaf1d32c1efeda9645e2f134fc959", "commit_rev":
"b88c9ec7e384c253a3d7839e00281c981f0eb87b"}
Message was sent while issue was closed.
Description was changed from ========== [fetch] add tests for fetch subcommand parsing. R=dnj@chromium.org, phajdan.jr@chromium.org BUG= ========== to ========== [fetch] add tests for fetch subcommand parsing. R=dnj@chromium.org, phajdan.jr@chromium.org BUG= Review-Url: https://codereview.chromium.org/2844203002 Committed: https://github.com/luci/recipes-py/commit/b88c9ec7e384c253a3d7839e00281c981f0... ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as https://github.com/luci/recipes-py/commit/b88c9ec7e384c253a3d7839e00281c981f0... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
