Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(639)

Unified Diff: chrome/browser/ui/sad_tab.cc

Issue 2844193002: Add UMA histogram to track the various sources that request the feedback app (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/sad_tab.cc
diff --git a/chrome/browser/ui/sad_tab.cc b/chrome/browser/ui/sad_tab.cc
index 5c88b0cce6c8b5404117a9dfec25bbe1edf65efd..a062f6629fb7cdaa055b81907f1ee23f0e97b7ca 100644
--- a/chrome/browser/ui/sad_tab.cc
+++ b/chrome/browser/ui/sad_tab.cc
@@ -53,7 +53,7 @@ void RecordEvent(bool feedback, SadTabEvent event) {
}
}
-const char kCategoryTagCrash[] = "Crash";
+constexpr char kCategoryTagCrash[] = "Crash";
bool ShouldShowFeedbackButton() {
#if defined(GOOGLE_CHROME_BUILD)
@@ -158,12 +158,13 @@ void SadTab::PerformAction(SadTab::Action action) {
case Action::BUTTON:
RecordEvent(show_feedback_button_, SadTabEvent::BUTTON_CLICKED);
if (show_feedback_button_) {
- chrome::ShowFeedbackPage(
- chrome::FindBrowserWithWebContents(web_contents_),
- l10n_util::GetStringUTF8(kind_ == chrome::SAD_TAB_KIND_CRASHED
+ ShowFeedbackPage(
+ FindBrowserWithWebContents(web_contents_),
+ kFeedbackSourceSadTabPage,
+ l10n_util::GetStringUTF8(kind_ == SAD_TAB_KIND_CRASHED
? IDS_CRASHED_TAB_FEEDBACK_MESSAGE
: IDS_KILLED_TAB_FEEDBACK_MESSAGE),
- std::string(kCategoryTagCrash));
+ kCategoryTagCrash);
} else {
web_contents_->GetController().Reload(content::ReloadType::NORMAL,
true);

Powered by Google App Engine
This is Rietveld 408576698