Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 2844163006: [wasm] Move Table.Grow implementation to wasm-objects.cc, cleanup (Closed)

Created:
3 years, 7 months ago by gdeepti
Modified:
3 years, 7 months ago
Reviewers:
bradnelson
CC:
v8-reviews_googlegroups.com, wasm-v8_google.com, ahaas
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Move Table.Grow implementation to wasm-objects.cc, cleanup BUG=v8:6325 R=bradnelson@chromium.org Review-Url: https://codereview.chromium.org/2844163006 Cr-Commit-Position: refs/heads/master@{#45002} Committed: https://chromium.googlesource.com/v8/v8/+/fc5079d34bd91f824aacd6d18c487e9ef59349f9

Patch Set 1 #

Patch Set 2 : Cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -50 lines) Patch
M src/wasm/wasm-js.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/wasm/wasm-module.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/wasm/wasm-module.cc View 1 2 chunks +2 lines, -35 lines 0 comments Download
M src/wasm/wasm-objects.h View 1 chunk +2 lines, -3 lines 0 comments Download
M src/wasm/wasm-objects.cc View 3 chunks +32 lines, -7 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
gdeepti
3 years, 7 months ago (2017-04-29 00:26:52 UTC) #6
bradnelson
lgtm
3 years, 7 months ago (2017-05-01 16:30:41 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2844163006/20001
3 years, 7 months ago (2017-05-01 16:30:43 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-01 17:02:30 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/fc5079d34bd91f824aacd6d18c487e9ef59...

Powered by Google App Engine
This is Rietveld 408576698