Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 2844133005: Use completion_time to call LoadingFinished of DevTools's Network event for navigation preload (Closed)

Created:
3 years, 7 months ago by horo
Modified:
3 years, 7 months ago
Reviewers:
kinuko
CC:
chromium-reviews, jam, darin-cc_chromium.org, pfeldman, devtools-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use completion_time to call LoadingFinished of DevTools's Network event for navigation preload Currently NetworkHandler::NavigationPreloadCompleted() is using TimeTicks::Now() to call LoadingFinished() of DevTools's Network event. But for normal requests from the renderer, FrameFetchContext::DispatchDidFinishLoading() is using the |finish_time| which is originated from ResourceRequestCompletionStatus's completion_time. NetworkHandler::NavigationPreloadCompleted() should use the same timing information. I found this difference while investigating the issue 712809. |completion_time| is set when the request finished but, NavigationPreloadCompleted() isn't called before the service worker finishes starting up. BUG=712809 Review-Url: https://codereview.chromium.org/2844133005 Cr-Commit-Position: refs/heads/master@{#467896} Committed: https://chromium.googlesource.com/chromium/src/+/99d003caf2d7876a7e402a07caa94a5c24ccb922

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M content/browser/devtools/protocol/network_handler.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (11 generated)
horo
kinuko@ Could you please review?
3 years, 7 months ago (2017-04-28 03:01:38 UTC) #7
kinuko
lgtm
3 years, 7 months ago (2017-04-28 03:09:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2844133005/1
3 years, 7 months ago (2017-04-28 04:20:47 UTC) #12
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 05:22:33 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/99d003caf2d7876a7e402a07caa9...

Powered by Google App Engine
This is Rietveld 408576698