Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 2844113002: Revert of Adds error handling support for the SwReporter launcher. (Closed)

Created:
3 years, 7 months ago by alph
Modified:
3 years, 7 months ago
CC:
chromium-reviews, vakh+watch_chromium.org, joenotcharles+watch_chromium.org, grt+watch_chromium.org, timvolodine, csharp+watch_chromium.org, alito+watch_chromium.org, ftirelo+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Adds error handling support for the SwReporter launcher. (patchset #9 id:160001 of https://codereview.chromium.org/2834613003/ ) Reason for revert: Broke several browser tests https://build.chromium.org/p/chromium.win/builders/Win7%20%2832%29%20Tests/builds/19199 Original issue's description: > Adds error handling support for the SwReporter launcher. > > BUG=690020 > > Review-Url: https://codereview.chromium.org/2834613003 > Cr-Commit-Position: refs/heads/master@{#467471} > Committed: https://chromium.googlesource.com/chromium/src/+/e012fe8a8e4d60ed8eba17fbac5df6d9fc4bcad3 TBR=joenotcharles@chromium.org,grt@chromium.org,jialiul@chromium.org,ftirelo@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=690020 Review-Url: https://codereview.chromium.org/2844113002 Cr-Commit-Position: refs/heads/master@{#467493} Committed: https://chromium.googlesource.com/chromium/src/+/13b26dffd848c02b1ae0f4ed86986b2a474056c1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -225 lines) Patch
M chrome/browser/safe_browsing/srt_chrome_prompt_impl.h View 3 chunks +1 line, -6 lines 0 comments Download
M chrome/browser/safe_browsing/srt_chrome_prompt_impl.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M chrome/browser/safe_browsing/srt_fetcher_browsertest_win.cc View 20 chunks +12 lines, -152 lines 0 comments Download
M chrome/browser/safe_browsing/srt_fetcher_win.h View 3 chunks +5 lines, -28 lines 0 comments Download
M chrome/browser/safe_browsing/srt_fetcher_win.cc View 9 chunks +10 lines, -34 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
alph
Created Revert of Adds error handling support for the SwReporter launcher.
3 years, 7 months ago (2017-04-26 22:51:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2844113002/1
3 years, 7 months ago (2017-04-26 22:52:20 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-04-26 22:54:10 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/13b26dffd848c02b1ae0f4ed8698...

Powered by Google App Engine
This is Rietveld 408576698