Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 2844103002: [Media Router] Add README.md for DIAL discovery (Closed)

Created:
3 years, 8 months ago by zhaobin
Modified:
3 years, 7 months ago
Reviewers:
mark a. foltz, imcheng
CC:
chromium-reviews, feature-media-reviews_chromium.org, media-router+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Media Router] Add README.md for DIAL discovery BUG=687375 Review-Url: https://codereview.chromium.org/2844103002 Cr-Commit-Position: refs/heads/master@{#467918} Committed: https://chromium.googlesource.com/chromium/src/+/18ec3f9860a0b3069fc6f32a28fd48b158e1f409

Patch Set 1 #

Patch Set 2 : resolve code review comments from Mark #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
A chrome/browser/media/router/discovery/dial/README.md View 1 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
zhaobin
3 years, 8 months ago (2017-04-26 22:37:38 UTC) #2
mark a. foltz
LGTM See https://guides.github.com/features/mastering-markdown/ for styling hints. Maybe: # DIAL Discovery Implementation of local network discovery ...
3 years, 8 months ago (2017-04-26 22:50:15 UTC) #3
imcheng
lgtm after comments addressed
3 years, 8 months ago (2017-04-26 22:53:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2844103002/20001
3 years, 7 months ago (2017-04-28 06:11:40 UTC) #7
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 06:23:50 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/18ec3f9860a0b3069fc6f32a28fd...

Powered by Google App Engine
This is Rietveld 408576698