Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 2844063006: [TTS] Fix long-press tests to allow empty strings. (Closed)

Created:
3 years, 7 months ago by Donn Denman
Modified:
3 years, 7 months ago
Reviewers:
Theresa
CC:
chromium-reviews, twellington+watch_chromium.org, donnd+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[TTS] Fix long-press tests to allow empty strings. Fixes recent tablet failures. We have two tablet tests on long-press having the selection become empty after a sequence that includes selecting. For some reason the latest CS seems to change to an empty string instead of null so the tests fail on M. Not sure what the underlaying cause is, but seems to work fine to just check that the text is empty rather than checking explicitly for null. BUG=715978 TBR=twellington Review-Url: https://codereview.chromium.org/2844063006 Cr-Commit-Position: refs/heads/master@{#467794} Committed: https://chromium.googlesource.com/chromium/src/+/3b05f273c3b5054cbc960aedf38ee2f0fc2fd021

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java View 2 chunks +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (6 generated)
Donn Denman
Theresa, PTAL.
3 years, 7 months ago (2017-04-27 20:10:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2844063006/1
3 years, 7 months ago (2017-04-27 20:54:09 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-04-27 21:31:06 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3b05f273c3b5054cbc960aedf38e...

Powered by Google App Engine
This is Rietveld 408576698