Update notification.idl following the Mac OS X changes

Update notification.idl following the Mac OS X changes

BUG=715691
Review-Url: https://codereview.chromium.org/2844043002
Cr-Commit-Position: refs/heads/master@{#467636}
Committed: https://chromium.googlesource.com/chromium/src/+/4840b4c8969155b9da3ae6f36fce95c3416bd35f

[Peter Beverloo, 2017-04-26 18:40:25]

peter@chromium.org changed reviewers:
+ mkearney@chromium.org

[Peter Beverloo, 2017-04-26 18:40:26]

+mkearney for docs changes

[mattgaunt, 2017-04-26 20:43:41]

On 2017/04/26 18:40:26, Peter Beverloo wrote:
> +mkearney for docs changes

LGTM

[mkearney1, 2017-04-26 23:38:58]

Small nits is all... otherwise lgtm.

https://codereview.chromium.org/2844043002/diff/1/chrome/common/extensions/ap...
File chrome/common/extensions/api/notifications.idl (right):

https://codereview.chromium.org/2844043002/diff/1/chrome/common/extensions/ap...
chrome/common/extensions/api/notifications.idl:13: [deprecated="The image will
not be visible for Mac OS X users."]
Small nit: The image is not visible for Mac OS X users.

https://codereview.chromium.org/2844043002/diff/1/chrome/common/extensions/ap...
chrome/common/extensions/api/notifications.idl:17: // only see the first item.
Small nit: Users on Mac OS X only see the first item.

https://codereview.chromium.org/2844043002/diff/1/chrome/common/extensions/ap...
chrome/common/extensions/api/notifications.idl:49: [deprecated="Button icons
will not be visible for Mac OS X users."]
Small nit: Button icons not visible for Mac OS X users.

https://codereview.chromium.org/2844043002/diff/1/chrome/common/extensions/ap...
chrome/common/extensions/api/notifications.idl:74: DOMString? appIconMaskUrl;
Small nit: The app icon mask is not visible for Mac OS X users.

https://codereview.chromium.org/2844043002/diff/1/chrome/common/extensions/ap...
chrome/common/extensions/api/notifications.idl:108: DOMString? imageUrl;
Small nit: The image is not visible for Mac OS X users.

https://codereview.chromium.org/2844043002/diff/1/chrome/common/extensions/ap...
chrome/common/extensions/api/notifications.idl:113: NotificationItem[]? items;
Small nit: Users on Mac OS X only see the first item.

[Peter Beverloo, 2017-04-27 10:30:00]

Thank you!

https://codereview.chromium.org/2844043002/diff/1/chrome/common/extensions/ap...
File chrome/common/extensions/api/notifications.idl (right):

https://codereview.chromium.org/2844043002/diff/1/chrome/common/extensions/ap...
chrome/common/extensions/api/notifications.idl:13: [deprecated="The image will
not be visible for Mac OS X users."]
On 2017/04/26 23:38:58, mkearney1 wrote:
> Small nit: The image is not visible for Mac OS X users.

Done.

https://codereview.chromium.org/2844043002/diff/1/chrome/common/extensions/ap...
chrome/common/extensions/api/notifications.idl:17: // only see the first item.
On 2017/04/26 23:38:58, mkearney1 wrote:
> Small nit: Users on Mac OS X only see the first item.

Done.

https://codereview.chromium.org/2844043002/diff/1/chrome/common/extensions/ap...
chrome/common/extensions/api/notifications.idl:49: [deprecated="Button icons
will not be visible for Mac OS X users."]
On 2017/04/26 23:38:58, mkearney1 wrote:
> Small nit: Button icons not visible for Mac OS X users.

Done.

https://codereview.chromium.org/2844043002/diff/1/chrome/common/extensions/ap...
chrome/common/extensions/api/notifications.idl:74: DOMString? appIconMaskUrl;
On 2017/04/26 23:38:57, mkearney1 wrote:
> Small nit: The app icon mask is not visible for Mac OS X users.

Done.

https://codereview.chromium.org/2844043002/diff/1/chrome/common/extensions/ap...
chrome/common/extensions/api/notifications.idl:108: DOMString? imageUrl;
On 2017/04/26 23:38:57, mkearney1 wrote:
> Small nit: The image is not visible for Mac OS X users.

Done.

https://codereview.chromium.org/2844043002/diff/1/chrome/common/extensions/ap...
chrome/common/extensions/api/notifications.idl:113: NotificationItem[]? items;
On 2017/04/26 23:38:57, mkearney1 wrote:
> Small nit: Users on Mac OS X only see the first item.

Done.

[Peter Beverloo, 2017-04-27 10:30:10]

The CQ bit was checked by peter@chromium.org

[Peter Beverloo, 2017-04-27 10:30:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
mkearney@chromium.org, mattgaunt@google.com
Link to the patchset: https://codereview.chromium.org/2844043002/#ps20001
(title: "Update notification.idl following the Mac OS X changes")

[commit-bot: I haz the power, 2017-04-27 10:30:21]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 11:17:27]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493289010126450,
"parent_rev": "03d8a3084d1e21b685437607961f5ddccdf032b1", "commit_rev":
"4840b4c8969155b9da3ae6f36fce95c3416bd35f"}

[commit-bot: I haz the power, 2017-04-27 11:17:38]

Description was changed from

==========
Update notification.idl following the Mac OS X changes

BUG=715691
==========

to

==========
Update notification.idl following the Mac OS X changes

BUG=715691

Review-Url: https://codereview.chromium.org/2844043002
Cr-Commit-Position: refs/heads/master@{#467636}
Committed:
https://chromium.googlesource.com/chromium/src/+/4840b4c8969155b9da3ae6f36fce...
==========

[commit-bot: I haz the power, 2017-04-27 11:17:39]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4840b4c8969155b9da3ae6f36fce...