Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4041)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java

Issue 2844033002: 📰 Move metrics and scheduling events out of SnippetsBridge (Closed)
Patch Set: rebase, address comment Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java
index 03bde1e58642a8c1031cb6d11f1bd9e8480c5377..01810870423cb8abcecb5aba852aa8e27b431683 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java
@@ -140,7 +140,7 @@ public void onDisplayStyleChanged(UiConfig.DisplayStyle newDisplayStyle) {
@Override
public void onImpression() {
if (mArticle != null && mArticle.trackImpression()) {
- mUiDelegate.getMetricsReporter().onSuggestionShown(mArticle);
+ mUiDelegate.getEventReporter().onSuggestionShown(mArticle);
mRecyclerView.onSnippetImpression();
}
}
@@ -148,13 +148,15 @@ public void onImpression() {
@Override
public void onCardTapped() {
int windowDisposition = WindowOpenDisposition.CURRENT_TAB;
- mUiDelegate.getMetricsReporter().onSuggestionOpened(mArticle, windowDisposition);
+ mUiDelegate.getEventReporter().onSuggestionOpened(
+ mArticle, windowDisposition, mUiDelegate.getSuggestionsRanker());
mUiDelegate.getNavigationDelegate().openSnippet(windowDisposition, mArticle);
}
@Override
public void openItem(int windowDisposition) {
- mUiDelegate.getMetricsReporter().onSuggestionOpened(mArticle, windowDisposition);
+ mUiDelegate.getEventReporter().onSuggestionOpened(
+ mArticle, windowDisposition, mUiDelegate.getSuggestionsRanker());
mUiDelegate.getNavigationDelegate().openSnippet(windowDisposition, mArticle);
}
@@ -173,7 +175,7 @@ public boolean isItemSupported(@ContextMenuItemId int menuItemId) {
@Override
public void onContextMenuCreated() {
- mUiDelegate.getMetricsReporter().onSuggestionMenuOpened(mArticle);
+ mUiDelegate.getEventReporter().onSuggestionMenuOpened(mArticle);
}
/**

Powered by Google App Engine
This is Rietveld 408576698